From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 170A1A034F; Wed, 13 May 2020 12:33:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 425AA1D15E; Wed, 13 May 2020 12:33:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7A3ED1D157 for ; Wed, 13 May 2020 12:33:07 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04DATnhu006664; Wed, 13 May 2020 03:33:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=8WNEa7gonJjCw6Y+ppceKB5+JdlkbUrsqSX2QOfFDfw=; b=lyMlk1YQM3Y+yS6b7QAa/7b0gIYShFTRVQAFg6FH7YnPU1KLPQ2ZlHdvrk37zOaxlOqQ J/VOAiTYQGyX91MCZMZzOUaWiwKJ1M90dJut3j5HLXNE2lcZ1i5LJPyUptHUrsnb+8q9 E4us8ilyMIbb5iEX5zx9ts7NKuESRSb/3AKzLJUFrlX/cBMnWbLPpQBVFU6kMNAk9c+6 1i3JYR5PSzO7hX+o0hlA0PlYopGAZF9muK/knC2h3aZHCODVHUwm6jM5pnlGO8WzbOhW r13NnrMMq1lSVpjWOkyQTyHG5xVUTeQIO0xR+pfL9npDCW8PQfdjhATasQnHsFS7O0a5 Jw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 3100xjuyp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 13 May 2020 03:33:02 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 13 May 2020 03:33:00 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 13 May 2020 03:32:59 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 13 May 2020 03:32:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InFQXq5dKLFNawWHvDvJlIodNV/fugVuLYFQepJly4v4xEie8yyGhYMDhvGQApB2LDLjqscmbz7NC9TNpN5igILqxrG+Lx9qfBBcTxUVr3EE9W1dTG1YWuWAr+YUqUbuYBdsqCdRUq2844T3UNjO5MH0e/rubtLtoJMPhPFdthF50pXkjqUa+8eVgUOpNRe2BQdrH+qfk/jHwJkeY+lO4jpZ8ph6uDDyZBw4Xs33YtLy45eOeCaG1kS6Q7lAG2+kMfz3PoLGDfHI3+9P6qa3tpiw2YeACITH3GapgWLspnb9yub9dYSSYixmcDoAeYF3+9IUECYgm1JQLcPjdvCZ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WNEa7gonJjCw6Y+ppceKB5+JdlkbUrsqSX2QOfFDfw=; b=OSg2exAQiyJ4ju/zzLnbmKlIUweCh4iJQENGw1VQgrOq7OxJEa0lKse6irTukhRuhoje5ZYSmY686nFMShO+9efgV5hU+JgkpsXMPVVC9ODtru5FUGheNREP7uqX9Rkw9MZGNBLkaEI+lsSRS4L6tAUl4UcysY7ClkFFarcJ1q+9clQh4Ds+ArfVknwO1Bx4XPq/6vd00S/5m7jXtC/od9bUTF1ALJlN9WA/Ghctu46uOlRBqaMA3bVViQXWhztEVljKcm+e6ZeM3bXs2/TCLjxz0XYoNf+fQgOXubu671kGkd8IBCCtyVQqmEc1l4cUwv3mw91ai7KihE8R4CAROg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8WNEa7gonJjCw6Y+ppceKB5+JdlkbUrsqSX2QOfFDfw=; b=sImCzVq3daXLfblJaruO+zOg5b1n/HR+hJ4b3wk89jApsIDcgSP0guTt/AIMUQhYRYQNRhNfCjH2PfoBfpXxNhTsx0ocIfMfTk0htHrnyWJNbH6ZpWVum/MUZb6qc5bhCOwg+b15IJWZgJFMGNfL1m5Eg9ph+4FPeeBVJNw3nfo= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2487.namprd18.prod.outlook.com (2603:10b6:a03:139::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Wed, 13 May 2020 10:32:58 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.3000.016; Wed, 13 May 2020 10:32:58 +0000 Date: Wed, 13 May 2020 16:02:41 +0530 From: Nithin Dabilpuram To: Ruifeng Wang CC: "kirankumark@marvell.com" , "jerinj@marvell.com" , "david.marchand@redhat.com" , Pavan Nikhilesh , "dev@dpdk.org" , nd Message-ID: <20200513103241.GA19210@outlook.office365.com> References: <20200513054816.18848-1-ndabilpuram@marvell.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR0101CA0047.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::33) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR0101CA0047.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Wed, 13 May 2020 10:32:54 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79dfbb98-b090-41f1-dc66-08d7f7290087 X-MS-TrafficTypeDiagnostic: BYAPR18MB2487: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:556; X-Forefront-PRVS: 0402872DA1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fjZgrQg2B3ccEaOd9G+o19hCN3X9ooet1ZDHnnNG93WkAjwk3+GWaInzya1LiWpPwKocD/A9VKUdyLpv3OJFaJlYq/3FaHIO112aGimZtjS3vzLpgxaFH8yRWw2E713p52gagKe5nEkq4r1k/pk1dBQZhlXYeGEBN5Wp9LeTxjeUdF2IqnbOhDE+OwbZ1xQQQRlK8ZzK8RHH9dn0KMabeErX1TyK3+wbBtCQVG7pTHJLBOelmW0Tv9km1shmWEiffwWHXQQ8c8vcUNt4tnsUpWX06yN/bT/e53+XMWbpzlLezQ1KQwTY6uT0IDTR0NU/9tKuTA3c/VczGasrffE+yD4mkiGKn3i0nRmHPJ1IpXgKVcNxABJOb35B8QgbS45+DCE/dC82KtYNCvTHxOR5AYcelzrs1YBEOXvPatfBKcXIBLVO4L3FpWXuo+QWL3Au8nhMnGJViSJokUBumhqF4isxJ58W6Hxny5aKPR0/cD2b65WqZAG4OArO85HUfWFj6PSHMRVhhtSr4KldNg5FOg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(33430700001)(6666004)(8676002)(4326008)(55016002)(316002)(5660300002)(6916009)(478600001)(66476007)(66946007)(1076003)(956004)(9686003)(66556008)(33656002)(16526019)(2906002)(186003)(86362001)(26005)(54906003)(7696005)(33440700001)(52116002)(55236004)(53546011)(8936002)(6506007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: CreIrK4o+ilWsDsHUUftO1Inf1PHw/GhIVAAUM7GRkqR7phb2uTpkmnLMCtsrPS2MKRBSnjTXPBYFUCoC8J1BTmkbgNxrADNk0Xy9DpCLEnqC99TGqitr7DDIvFnLkhuuyzpnVUpWJY4nko53iffXX3nurGKSJfj7+H6KIL8u5pAy91nIKYbFoj4XoU3FQcN5P1JnKiYf7DN8pUuhxktP8+BA2dsEk8s3vVSK19DzL7EcOOWa+fq89djJ+cIS6XT17nmc+ucCnXDmhLwN2iax7UN9SVmF2396quwXPYRjqnU77aRZ8Fv+IWkooOjOUM/XCfXyVSxpVJ1bxasC536vAP9LDBbuULSVteGWFtRzzgGZDiuULX5GuYYAG2pNO07FtVeNUfwHN1kuGKX/SiS5S7o5A83S8IZFyq8uNmcBgApFsaaHhzrB+0NhQ+GCcA26KhVDL+DUefCi61yaKiWupG1RiQkKwW+f4WXzF6HGVA= X-MS-Exchange-CrossTenant-Network-Message-Id: 79dfbb98-b090-41f1-dc66-08d7f7290087 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2020 10:32:57.5365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kaHgoPciqNEIn7Sqtpw/1IbruQdoOvOoAPtmM0jJQVeRsjQUSknTFNMR2KofFNi+//qqGQds0iSNYvp0r40B4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2487 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-13_04:2020-05-11, 2020-05-13 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH] node: fix arm64 build issue for older gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 13, 2020 at 08:51:13AM +0000, Ruifeng Wang wrote: > External Email > > ---------------------------------------------------------------------- > > > -----Original Message----- > > From: dev On Behalf Of Nithin Dabilpuram > > Sent: Wednesday, May 13, 2020 1:48 PM > > To: kirankumark@marvell.com; jerinj@marvell.com; > > david.marchand@redhat.com; Nithin Dabilpuram > > ; Pavan Nikhilesh > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] node: fix arm64 build issue for older gcc > > > > Older GCC(~4) complains about uninitialized 'dip' > > var though all the lanes of the vec register are set. > > Better to add compiler output here. > Otherwise looks good to me. > Reviewed-by: Ruifeng Wang Ack. Will send a v2. > > > Hence this patch explicitly initializes vec register to fix the issue. > > > > Fixes: 16df6a2c6671 ("node: add IPv4 lookup for arm64") > > > > Signed-off-by: Nithin Dabilpuram > > --- > > lib/librte_node/ip4_lookup_neon.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_node/ip4_lookup_neon.h > > b/lib/librte_node/ip4_lookup_neon.h > > index bb3150f..dd21cb2 100644 > > --- a/lib/librte_node/ip4_lookup_neon.h > > +++ b/lib/librte_node/ip4_lookup_neon.h > > @@ -45,6 +45,7 @@ ip4_lookup_node_process(struct rte_graph *graph, > > struct rte_node *node, > > rte_prefetch0(rte_pktmbuf_mtod_offset(pkts[i], void *, > > sizeof(struct > > rte_ether_hdr))); > > > > + dip = vdupq_n_s32(0); > > /* Get stream for the speculated next node */ > > to_next = rte_node_next_stream_get(graph, node, next_index, > > nb_objs); > > while (n_left_from >= 4) { > > -- > > 2.8.4 >