[dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

[dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

[Bruce Richardson]

The build scripts called from meson all use python3 as meson itself depends
upon python3. Therefore there is no need for python2 compatibility in these
script files.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 buildtools/map_to_def.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/buildtools/map_to_def.py b/buildtools/map_to_def.py
index 6775b54a9..9edde7a67 100644
--- a/buildtools/map_to_def.py
+++ b/buildtools/map_to_def.py
@@ -1,8 +1,7 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-from __future__ import print_function
 import sys
 from os.path import dirname, basename, join, exists
 
-- 
2.20.1

Re: [dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

[Burakov, Anatoly]

On 13-May-20 12:02 PM, Bruce Richardson wrote:
> The build scripts called from meson all use python3 as meson itself depends
> upon python3. Therefore there is no need for python2 compatibility in these
> script files.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

I think there was a reimplementation of check_output there that isn't 
necessary any more either. (and hasn't been for some time...)

Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

[Bruce Richardson]

On Wed, May 13, 2020 at 12:54:21PM +0100, Burakov, Anatoly wrote:
> On 13-May-20 12:02 PM, Bruce Richardson wrote:
> > The build scripts called from meson all use python3 as meson itself depends
> > upon python3. Therefore there is no need for python2 compatibility in these
> > script files.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> 
> I think there was a reimplementation of check_output there that isn't
> necessary any more either. (and hasn't been for some time...)
>
Not sure what you are referring to here. Perhaps a different script file? 

Re: [dpdk-dev] [PATCH 20.08] buildtools/map_to_def.py: drop python2 support

[Burakov, Anatoly]

On 13-May-20 1:48 PM, Bruce Richardson wrote:
> On Wed, May 13, 2020 at 12:54:21PM +0100, Burakov, Anatoly wrote:
>> On 13-May-20 12:02 PM, Bruce Richardson wrote:
>>> The build scripts called from meson all use python3 as meson itself depends
>>> upon python3. Therefore there is no need for python2 compatibility in these
>>> script files.
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> ---
>>
>> I think there was a reimplementation of check_output there that isn't
>> necessary any more either. (and hasn't been for some time...)
>>
> Not sure what you are referring to here. Perhaps a different script file?
> 

Oh, sorry, yes. I slightly misread the patch description :)

-- 
Thanks,
Anatoly

[dpdk-dev] [PATCH v2] buildtools/map_to_win.py: drop python2 support

[Bruce Richardson]

The build scripts called from meson all use python3 as meson itself depends
upon python3. Therefore there is no need for python2 compatibility in these
script files, as well as which python2 support is being dropped generally
from DPDK.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
V2: rebased for 20.11, since this script is not covered by set 
    http://patches.dpdk.org/project/dpdk/list/?series=11739
---
 buildtools/map_to_win.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/buildtools/map_to_win.py b/buildtools/map_to_win.py
index 2990b58634..2a6cb88605 100644
--- a/buildtools/map_to_win.py
+++ b/buildtools/map_to_win.py
@@ -1,8 +1,7 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-from __future__ import print_function
 import sys
 from os.path import dirname, basename, join, exists
 
-- 
2.25.1