DPDK patches and discussions
 help / color / mirror / Atom feed
From: guohongzhi <guohongzhi1@huawei.com>
To: <dev@dpdk.org>
Cc: <olivier.matz@6wind.com>, <konstantin.ananyev@intel.com>,
	<jiayu.hu@intel.com>, <ferruh.yigit@intel.com>,
	<nicolas.chautru@intel.com>, <cristian.dumitrescu@intel.com>,
	<zhoujingbin@huawei.com>, <chenchanghu@huawei.com>,
	<jerry.lilijun@huawei.com>, <haifeng.lin@huawei.com>,
Subject: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
Date: Thu, 14 May 2020 09:27:29 +0800	[thread overview]
Message-ID: <20200514012729.23920-1-guohongzhi1@huawei.com> (raw)

The function of rte_ipv4_cksum for calculating the
checksum of IPv4 header is incorrect.
This function will return checksum value like 0xffff.
This value, however, is considered an illegal checksum on some switches(like Trident3).

RFC 1624 specifies the IPv4 checksum as follows:
Since there is guaranteed to be at least one
   non-zero field in the IP header, and the checksum field in the
   protocol header is the complement of the sum, the checksum field can
   never contain ~(+0), which is -0 (0xFFFF).  It can, however, contain
   ~(-0), which is +0 (0x0000).

 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;

             reply	other threads:[~2020-05-14  1:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  1:27 guohongzhi [this message]
2020-05-14 12:56 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating Morten Brørup
2020-05-14 14:19   ` Olivier Matz
2020-05-15  1:04   ` guohongzhi (A)
2020-05-15 10:03     ` Morten Brørup
2020-05-24 15:22 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating Thomas Monjalon
2020-05-26  9:16 guohongzhi
2020-05-26  9:31 ` Morten Brørup
2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514012729.23920-1-guohongzhi1@huawei.com \
    --to=guohongzhi1@huawei.com \
    --cc=chenchanghu@huawei.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haifeng.lin@huawei.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=jiayu.hu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=zhoujingbin@huawei.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).