DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
@ 2020-05-14  1:27 guohongzhi
  2020-05-14 12:56 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating Morten Brørup
  2020-05-24 15:22 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating Thomas Monjalon
  0 siblings, 2 replies; 10+ messages in thread
From: guohongzhi @ 2020-05-14  1:27 UTC (permalink / raw)
  To: dev
  Cc: olivier.matz, konstantin.ananyev, jiayu.hu, ferruh.yigit,
	nicolas.chautru, cristian.dumitrescu, zhoujingbin, chenchanghu,
	jerry.lilijun, haifeng.lin, guohongzhi1

The function of rte_ipv4_cksum for calculating the
checksum of IPv4 header is incorrect.
This function will return checksum value like 0xffff.
This value, however, is considered an illegal checksum on some switches(like Trident3).

RFC 1624 specifies the IPv4 checksum as follows:
https://tools.ietf.org/rfc/rfc1624
Since there is guaranteed to be at least one
   non-zero field in the IP header, and the checksum field in the
   protocol header is the complement of the sum, the checksum field can
   never contain ~(+0), which is -0 (0xFFFF).  It can, however, contain
   ~(-0), which is +0 (0x0000).

---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**
-- 
2.21.0.windows.1



^ permalink raw reply	[flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
@ 2020-05-26  9:16 guohongzhi
  2020-05-26  9:31 ` Morten Brørup
  0 siblings, 1 reply; 10+ messages in thread
From: guohongzhi @ 2020-05-26  9:16 UTC (permalink / raw)
  To: dev
  Cc: olivier.matz, mb, konstantin.ananyev, jiayu.hu, ferruh.yigit,
	nicolas.chautru, cristian.dumitrescu, zhoujingbin, chenchanghu,
	jerry.lilijun, haifeng.lin, guohongzhi1

0xffff is invalid for IPv4 checksum(RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")

Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Signed-off-by: guohongzhi <guohongzhi1@huawei.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**
-- 
2.21.0.windows.1



^ permalink raw reply	[flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
@ 2020-05-26 10:08 guohongzhi
  2020-06-24 11:53 ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: guohongzhi @ 2020-05-26 10:08 UTC (permalink / raw)
  To: dev
  Cc: stable, olivier.matz, mb, konstantin.ananyev, jiayu.hu,
	ferruh.yigit, nicolas.chautru, cristian.dumitrescu, zhoujingbin,
	chenchanghu, jerry.lilijun, haifeng.lin, guohongzhi1

From: Hongzhi Guo <guohongzhi1@huawei.com>

0xffff is invalid for IPv4 checksum(RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org

Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**
-- 
2.21.0.windows.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-06-24 11:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14  1:27 [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating guohongzhi
2020-05-14 12:56 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating Morten Brørup
2020-05-14 14:19   ` Olivier Matz
2020-05-15  1:04   ` guohongzhi (A)
2020-05-15 10:03     ` Morten Brørup
2020-05-24 15:22 ` [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating Thomas Monjalon
2020-05-26  9:16 guohongzhi
2020-05-26  9:31 ` Morten Brørup
2020-05-26 10:08 guohongzhi
2020-06-24 11:53 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).