From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24D78A00C3; Thu, 14 May 2020 08:36:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2B781D5C6; Thu, 14 May 2020 08:36:37 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 014331D537 for ; Thu, 14 May 2020 08:36:35 +0200 (CEST) IronPort-SDR: zj2EYKUVpzNQQ6oDE/Rn4Qc5dUaDwBhiMVz6bqevJc9aAfFeQQkAfqeJBEnffWNHo+WsOwcCwQ KtNjJ+Ymyp2A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 23:36:34 -0700 IronPort-SDR: swlfR0gc/3wvOcdSH2wTQTw+GNaPWYO/FgNmaryjpbDNtBJj2T5noflPa0+2CJ8atMFvl/k+Pr 1mpRK612KDLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="464408174" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2020 23:36:33 -0700 Date: Thu, 14 May 2020 14:28:21 +0800 From: Ye Xiaolong To: Shougang Wang Cc: dev@dpdk.org, beilei.xing@intel.com Message-ID: <20200514062821.GA102809@intel.com> References: <20200507094401.54928-1-shougangx.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507094401.54928-1-shougangx.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/07, Shougang Wang wrote: >This patch fixes the issue that failed to create an RSS rule with type >L2-payload. > >Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > >Signed-off-by: Shougang Wang >--- > drivers/net/i40e/i40e_flow.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > >diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c >index 7e64ae53a..f5f2f0d5d 100644 >--- a/drivers/net/i40e/i40e_flow.c >+++ b/drivers/net/i40e/i40e_flow.c >@@ -4511,6 +4511,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev, > { pattern_fdir_ipv6_tcp, ETH_RSS_NONFRAG_IPV6_TCP }, > { pattern_fdir_ipv6_udp, ETH_RSS_NONFRAG_IPV6_UDP }, > { pattern_fdir_ipv6_sctp, ETH_RSS_NONFRAG_IPV6_SCTP }, >+ { pattern_ethertype, ETH_RSS_L2_PAYLOAD }, > { pattern_fdir_ipv6_esp, ETH_RSS_ESP }, > { pattern_fdir_ipv6_udp_esp, ETH_RSS_ESP }, > }; >@@ -4544,8 +4545,7 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev, > if (i40e_match_pattern(i40e_rss_pctype_patterns[i].item_array, > items)) { > p_info->types = i40e_rss_pctype_patterns[i].type; >- rte_free(items); >- return 0; >+ break; > } > } > >@@ -4580,11 +4580,9 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev, > } > break; > default: >- rte_flow_error_set(error, EINVAL, >- RTE_FLOW_ERROR_TYPE_ITEM, >- item, >- "Not support range"); >- return -rte_errno; >+ p_info->action_flag = 0; >+ memset(info, 0, sizeof(struct i40e_queue_regions)); >+ return 0; > } > } > >@@ -4640,7 +4638,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > return -rte_errno; > } > >- if (p_info.action_flag) { >+ if (p_info.action_flag && rss->queue_num) { > for (n = 0; n < 64; n++) { > if (rss->types & (hf_bit << n)) { > conf_info->region[0].hw_flowtype[0] = n; >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.