From: <kirankumark@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH v2] test/graph: fix memory leak
Date: Thu, 14 May 2020 14:26:57 +0530 [thread overview]
Message-ID: <20200514085658.12287-1-kirankumark@marvell.com> (raw)
From: Kiran Kumar K <kirankumark@marvell.com>
Fix memory leaks reported by coverity.
Coverity issue: 358439, 358451, 358448.
Fixes: 6b89650418("test/graph: add functional tests")
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
---
V2 changes:
* Added Coverity issue and Fixes info.
app/test/test_graph.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/app/test/test_graph.c b/app/test/test_graph.c
index cf6df0744..ed69eda99 100644
--- a/app/test/test_graph.c
+++ b/app/test/test_graph.c
@@ -12,6 +12,7 @@
#include <rte_graph.h>
#include <rte_graph_worker.h>
#include <rte_mbuf.h>
+#include <rte_random.h>
#include "test.h"
@@ -145,7 +146,7 @@ uint16_t
test_node_worker_source(struct rte_graph *graph, struct rte_node *node,
void **objs, uint16_t nb_objs)
{
- uint32_t obj_node0 = rand() % 100, obj_node1;
+ uint32_t obj_node0 = rte_rand() % 100, obj_node1;
test_main_t *tm = &test_main;
struct rte_mbuf *data;
void **next_stream;
@@ -193,7 +194,7 @@ test_node0_worker(struct rte_graph *graph, struct rte_node *node, void **objs,
test_main_t *tm = &test_main;
if (*(uint32_t *)node->ctx == test_node0.id) {
- uint32_t obj_node0 = rand() % 100, obj_node1;
+ uint32_t obj_node0 = rte_rand() % 100, obj_node1;
struct rte_mbuf *data;
uint8_t second_pass = 0;
uint32_t count = 0;
@@ -496,6 +497,7 @@ test_lookup_functions(void)
printf("Test number of edges for node = %s failed Expected = %d, got %d\n",
tm->test_node[i].node.name,
tm->test_node[i].node.nb_edges, count);
+ free(next_edges);
return -1;
}
@@ -505,6 +507,7 @@ test_lookup_functions(void)
printf("Edge name miss match, expected = %s got = %s\n",
tm->test_node[i].node.next_nodes[j],
next_edges[j]);
+ free(next_edges);
return -1;
}
}
--
2.17.1
next reply other threads:[~2020-05-14 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 8:56 kirankumark [this message]
2020-05-14 11:03 ` David Marchand
2020-05-14 11:20 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
-- strict thread matches above, loose matches on Subject: below --
2020-05-14 3:31 [dpdk-dev] [PATCH] " kirankumark
2020-05-14 9:07 ` [dpdk-dev] [PATCH v2] " kirankumark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514085658.12287-1-kirankumark@marvell.com \
--to=kirankumark@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).