From: Marvin Liu <yong.liu@intel.com>
To: maxime.coquelin@redhat.com, xiaolong.ye@intel.com,
zhihong.wang@intel.com, xiao.w.wang@intel.com
Cc: dev@dpdk.org, Marvin Liu <yong.liu@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect
Date: Fri, 15 May 2020 10:35:07 +0800 [thread overview]
Message-ID: <20200515023507.46543-1-yong.liu@intel.com> (raw)
In-Reply-To: <20200515014056.44949-1-yong.liu@intel.com>
Event notification should be disabled after virtqueue initialization and
enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user
device reconnecting to vhost, virtqueue_disable_intr should be called to
disable event notification.
Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
Cc: stable@dpdk.org
Signed-off-by: Marvin Liu <yong.liu@intel.com>
---
v2: commit log update and cc stable
diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
index 0b4e3bf3e..02c8b9fc5 100644
--- a/drivers/net/virtio/virtqueue.c
+++ b/drivers/net/virtio/virtqueue.c
@@ -174,6 +174,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq)
vring_desc_init_packed(vq, size);
+ virtqueue_disable_intr(vq);
return 0;
}
@@ -210,5 +211,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
vring_desc_init_packed(vq, size);
+ virtqueue_disable_intr(vq);
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2020-05-15 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 1:40 [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect Marvin Liu
2020-05-15 1:53 ` Wang, Xiao W
2020-05-15 2:41 ` Liu, Yong
2020-05-15 2:35 ` Marvin Liu [this message]
2020-05-15 2:46 ` [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect Wang, Xiao W
2020-05-15 7:51 ` Maxime Coquelin
2020-05-15 8:37 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515023507.46543-1-yong.liu@intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).