DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] Test/crypto: check valid test_stats before running test
@ 2020-05-15  7:32 Apeksha Gupta
  2020-05-15  7:42 ` Ruifeng Wang
  2020-05-15  7:56 ` [dpdk-dev] [PATCH v3] " Apeksha Gupta
  0 siblings, 2 replies; 8+ messages in thread
From: Apeksha Gupta @ 2020-05-15  7:32 UTC (permalink / raw)
  To: dev
  Cc: Ruifeng.Wang, declan.doherty, asomalap, anoobj, roy.fan.zhang,
	fiona.trahe, rnagadheeraj, adwivedi, jianjay.zhou,
	pablo.de.lara.guarch, adamx.dybkowski, akhil.goyal,
	Apeksha Gupta

Test_stats is an optional cryptodev op and if it is not defined by the
PMD, it should not run the test cases for it.

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
 app/test/test_cryptodev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c624018ee..1ad650675 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -8801,6 +8801,10 @@ test_stats(void)
 	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
 		return -ENOTSUP;
 
+	dev = &rte_cryptodevs[ts_params->valid_devs[0]];
+	if (dev->dev_ops->stats_get == 0)
+		return -ENOTSUP;
+
 	/* Verify the capabilities */
 	struct rte_cryptodev_sym_capability_idx cap_idx;
 	cap_idx.type = RTE_CRYPTO_SYM_XFORM_AUTH;
@@ -8820,7 +8824,6 @@ test_stats(void)
 		"rte_cryptodev_stats_get invalid dev failed");
 	TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) != 0),
 		"rte_cryptodev_stats_get invalid Param failed");
-	dev = &rte_cryptodevs[ts_params->valid_devs[0]];
 	temp_pfn = dev->dev_ops->stats_get;
 	dev->dev_ops->stats_get = (cryptodev_stats_get_t)0;
 	TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-05-17 14:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15  7:32 [dpdk-dev] [PATCH v2] Test/crypto: check valid test_stats before running test Apeksha Gupta
2020-05-15  7:42 ` Ruifeng Wang
2020-05-15  7:56 ` [dpdk-dev] [PATCH v3] " Apeksha Gupta
2020-05-15  8:03   ` Ruifeng Wang
2020-05-15 10:00   ` Ananyev, Konstantin
2020-05-15 17:45     ` Akhil Goyal
2020-05-16  1:55   ` [dpdk-dev] [PATCH v4] " Apeksha Gupta
2020-05-17 14:09     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git