From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1702EA00C3; Fri, 15 May 2020 15:44:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 811B81DAF9; Fri, 15 May 2020 15:44:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 351891DAF8 for ; Fri, 15 May 2020 15:44:44 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04FDe57x002961; Fri, 15 May 2020 06:44:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=7Hr4W/yx6ZH5+6924TiyyygwspjzAWxZrdUI8Ryu9pk=; b=qwK5T2FRXfw4vf//Ubd+/3QqPJC2y6wIUjCmIu+biwQE0HYKx2SIGpWFB25YAIn1s7oa gvjxw+sROjQxmgqS8p55w7XMM5QX/bPDJRsCRNPpGAb5dnfwuia2z4eYWep33bGINz+X Si3BwLWVm3C94k3Hv5wRT0DgJPgc1ERceZ3qE+hfBoIOYBYscgUKzMz8ZGA54hSiFcaM QvUKphT/PKExUg0yx3iRBsP9qJ+yrpWePaRU2x0JfMX3uxnYNZb/r7+6PEOpMlJ50OyG WLG1dBdHMJfe5MEK/VMOvVmKYroeBBwW59IkPwQH+S8ViLrQy73XbpD5ufY4SPP0pBDT sg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 3100xk83cg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 15 May 2020 06:44:42 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 May 2020 06:44:38 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 May 2020 06:44:38 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.56) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 15 May 2020 06:44:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNZPSzQxUy3uAa+NV2CHtVRGu4PHmUNvBdQ36PmE8FRqHUQIor4Fot1KCghUfbxeC9KGu6GMrHchV+zmkWQvjlnFQuQnEWyCT9ODsf1Tkg5Er1JCasdzt3p8v+wV/MoqA64NsleobxVt6jGIbvZjnJtvNrfJWffa3Gu4LLkMER0tj0r78y+Rrfj2OopoPbRgMI9hBIhsGmyBg3yMwAiRq61KAPVNlbmrRZdJYuUGcSxxFLOYAqa82935bwPVg5D84k9+C3yqL/SCFudaQtzEhEBuEzwF6SC2gow5xd2KD1HyG+2mhOqHswU030wn5UuUNN/VKgq2diBi+DadG8URIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Hr4W/yx6ZH5+6924TiyyygwspjzAWxZrdUI8Ryu9pk=; b=Zf7uJqXwojIYQedCsDEKrBaW0ihRkhI91r04HwWWPxtLM6AOYWDooIMckr3qV7E9qwgsrtZ4IzXeu0IdjmCsJ5CWGqmIEtonn2mcKKSkLisYSiI4ZZZmugoKJU0blBwNJJj6uEHd5zyvcWq/G/Ra+jZ+gZTyLEcesJ1oTjrrVd2pIscXskQYveBqDLjRHUvBR3blN9cFIaoC9Vde6+2c4o9B/8IuIPEl6RLQ2GDCgTu5NAWV4v+Umaa2i+aMf+YPrIb8upk4gIkhzP3GnjZyzSOJoT+qNmMtQgo5PeXDqcATZfu/oQ/EpQp06KNpAadDDTxp6RKr73NZKazq0rc0wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Hr4W/yx6ZH5+6924TiyyygwspjzAWxZrdUI8Ryu9pk=; b=FRd5EfdfiqVGxwmIU69RPdlqcipv20x9SPKtEyLH3gu2D6KMMYBPqUMsT4BSvC/63PtImLZCz2CZ0vq6+KzR4+5oFtPtRsPE8XgNw4Ep8pn1l/7BIPN/dcMeuEIVq6kzDkoq7Xccy/Rk6GQki/JzjLWrRB8xRVS1WTXlVRYXoEI= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; Received: from BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) by BYAPR18MB2631.namprd18.prod.outlook.com (2603:10b6:a03:139::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.35; Fri, 15 May 2020 13:44:37 +0000 Received: from BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58]) by BYAPR18MB2917.namprd18.prod.outlook.com ([fe80::a1ec:e959:77df:cd58%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 13:44:36 +0000 Date: Fri, 15 May 2020 19:14:20 +0530 From: Nithin Dabilpuram To: Thomas Monjalon CC: Olivier Matz , Jerin Jacob , Nithin Dabilpuram , "Ferruh Yigit" , Andrew Rybchenko , Ori Kam , Cristian Dumitrescu , Anatoly Burakov , John McNamara , Marko Kovacevic , dpdk-dev , Jerin Jacob , Krzysztof Kanas Message-ID: <20200515134420.GA9696@outlook.office365.com> References: <20200417072254.11455-1-nithind1988@gmail.com> <20200514202931.GF1739@platinum> <20200515100845.GA19989@outlook.office365.com> <2214992.9fHWaBTJ5E@thomas> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2214992.9fHWaBTJ5E@thomas> User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::31) To BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Fri, 15 May 2020 13:44:32 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a151a3d3-e4ed-4626-0603-08d7f8d61b95 X-MS-TrafficTypeDiagnostic: BYAPR18MB2631: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TA3A0aOs+QFsDNMyL0etfcCJV4uo4VQpxzaiBS1mxlP7ammCdECth4XQRkhLa1lTy2yuE1qdIFbGYrgxdO2JMlWSf0M2YcTKfAU/K4dXcksOf8aiJi7TiScEvtdJMVWRzmR9CvUBbEuUNFiQwSp5eHDcNhW1Pw4Sjrmrzo229RWp9/FBqWe3bN5L8N0yx1iqE8IOY0aQ4k3CYmDqHStUgz4VTgqUe1YjmRCzkLZAWtFNCTKAhvbkjV0PEgEID24Wnr9DynFmYcmGc8pr92ZsriBoFABRk0uXb2ibLKCgLGIF+Rasyl6LkksGnH27VKItQfrRsOolQ9MLk4xcbw/rsnz+S5h8qyuPgvZ6zRRNfw/CKHl2TPzsOGVrIgvMJd+vntvz1X9aSW1Ujd3Nhm7J3IauLBpvHvgUcpXEhf3drVQjmD57dwvLrxx+9A7tbd5H X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2917.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(2906002)(4326008)(956004)(8676002)(9686003)(107886003)(5660300002)(6666004)(8936002)(7416002)(33656002)(55016002)(6916009)(54906003)(6506007)(1076003)(478600001)(86362001)(66476007)(66556008)(316002)(7696005)(66946007)(16526019)(55236004)(26005)(52116002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ClYA6lXgBEEoUJfZXmB2KqBENyo+dflKtJqnLZTQhF/h95go7bsf+tlm2ejFCJUGoAK0Y9PnmucqL4yfXNw1MfpRelLA0RcyYUBpcyJX9PPuoBLAqeYlv/49TpIeMnBpvdARFh+lM7NlGmkKoDjd9XEjOZnIpByaTl2b7cTEsRknjBHbgXiDHIgGd73VvtwT56Dy8xuzZi3sas19bH17bClXeeObREUgF0ZgVtNkbNNJHqODcuTbdj4IX8za/O2SUxZ2iM3c1VBK+b8FlANTRe1c+SXnO1FS9lwRYIR/sq0GXyj0+2zZodxV7luHZ4+Y4kk36mEUl5cJYAK2wiE8q2+pvUfWSgvu37njkovt6QDRm88E/nUNkCFFG5wXmbwG7MxAMhjoOKgHE1cqukBAUk62eLy0p7D+/y3ICVUuyT9QayCx5WdvkL6KeeAD29tLaezQXWLTDmxbWRL+kb0kbqYCE5qqophtU/KZgkBpSmI= X-MS-Exchange-CrossTenant-Network-Message-Id: a151a3d3-e4ed-4626-0603-08d7f8d61b95 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 13:44:36.7874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TSa8S0dcxmqVvCCUduU2z7w1aYiue5kUifFOo20YULZp6yqqnixcIh2+X5qaYZUDHKV7TjXgN7ZPi0zPNdJbew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2631 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-15_05:2020-05-15, 2020-05-15 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > 15/05/2020 12:08, Nithin Dabilpuram: > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > I don't see any better approach than having a mbuf flag. However, I'm > > > still not fully convinced that a dynamic flag won't do the job. Taking > > > 3 additional flags (among 18 remaing) for this feature also means that > > > we have 3 flags less for dynamic flags for all applications, even for > > > applications that will not use this feature. > > > > > > Would it be a problem to use a dynamic flag in this case? > > Since packet marking feature itself is already part of spec, > > if we move the flags to PMD specific dynamic flag, then it creates a confusion. > > > > It is not the case of a custom feature supported by a specific PMD. > > I believe when other PMD's implement packet marking, the same flags will > > suffice. > > A dynamic flag is not necessarily PMD-specific. > It is just avoiding consuming bits if the feature is not used by the application. > We must move more existing flags and fields to be dynamic. > > In general, all new flags and fields in mbuf should be dynamic. > And a work must be done to move existing stuff to free more space > for more dynamic features. My bad, I thought dynamic flags can only be used for PMD specific thing. There is however a cost of using dynamic flag which I think should be avoided for DPDK spec defined offloads, though it's fine for PMD specific things. Dynamic offload flags causes application and PMD to use non constant offset or shift which are looked up at init, instead of having a constant shift or offset. This indirection costs some cycles due to extra loads in fast path. > >