From: Apeksha Gupta <apeksha.gupta@nxp.com>
To: dev@dpdk.org
Cc: Ruifeng.Wang@arm.com, declan.doherty@intel.com, asomalap@amd.com,
anoobj@marvell.com, roy.fan.zhang@intel.com,
fiona.trahe@intel.com, rnagadheeraj@marvell.com,
adwivedi@marvell.com, jianjay.zhou@huawei.com,
pablo.de.lara.guarch@intel.com, adamx.dybkowski@intel.com,
akhil.goyal@nxp.com, Apeksha Gupta <apeksha.gupta@nxp.com>
Subject: [dpdk-dev] [PATCH v4] Test/crypto: check valid test_stats before running test
Date: Sat, 16 May 2020 07:25:14 +0530 [thread overview]
Message-ID: <20200516015514.8773-1-apeksha.gupta@nxp.com> (raw)
In-Reply-To: <20200515075606.25709-1-apeksha.gupta@nxp.com>
Test_stats is an optional cryptodev op and if it is not defined by the
PMD, it should not run the test cases for it.
Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
app/test/test_cryptodev.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c624018ee..83fee232d 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -8795,8 +8795,6 @@ test_stats(void)
{
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct rte_cryptodev_stats stats;
- struct rte_cryptodev *dev;
- cryptodev_stats_get_t temp_pfn;
if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
return -ENOTSUP;
@@ -8813,6 +8811,9 @@ test_stats(void)
if (rte_cryptodev_sym_capability_get(ts_params->valid_devs[0],
&cap_idx) == NULL)
return -ENOTSUP;
+ if (rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
+ == -ENOTSUP)
+ return -ENOTSUP;
rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0] + 600,
@@ -8820,13 +8821,6 @@ test_stats(void)
"rte_cryptodev_stats_get invalid dev failed");
TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) != 0),
"rte_cryptodev_stats_get invalid Param failed");
- dev = &rte_cryptodevs[ts_params->valid_devs[0]];
- temp_pfn = dev->dev_ops->stats_get;
- dev->dev_ops->stats_get = (cryptodev_stats_get_t)0;
- TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats)
- == -ENOTSUP),
- "rte_cryptodev_stats_get invalid Param failed");
- dev->dev_ops->stats_get = temp_pfn;
/* Test expected values */
ut_setup();
--
2.17.1
next prev parent reply other threads:[~2020-05-16 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 7:32 [dpdk-dev] [PATCH v2] " Apeksha Gupta
2020-05-15 7:42 ` Ruifeng Wang
2020-05-15 7:56 ` [dpdk-dev] [PATCH v3] " Apeksha Gupta
2020-05-15 8:03 ` Ruifeng Wang
2020-05-15 10:00 ` Ananyev, Konstantin
2020-05-15 17:45 ` Akhil Goyal
2020-05-16 1:55 ` Apeksha Gupta [this message]
2020-05-17 14:09 ` [dpdk-dev] [PATCH v4] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516015514.8773-1-apeksha.gupta@nxp.com \
--to=apeksha.gupta@nxp.com \
--cc=Ruifeng.Wang@arm.com \
--cc=adamx.dybkowski@intel.com \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).