DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: "Yan, Xiaoping (NSB - CN/Hangzhou)" <xiaoping.yan@nokia-sbell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] incorrect vlan_tci in rte mbuf
Date: Mon, 18 May 2020 09:24:05 +0200
Message-ID: <20200518072405.GG1739@platinum> (raw)
In-Reply-To: <301f18faf1184d7fb3b3958f1dbb1675@nokia-sbell.com>

Hi,

On Fri, May 15, 2020 at 11:12:27AM +0000, Yan, Xiaoping (NSB - CN/Hangzhou) wrote:
> Hi,
> 
> I'm using i40e vf, dpdk 18.11, x86_64 CPU (rx function in use is i40e_recv_scattered_pkts_vec_avx2)
> When enable hw vlan strip:
> 
>   *   If packet fit in one mbuf segment, the vlan_tci field is correct
>   *   If packets are stored in several mbuf segment, the vlan_tci of last segment is correct, vlan_tci of other segments are invalid
> 
> It seems i40e_recv_scattered_pkts has correctly set the vlan_tci, by calling
> i40e_rxd_to_vlan_tci(first_seg, &rxd);
> 
> Is this a bug in i40e_recv_scattered_pkts_vec_avx2?
> (I didn't find setting vlan_tci for first segment, but it's a bit difficult for me to understand codes in i40e_recv_scattered_pkts_vec_avx2, so I'm not quite sure)
> I checked the latest dpdk version 20.02 http://lxr.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_avx2.c#L791
> But seems no change for this.
> 
> Any comment please?
> [...]

I don't know about the i40e driver, but I can confirm that the vlan tci
flag should be in the first segment, and not in the next ones.

I suggest to CC i40e driver maintainers.

Regards,
Olivier

  reply	other threads:[~2020-05-18  7:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 11:12 Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-18  7:24 ` Olivier Matz [this message]
2020-05-18  8:31   ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-19  7:00     ` Jeff Guo
2020-05-19  8:31       ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-19 12:27         ` Jeff Guo
2020-05-19 12:41         ` Zhang, Qi Z
2020-05-20  7:42           ` Yan, Xiaoping (NSB - CN/Hangzhou)
2020-05-20  7:48             ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200518072405.GG1739@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=xiaoping.yan@nokia-sbell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git