From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F15E4A0093; Mon, 18 May 2020 09:24:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC5D91D515; Mon, 18 May 2020 09:24:08 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 40C8A1D425 for ; Mon, 18 May 2020 09:24:07 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id j5so10532278wrq.2 for ; Mon, 18 May 2020 00:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=53dLqd+dZvSemJaOczCAInTLqo7F/ZViQCw8pwe7ZZU=; b=j5wWlsg4reJRFJbisRflpTgprAood4RZ+26hRPR14nofwOsH/c4POCyL78NWlaaJKl TqixMHwhcvR76JCJGKUoFhZynS7g92WkoPqEWQAVjrdsbF/m5hznivtXDy6LVs1V7aPO /91iOKeAOdMZKlwXDpl0vN2ncflubDW7y3rVhepZFR/4FaWSKXLpVlAXf1xXhKVh3SOZ NtX4RGuDVM8TcML/QjvBieis6PdvxbOzd1AuF7M5gsuaPCtZeaxwHsRzNF3h50YMao+/ N8oVKipkBrR1t+36KMeNqny+j3WAwHqJB4D7YAEVvPxXnIAeQWl32WiC/KXD1zaXtkHO DlDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=53dLqd+dZvSemJaOczCAInTLqo7F/ZViQCw8pwe7ZZU=; b=FOXusZ5J4zijamIkvZMzKtyVtqjx2K6lY+SfboF6BCiX2YuUXB4Yzl1Dr/lBE9lHzw T57ZEIdB5urF3rd77CntRMY8+/cbY4awFDAlpHnW1DsRqx0/Zz8DKX644Y0GfP6+AMCR J4Zb3MIUqDuvNYBX6tyPTRyPZ3gOdIznRFUp0kIXmHfhOmY+XPZsYxaJfVQSB4Q4avXs MtUKswOiza3yeesFJRQEKMMvLNRh+gtsPIYe/7pJgbtP77YGh6XuUvXMnjUtKuGwoNO8 O8NSLpDmp5RJlpuWozGhKVo/sMzsfDTrETm1MztycBlLoctBeH23BdMYI8ajfh3td5bP DTvA== X-Gm-Message-State: AOAM533GUZaE5JBrEhhb8xKt/pTkd0X6rEVTtB18482gjQMe2Rxg7Sj9 cUXp/GWnjav764MVQxP4X0yd4c0DFQ0= X-Google-Smtp-Source: ABdhPJyGoK2k7RkZ2pAh9rbG/uqLaM29ddnD+9hArkbynYJrV2GqfED7ntfDdLfTZQah0FqvnG7PIQ== X-Received: by 2002:a5d:4d89:: with SMTP id b9mr18312790wru.210.1589786647010; Mon, 18 May 2020 00:24:07 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id h133sm15975808wmf.25.2020.05.18.00.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 00:24:06 -0700 (PDT) Date: Mon, 18 May 2020 09:24:05 +0200 From: Olivier Matz To: "Yan, Xiaoping (NSB - CN/Hangzhou)" Cc: "dev@dpdk.org" Message-ID: <20200518072405.GG1739@platinum> References: <301f18faf1184d7fb3b3958f1dbb1675@nokia-sbell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <301f18faf1184d7fb3b3958f1dbb1675@nokia-sbell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] incorrect vlan_tci in rte mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Fri, May 15, 2020 at 11:12:27AM +0000, Yan, Xiaoping (NSB - CN/Hangzhou) wrote: > Hi, > > I'm using i40e vf, dpdk 18.11, x86_64 CPU (rx function in use is i40e_recv_scattered_pkts_vec_avx2) > When enable hw vlan strip: > > * If packet fit in one mbuf segment, the vlan_tci field is correct > * If packets are stored in several mbuf segment, the vlan_tci of last segment is correct, vlan_tci of other segments are invalid > > It seems i40e_recv_scattered_pkts has correctly set the vlan_tci, by calling > i40e_rxd_to_vlan_tci(first_seg, &rxd); > > Is this a bug in i40e_recv_scattered_pkts_vec_avx2? > (I didn't find setting vlan_tci for first segment, but it's a bit difficult for me to understand codes in i40e_recv_scattered_pkts_vec_avx2, so I'm not quite sure) > I checked the latest dpdk version 20.02 http://lxr.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_avx2.c#L791 > But seems no change for this. > > Any comment please? > [...] I don't know about the i40e driver, but I can confirm that the vlan tci flag should be in the first segment, and not in the next ones. I suggest to CC i40e driver maintainers. Regards, Olivier