From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 357D2A0093; Tue, 19 May 2020 00:08:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C41901D454; Tue, 19 May 2020 00:08:36 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by dpdk.org (Postfix) with ESMTP id 9EDDB1D177 for ; Tue, 19 May 2020 00:08:35 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id D520620B717B; Mon, 18 May 2020 15:08:34 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D520620B717B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1589839714; bh=a9FOXW/CLeYVSSZWjEkK+EHTDf4BxORWDRyyxuccX74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WFU9DSKY2Z91r4WwiMA9iJPC8AiC6kwtip7a3zD9Bz+mB5wuxNv5HCFYbAAG/OPYU YL7l7nICLmFS0AiMw1lLfmCJyXYFtqYOP8iwAsDshwM0af6JBt7SH1OHZfIqdaYhOd Cw/VJYEOtroTOxVfh4B5rEFZEdNm3USveZlRSChQ= Date: Mon, 18 May 2020 15:08:34 -0700 From: Narcisa Ana Maria Vasile To: Pallavi Kadam Cc: dev@dpdk.org, thomas@monjalon.net, Harini.Ramakrishnan@microsoft.com, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, ocardona@microsoft.com Message-ID: <20200518220834.GA44390@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20200513225341.7620-1-pallavi.kadam@intel.com> <20200514203945.1484-1-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514203945.1484-1-pallavi.kadam@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 01:39:45PM -0700, Pallavi Kadam wrote: > This patch fixes bunch of warnings when compiling on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-const-variable] in getopt.c and > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > v2 changes: > Excluded dirent.h file on Windows temporarily. > (This file will stay on Windows for later use) > > Signed-off-by: Ranjit Menon > Signed-off-by: Pallavi Kadam > Tested-by: Pallavi Kadam > --- > Glad to see those warnings gone! Tested with clang, FYI it looks like there's only one warning left. We use "attr" in the pthread_create call, but in the pthread_create macro definition we ignore the attribute parameter. [13/30] Compiling C object lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_thread.c.obj. ../lib/librte_eal/common/eal_common_thread.c:180:25: warning: unused parameter 'attr' [-Wunused-parameter] const pthread_attr_t *attr, ^ 1 warning generated. Otherwise, Acked-by: Narcisa Vasile