DPDK patches and discussions
 help / color / mirror / Atom feed
From: Cody Harris <codh@amazon.com>
To: <dev@dpdk.org>
Cc: Cody Harris <codh@amazon.com>
Subject: [dpdk-dev] [PATCH] include dropped packets from QPRDC in ixbe imissed
Date: Tue, 19 May 2020 04:58:50 +0000	[thread overview]
Message-ID: <20200519045849.19465-1-codh@amazon.com> (raw)

The ixgbe imissed statstic originally only contained dropped packets counted by
the RXMPC registers. This change includes additional types of packet drops
counted by the QPRDC registers.

Intel support confimed that the packet drops counted by the QPRDC registers do
not double-count drops counted by RXMPC registers:

"RXMPC counts packets that are dropped because there is no room in the internal
packet buffer.  QPRDC counts packets that are dropped because they can't be
transferred to system memory. These packets have been stored in the internal
packet buffer, so there should be no overlap with RXMPC."
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index a4e5c539d..7284ca28e 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3366,7 +3366,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	}
 
 	/* Rx Errors */
-	stats->imissed  = total_missed_rx;
+	stats->imissed  = total_missed_rx + total_qprdc;
 	stats->ierrors  = hw_stats->crcerrs +
 			  hw_stats->mspdc +
 			  hw_stats->rlec +
-- 
2.24.1.AMZN


                 reply	other threads:[~2020-05-19  4:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519045849.19465-1-codh@amazon.com \
    --to=codh@amazon.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).