From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A483A0093; Tue, 19 May 2020 06:59:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDDD81D404; Tue, 19 May 2020 06:59:11 +0200 (CEST) Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by dpdk.org (Postfix) with ESMTP id E08F41D17B for ; Tue, 19 May 2020 06:59:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1589864351; x=1621400351; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JIrce+FwrOoiCaRnscnc5w+RwTpoO7K/Wd6EII9tEzk=; b=LAz4xKi7hvfoyPQFrSMl08i+kF/QNt1clMlbp5m/JGZ+1Xo2gUZcZWaD MGKfCoLr5YMF3X8z698/VgbEx3t9MXs4s1hUnK8CwewYLw1njqT+KYUeS 0hO4c584js/pm/47YFaT51n0a59NT1u1yyxgL4yielat0/Ld14XyQcLwi w=; IronPort-SDR: V/HPC96QTWONKvblYLrwsalXJ3nRDwcs30/g0oUPMZONxd74ozpsfemVbGkfqd5keJZSGBxULh 5FlysR9Cyjuw== X-IronPort-AV: E=Sophos;i="5.73,409,1583193600"; d="scan'208";a="44288898" Received: from sea32-co-svc-lb4-vlan2.sea.corp.amazon.com (HELO email-inbound-relay-1e-c7c08562.us-east-1.amazon.com) ([10.47.23.34]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 19 May 2020 04:59:08 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-c7c08562.us-east-1.amazon.com (Postfix) with ESMTPS id 0852B240B11 for ; Tue, 19 May 2020 04:59:06 +0000 (UTC) Received: from EX13D21UWA004.ant.amazon.com (10.43.160.252) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 04:59:06 +0000 Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D21UWA004.ant.amazon.com (10.43.160.252) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 04:59:06 +0000 Received: from dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (172.19.57.163) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 19 May 2020 04:58:58 +0000 Received: by dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (Postfix, from userid 9465375) id C45B34153B; Tue, 19 May 2020 04:58:58 +0000 (UTC) From: Cody Harris To: CC: Cody Harris Date: Tue, 19 May 2020 04:58:50 +0000 Message-ID: <20200519045849.19465-1-codh@amazon.com> X-Mailer: git-send-email 2.24.1.AMZN MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Subject: [dpdk-dev] [PATCH] include dropped packets from QPRDC in ixbe imissed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe imissed statstic originally only contained dropped packets counted by the RXMPC registers. This change includes additional types of packet drops counted by the QPRDC registers. Intel support confimed that the packet drops counted by the QPRDC registers do not double-count drops counted by RXMPC registers: "RXMPC counts packets that are dropped because there is no room in the internal packet buffer. QPRDC counts packets that are dropped because they can't be transferred to system memory. These packets have been stored in the internal packet buffer, so there should be no overlap with RXMPC." --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a4e5c539d..7284ca28e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3366,7 +3366,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) } /* Rx Errors */ - stats->imissed = total_missed_rx; + stats->imissed = total_missed_rx + total_qprdc; stats->ierrors = hw_stats->crcerrs + hw_stats->mspdc + hw_stats->rlec + -- 2.24.1.AMZN