From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3719CA0093; Tue, 19 May 2020 07:03:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDE461D421; Tue, 19 May 2020 07:03:01 +0200 (CEST) Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by dpdk.org (Postfix) with ESMTP id 8F4B21D17B for ; Tue, 19 May 2020 07:03:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1589864581; x=1621400581; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hnSe0FnUh5FZIC1cbenbhlJ9HueSEfYTV2CCMrR30Ug=; b=qwHfr2xhjXVT8mZV+wpp4OCxw5w8c9wvIHcFUpmIhZCFGCFlPHWQSoQ6 5RQeNgh0hnXuzSJ3orKGCTYn/mAjNRKZmv1YdcWMDEeCHKolFweJTKyJA FTRJEH1gHUmW4HrGgjM014+Ve4rfX75g7UYOd+9ok2gidYzIF7rv50Gmg 0=; IronPort-SDR: Wi3fsb980uJI67xSfqvzPFYXNjUEg5SYFCdaH1ZdBh5A+DmHBEkHWoNd+/loZPx7e2zLkwZ9m9 s9GCPoes269w== X-IronPort-AV: E=Sophos;i="5.73,409,1583193600"; d="scan'208";a="45716659" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-807d4a99.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 19 May 2020 05:02:59 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-807d4a99.us-east-1.amazon.com (Postfix) with ESMTPS id E4766A2593 for ; Tue, 19 May 2020 05:02:57 +0000 (UTC) Received: from EX13D21UWA001.ant.amazon.com (10.43.160.154) by EX13MTAUWA001.ant.amazon.com (10.43.160.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 05:02:57 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D21UWA001.ant.amazon.com (10.43.160.154) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 05:02:56 +0000 Received: from dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (172.19.57.163) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 19 May 2020 05:02:57 +0000 Received: by dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (Postfix, from userid 9465375) id 0D84442297; Tue, 19 May 2020 05:02:57 +0000 (UTC) From: Cody Harris To: CC: Cody Harris Date: Tue, 19 May 2020 05:02:55 +0000 Message-ID: <20200519050255.20848-1-codh@amazon.com> X-Mailer: git-send-email 2.24.1.AMZN In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Subject: [dpdk-dev] [PATCH v2] include dropped packets from QPRDC in ixbe imissed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe imissed statstic originally only contained dropped packets counted by the RXMPC registers. This change includes additional types of packet drops counted by the QPRDC registers. Intel support confimed that the packet drops counted by the QPRDC registers do not double-count drops counted by RXMPC registers: "RXMPC counts packets that are dropped because there is no room in the internal packet buffer. QPRDC counts packets that are dropped because they can't be transferred to system memory. These packets have been stored in the internal packet buffer, so there should be no overlap with RXMPC." Signed-off-by: Cody Harris --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a4e5c539d..7284ca28e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3366,7 +3366,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) } /* Rx Errors */ - stats->imissed = total_missed_rx; + stats->imissed = total_missed_rx + total_qprdc; stats->ierrors = hw_stats->crcerrs + hw_stats->mspdc + hw_stats->rlec + -- 2.24.1.AMZN