From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 312A1A0093; Tue, 19 May 2020 08:37:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 636EF1D37F; Tue, 19 May 2020 08:37:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 127091BFA2; Tue, 19 May 2020 08:36:58 +0200 (CEST) IronPort-SDR: aQd83nLzJYp3m0VnJBN6LDiiHdarOOZMGQu+Gzu+X8iTll0WHXa+awHCtUJWY6uchStmrSXw3E 2zUnL1am9weQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 23:36:58 -0700 IronPort-SDR: 5JeZ5lwX1hN7YkLkhUJ10Up3HEaRiT3sZVaeDBPsdU+jcyH9xtI6Ir3ngpBVtjoCnMxMGHvtt3 iS5UbLefzTMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="254647095" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga008.fm.intel.com with ESMTP; 18 May 2020 23:36:56 -0700 Date: Tue, 19 May 2020 14:28:25 +0800 From: Ye Xiaolong To: Xuan Ding Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20200519062825.GD38911@intel.com> References: <20200512095155.98708-1-xuan.ding@intel.com> <20200513021410.98031-1-xuan.ding@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513021410.98031-1-xuan.ding@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/13, Xuan Ding wrote: >This patch fixes the situation where vhost-user cannot start as server with >dequeue_zero_copy enabled. > >Using flag instead of vsocket->is_server to determine whether vhost-user is >in client mode. Because vsocket->is_server is not ready at this time. > >Cc: stable@dpdk.org Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") And no need to cc stable since above commit is introduced in this release. > >Signed-off-by: Xuan Ding >--- > >v2: >* Added the description of problem solved in commit log. >--- > lib/librte_vhost/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c >index bb8d0d780..0a66ef976 100644 >--- a/lib/librte_vhost/socket.c >+++ b/lib/librte_vhost/socket.c >@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) > ret = -1; > goto out_mutex; > } >- if (!vsocket->is_server) { >+ if ((flags & RTE_VHOST_USER_CLIENT) != 0) { > VHOST_LOG_CONFIG(ERR, > "error: zero copy is incompatible with vhost client mode\n"); > ret = -1; >-- >2.17.1 > Reviewed-by: Xiaolong Ye