From: Stephen Hemminger <stephen@networkplumber.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/metrics: fix to reset the init flag
Date: Tue, 19 May 2020 08:23:35 -0700 [thread overview]
Message-ID: <20200519082335.75812c73@hermes.lan> (raw)
In-Reply-To: <20200519105258.31426-1-hemant.agrawal@nxp.com>
On Tue, 19 May 2020 16:22:57 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
> index e07670219f..dba6409c27 100644
> --- a/lib/librte_metrics/rte_metrics.c
> +++ b/lib/librte_metrics/rte_metrics.c
> @@ -85,6 +85,7 @@ rte_metrics_deinit(void)
> {
> struct rte_metrics_data_s *stats;
> const struct rte_memzone *memzone;
> + int ret = 0;
>
Why do gratuitous initialization? It blocks compiler from finding buggy
code.
prev parent reply other threads:[~2020-05-19 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 10:36 [dpdk-dev] [PATCH " Hemant Agrawal
2020-05-13 10:36 ` [dpdk-dev] [PATCH 2/2] test: support cleanup in bitrate and latency test Hemant Agrawal
2020-05-19 9:31 ` [dpdk-dev] [PATCH 1/2] lib/metrics: fix to reset the init flag David Marchand
2020-05-19 9:50 ` Hemant Agrawal
2020-05-19 10:52 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2020-05-19 10:52 ` [dpdk-dev] [PATCH v2 2/2] test: support cleanup in bitrate and latency test Hemant Agrawal
2020-05-19 15:24 ` Stephen Hemminger
2020-05-19 12:12 ` [dpdk-dev] [PATCH v2 1/2] lib/metrics: fix to reset the init flag David Marchand
2020-05-19 15:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519082335.75812c73@hermes.lan \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).