From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE9ECA0093; Tue, 19 May 2020 17:23:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25F7F1D5F4; Tue, 19 May 2020 17:23:46 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 92E941C1E9 for ; Tue, 19 May 2020 17:23:44 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id k19so5923pll.9 for ; Tue, 19 May 2020 08:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g5p2toKN2Nhz6TerDZ18rDMhd/yom42Wrcb+m0y5yj4=; b=mawjSZnN6/yMvhEfas6WvJwtxmF5uaEVfhnBYa3H3GMHUVsYJty28/RqyS4yHzXPMM HUNm/XdG+PSG0TEM084GMWbfzFJCqJfTo46y9T+DwrE7DmeT4U8JK0MTcgFnelCO1UJI yw6+7yUljE6kgg1NToRfoTSZ42PF8VrcR3e1zQeEmv1SKGsC3S8DwZrMSewi2VWSIaLQ QgeodiVcOEXYGbzY1AZY3gEynnLBW+oLtvRmqkdejJP8HJHkBlQCEvO98o/dD4yeEYYH nGjm2DAapUtG99RNf1PS2WXUjoQhBbKg26t81Zuige4Xkw6ky+g/LpADNjuUxYmTpSbd 9p5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g5p2toKN2Nhz6TerDZ18rDMhd/yom42Wrcb+m0y5yj4=; b=TexyVDmeSFN8eU3/ISGlbIvuAGMkrYk80FYg6L5E/9cuRM8b+0jdpuOPuZ1mCvxty0 2VmwwdAl/fpw0KqPf91cAnEgzi1kplKYjUWwBScXkMvUGQ/+mUjgwB17kiHNgXGpCsri ZLI/xl91dSvGrfnDok4a6aCzf/mTn9RpL4QEBp5GfmItWq4C7ICgbbuinwPSXWLWiRnj pWD9ihYHyhTk30vpcIIqW7ij21FF7pDU/QBJ9i65P3ep+6U0bbd4aCwerhiqQ6lMbuEG Kyt4PzSMjUubj+Su7lSF2Zth/kXmT/1hsoAdfz4Qok92s/pedvKeDY01r8J4Qwa6TAQq V69g== X-Gm-Message-State: AOAM532Uw6yUSOaDha5XtBY9s98aLGgVFPPg1c/oVz7F0PTiTszYalV2 2u6BhFyR4D4FyMjBbTmxUv/kXxdqBEppSA== X-Google-Smtp-Source: ABdhPJxsAtfh+37HewHPDFVP/TVwLhi+RzTDFQDLPXfrBiys+5ssf6LA2SCRkUcKmwyTQasUB0T1VQ== X-Received: by 2002:a17:90a:4809:: with SMTP id a9mr80976pjh.196.1589901823727; Tue, 19 May 2020 08:23:43 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v3sm1871591pja.8.2020.05.19.08.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 08:23:43 -0700 (PDT) Date: Tue, 19 May 2020 08:23:35 -0700 From: Stephen Hemminger To: Hemant Agrawal Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: <20200519082335.75812c73@hermes.lan> In-Reply-To: <20200519105258.31426-1-hemant.agrawal@nxp.com> References: <20200513103629.8436-1-hemant.agrawal@nxp.com> <20200519105258.31426-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/metrics: fix to reset the init flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 May 2020 16:22:57 +0530 Hemant Agrawal wrote: > diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c > index e07670219f..dba6409c27 100644 > --- a/lib/librte_metrics/rte_metrics.c > +++ b/lib/librte_metrics/rte_metrics.c > @@ -85,6 +85,7 @@ rte_metrics_deinit(void) > { > struct rte_metrics_data_s *stats; > const struct rte_memzone *memzone; > + int ret = 0; > Why do gratuitous initialization? It blocks compiler from finding buggy code.