From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2171DA0093; Tue, 19 May 2020 17:52:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8E331D404; Tue, 19 May 2020 17:52:34 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 2D0971C1D9 for ; Tue, 19 May 2020 17:52:33 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id b12so31428plz.13 for ; Tue, 19 May 2020 08:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bBEE+C4kg6ClSVdGzzH6jODNcm8SkPGwZdMohYS2udE=; b=OdCaaHIqtRAva8ytNx4JtPbracsYfK93ihdNw8lSWsarLE0sVrfHhcoUB0zEzEXyLp Es3W5FICGGD12GjgJRD6s8Jv6jAPAGnbPb51FGWs8FykEPbCnXZ4tmW404jmfz7tr++t NLb0zw9wJHpzMTuTzKYyrBuQFiijgqCog82jXIc3NNNYLQZibVkxja8pCJB+9bI2upw2 NLR6ZujEvxJ8bwTPAPSS4WsSWbws9tdYhzX9CvSgCMbgMVldBRS36kOTiDokiwSjP2+N UdNHdcWv4ZLU1jFWTAcEI8mnHpsZfTilcpG6wEjJ0Wp/hX5UtBTNT6iECZjqwq9rgzJS euHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bBEE+C4kg6ClSVdGzzH6jODNcm8SkPGwZdMohYS2udE=; b=FjGKfiO4c5/8NsvkqJh62oP1+JV8JGUhTMUMXp777NmHtMMyMg9YJDUyuJAtCm1hNQ ODMFCt9k4yT1Z+kWF/nGRgHQXS2UKBEMHf2aPID7MGeh1f9nMIdwhXsJy5IOcsAw1/Nl 9bWLFKtJ6sOD645CfuWVwicJz70WDfHomF5hDKOKolbX/hZMzPG/CUx2Pup19iIhh+yD zbATsbo2PXuKNP/rDh7A+gpoO3NXNcqRgDYHVzg4+4WwxqCxy6/77u7kgkyzTywdh0Gj Vw80QomtHHhsB//+Dgyv6KI7Z9uvkAb9JiVgjgehLZSGMhxhLoN045R8Ngjm2UZa9Mes Nl1Q== X-Gm-Message-State: AOAM530Fdj+5QgVnM1ipEBEts2Wqpj4DvJpQltgN0ssZkRlaL9LMCTSo yyHWUrR718JJEAqr6Pvui9Zllg== X-Google-Smtp-Source: ABdhPJxrGTUp188wh076jAhe6fAxzXonR2KbxAeF4U+2eF5RPdOoS/JrDKG7cLNCxSzT4+QzBvNaHA== X-Received: by 2002:a17:90a:a608:: with SMTP id c8mr231161pjq.90.1589903552285; Tue, 19 May 2020 08:52:32 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z6sm10365188pgu.85.2020.05.19.08.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 08:52:32 -0700 (PDT) Date: Tue, 19 May 2020 08:52:23 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: olivier.matz@6wind.com, konstantin.ananyev@intel.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, dev@dpdk.org Message-ID: <20200519085223.079bc2ac@hermes.lan> In-Reply-To: <20200519152725.63486-3-mb@smartsharesystems.com> References: <20200513153111.37063-1-mb@smartsharesystems.com> <20200519152725.63486-1-mb@smartsharesystems.com> <20200519152725.63486-3-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] ring: empty optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 May 2020 15:27:25 +0000 Morten Br=C3=B8rup wrote: > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h > index 9078e7c24..f67141482 100644 > --- a/lib/librte_ring/rte_ring.h > +++ b/lib/librte_ring/rte_ring.h > @@ -733,7 +733,9 @@ rte_ring_full(const struct rte_ring *r) > static inline int > rte_ring_empty(const struct rte_ring *r) > { > - return rte_ring_count(r) =3D=3D 0; > + uint32_t prod_tail =3D r->prod.tail; > + uint32_t cons_tail =3D r->cons.tail; > + return cons_tail =3D=3D prod_tail; > } Blank line after declarations? Are the temporary variable even needed?