DPDK patches and discussions
 help / color / mirror / Atom feed
From: talshn@mellanox.com
To: dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
	dmitry.kozliuk@gmail.com, david.marchand@redhat.com,
	grive@u256.net, ranjit.menon@intel.com,
	navasile@linux.microsoft.com, anatoly.burakov@intel.com,
	Tal Shnaiderman <talshn@mellanox.com>
Subject: [dpdk-dev] [PATCH v4 4/8] pci: fix format warning on Windows
Date: Tue, 19 May 2020 17:20:16 +0300	[thread overview]
Message-ID: <20200519142020.15848-5-talshn@mellanox.com> (raw)
In-Reply-To: <20200519142020.15848-1-talshn@mellanox.com>

From: Tal Shnaiderman <talshn@mellanox.com>

the struct rte_pci_addr defines domain as uint32_t variable however
the PCI_PRI_FMT macro used for logging the struct sets the format
of domain to uint16_t.

The mismatch causes the following warning messages
in Windows clang build:

format specifies type 'unsigned short' but the argument
has type 'uint32_t' (aka 'unsigned int') [-Wformat]

Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
 lib/librte_pci/rte_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h
index b721bbf58..d119a9e4a 100644
--- a/lib/librte_pci/rte_pci.h
+++ b/lib/librte_pci/rte_pci.h
@@ -22,7 +22,7 @@ extern "C" {
 #include <inttypes.h>
 /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */
-#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8
+#define PCI_PRI_FMT "%.4" PRIx32 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8
 #define PCI_PRI_STR_SIZE sizeof("XXXXXXXX:XX:XX.X")
 /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */

  parent reply	other threads:[~2020-05-19 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 14:20 [dpdk-dev] [PATCH v4 0/8] Windows bus/pci support talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 1/8] eal: move OS common functions to single file talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 2/8] pci: use OS generic memory mapping functions talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 3/8] pci: build on Windows talshn
2020-05-19 14:20 ` talshn [this message]
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 5/8] drivers: ignore pmdinfogen generation for Windows talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 6/8] drivers: fix incorrect meson import folder " talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 7/8] bus/pci: introduce Windows support with stubs talshn
2020-05-19 14:20 ` [dpdk-dev] [PATCH v4 8/8] bus/pci: support Windows with bifurcated drivers talshn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519142020.15848-5-talshn@mellanox.com \
    --to=talshn@mellanox.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=grive@u256.net \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).