From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD0D1A0093; Tue, 19 May 2020 18:53:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB9521D645; Tue, 19 May 2020 18:53:05 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 6E37D1D633 for ; Tue, 19 May 2020 18:52:56 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id k19so129525pll.9 for ; Tue, 19 May 2020 09:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GcgcNkjgnWjx2qfjFjv58XhbqbFPWASTmQkmA0Wn77A=; b=z9zL+bjYYtXHTI5e0lS9SfX7FN1c7SWbeyCyRhmJKHcn5e45MEZ3ar8WYTRausKJA/ L6qYWJsjhcdFBPY0VwTxCx7SUl2d5ZjL9dj0dZgD3WnFp1giMgXBhvXq2I4YTXc4SbP4 c7wDBwabBj19dGAbBYDnTdhav3u5iNv64Axi5m3urIL7ALtdBrRU7L5i41F0UM/aZwQ1 9cHPh/dzgb6eSFNP4ha047ZHQ3ttu++GYJ2hxujumYNo8KtZOpECAGMFsEcUjrYOrvX3 4iCMnV4PIaWZ3VdvXqCu02yKoJfXTeVBGWx4HJp/r0uFQJxMitc1aYq02EWPSog8tAVw U4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GcgcNkjgnWjx2qfjFjv58XhbqbFPWASTmQkmA0Wn77A=; b=JOspNmSMV+FYni+XjSyZ/ETs3u+nmRvIvmo91U4D7x2rdn6kErTFl0r/qXbRvhkcUy JwQCnH9sLfja0Kj9D8XfHUVuIe9CYtN+fQ/Jez3LWyiKm+lK426L3eypP3mQlpIoG2Ur xeCg/72L4VFvyTBn026Dx9oIBgVJqMCEu6SGJp+3qwDpEbWjQ4odr0t6IpgZ74ElEqgo fairCg5NqmeINEqqEre4c7bOeJYW3mrOwqD4Xhf97PsvEg6ucdbxoRyRkKoJnAlGZvEk qVDIm/OcS+LCbWmkhkjOVVDc6oBh64Pwf9FfRuq4heEujWDVuAkm47JVvYfUbun3WARR 8TJg== X-Gm-Message-State: AOAM533WxUeRJWVKziKG2WHT2nzE25ptDejcg/V7ZydFj19Wh6yAnAxM fY3a9oLFJiyLoTk5MgPf03feVd3s/ybE0w== X-Google-Smtp-Source: ABdhPJwYOs4QuAD/ehY8g+vCey6IN/3YD9KstmCTS4yJD3IrUmbhL75Gqi9GovkwjxYA5+APTlZ9IA== X-Received: by 2002:a17:902:5588:: with SMTP id g8mr375944pli.321.1589907174596; Tue, 19 May 2020 09:52:54 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c12sm107394pjm.46.2020.05.19.09.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 09:52:53 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 19 May 2020 09:52:27 -0700 Message-Id: <20200519165230.23306-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200519165230.23306-1-stephen@networkplumber.org> References: <20200506192730.21613-1-stephen@networkplumber.org> <20200519165230.23306-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 4/7] net/netvsc: fix warning when VF is removed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The code to unset owner of VF device was changing port to invalid value before calling unset. Fixes: 4a9efcddaddd ("net/netvsc: fix VF support with secondary process") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_vf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index b7e3ba46bf63..a745c7c36ea3 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -120,11 +120,11 @@ static void hn_vf_remove(struct hn_data *hv) /* Stop incoming packets from arriving on VF */ hn_nvs_set_datapath(hv, NVS_DATAPATH_SYNTHETIC); - /* Stop transmission over VF */ - hv->vf_port = HN_INVALID_PORT; - /* Give back ownership */ rte_eth_dev_owner_unset(hv->vf_port, hv->owner.id); + + /* Stop transmission over VF */ + hv->vf_port = HN_INVALID_PORT; } } -- 2.26.2