From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93342A0093; Wed, 20 May 2020 09:19:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25E521C19F; Wed, 20 May 2020 09:19:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6B8171C197 for ; Wed, 20 May 2020 09:19:19 +0200 (CEST) IronPort-SDR: vhJZLpGNAn3LddAlh9VfEIou+FjHyCInlFF5ptVfTjqJr1oFcW3q09PusH18QeyprMl/Hz950M CU61A+TowqwA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 00:19:17 -0700 IronPort-SDR: X+ANZRn1RD3gt/zfSIfegQPQ1YBrwtdxJ4FOgNkZ1IOF0ZJzegM97IhviaaUrXg3/i0ACeyDPq F2attBEFNbFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="466284289" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga005.fm.intel.com with ESMTP; 20 May 2020 00:19:15 -0700 Date: Wed, 20 May 2020 15:10:41 +0800 From: Ye Xiaolong To: Leyi Rong Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org Message-ID: <20200520071041.GA99392@intel.com> References: <20200520063950.50315-1-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520063950.50315-1-leyi.rong@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/20, Leyi Rong wrote: >FDIR ID parsing will not be handled correctly after queue reconfigured, >enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it. > >Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value") > >Signed-off-by: Leyi Rong >--- > drivers/net/iavf/iavf_rxtx.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h >index 73968847f..59625a979 100644 >--- a/drivers/net/iavf/iavf_rxtx.h >+++ b/drivers/net/iavf/iavf_rxtx.h >@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on) > { > if (on) { > /* enable flow director processing */ >- if (ad->fdir_ref_cnt++ == 0) >- FDIR_PROC_ENABLE_PER_QUEUE(ad, on); >+ FDIR_PROC_ENABLE_PER_QUEUE(ad, on); >+ ad->fdir_ref_cnt++; > } else { > if (ad->fdir_ref_cnt >= 1) { > ad->fdir_ref_cnt--; >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.