From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC1BA0093; Wed, 20 May 2020 11:34:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77CAA1C436; Wed, 20 May 2020 11:34:52 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 82BB61BFEB for ; Wed, 20 May 2020 11:34:51 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from fady@mellanox.com) with ESMTPS (AES256-SHA encrypted); 20 May 2020 12:34:49 +0300 Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 04K9YnWW012334; Wed, 20 May 2020 12:34:49 +0300 From: Fady Bader To: dev@dpdk.org Cc: thomas@monjalon.net, talshn@mellanox.com, yohadt@mellanox.com, olivier.matz@6wind.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anand.rawat@intel.com, ranjit.menon@intel.com Date: Wed, 20 May 2020 12:34:44 +0300 Message-Id: <20200520093444.14904-1-fady@mellanox.com> X-Mailer: git-send-email 2.16.1.windows.4 Subject: [dpdk-dev] [PATCH] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Exported per_lcore__rte_errno function to compile ring for windows. compilation error logs: librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol per_lcore__rte_errno referenced in function rte_ring_lookup The cause was that per_lcore__rte_errno function wasn't included in the export list. To solve this per_lcore__rte_errno was added to the Windows export list. Signed-off-by: Fady Bader Depends-on: series-9374 ("Windows basic memory management") --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/rte_eal_version.map | 5 ++++- lib/meson.build | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 854b83bcd..cbb6b8cfe 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -1,5 +1,6 @@ EXPORTS __rte_panic + per_lcore__rte_errno rte_calloc rte_calloc_socket rte_eal_get_configuration diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index bdd014638..1a1dedcd9 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -390,4 +390,7 @@ EXPERIMENTAL { rte_trace_point_lookup; rte_trace_regexp; rte_trace_save; -}; + + # added in 20.08 + __emutls_v.per_lcore__rte_errno; +}; \ No newline at end of file diff --git a/lib/meson.build b/lib/meson.build index d190d84ef..5b644f5cd 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -36,7 +36,7 @@ libraries = [ 'flow_classify', 'bpf', 'graph', 'node'] if is_windows - libraries = ['kvargs','eal'] # only supported libraries for windows + libraries = ['kvargs','eal','ring'] # only supported libraries for windows endif default_cflags = machine_args -- 2.16.1.windows.4