Re: [dpdk-dev] [PATCH] ring: build on Windows

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

On Wed, 20 May 2020 12:34:44 +0300
Fady Bader <fady@mellanox.com> wrote:

> Exported per_lcore__rte_errno function to compile ring for windows.
> 
> compilation error logs:
> librte_ring_rte_ring.c.obj : error LNK2019: unresolved
> external symbol per_lcore__rte_errno referenced in
> function rte_ring_lookup
> 
> The cause was that per_lcore__rte_errno function wasn't included
> in the export list.
> To solve this per_lcore__rte_errno was added to the Windows export
> list.
> 
> Signed-off-by: Fady Bader <fady@mellanox.com>
> Depends-on: series-9374 ("Windows basic memory management")
> ---
>  lib/librte_eal/rte_eal_exports.def | 1 +
>  lib/librte_eal/rte_eal_version.map | 5 ++++-
>  lib/meson.build                    | 2 +-
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eal/rte_eal_exports.def
> b/lib/librte_eal/rte_eal_exports.def index 854b83bcd..cbb6b8cfe 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -1,5 +1,6 @@
>  EXPORTS
>  	__rte_panic
> +	per_lcore__rte_errno
>  	rte_calloc
>  	rte_calloc_socket
>  	rte_eal_get_configuration
> diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map index bdd014638..1a1dedcd9 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -390,4 +390,7 @@ EXPERIMENTAL {
>  	rte_trace_point_lookup;
>  	rte_trace_regexp;
>  	rte_trace_save;
> -};
> +
> +	# added in 20.08
> +	__emutls_v.per_lcore__rte_errno;
> +};
> \ No newline at end of file

No newline at end of file.

> diff --git a/lib/meson.build b/lib/meson.build
> index d190d84ef..5b644f5cd 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -36,7 +36,7 @@ libraries = [
>  	'flow_classify', 'bpf', 'graph', 'node']
>  
>  if is_windows
> -	libraries = ['kvargs','eal'] # only supported libraries for
> windows
> +	libraries = ['kvargs','eal','ring'] # only supported

Please always place spaces after commas. And IMO, it's time to start
breaking this list into lines as the common list above it does.

> libraries for windows endif
>  
>  default_cflags = machine_args

--
Dmitry Kozlyuk