> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Thursday, May 21, 2020 5:44 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [dpdk-dev] net/iavf: fix error setting for L2TAG
>
> Base on HW, if a packet be split into multiple segments, the L2TAG should
> only be valid on the last Rx descriptor. So fix it by setting L2TAG into mbuf
> when processing the last split packet.
>
> Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Base on HW, if a packet be split into multiple segments, the L2TAG should only be valid on the last Rx descriptor. So fix it by setting L2TAG into mbuf when processing the last split packet. Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") Signed-off-by: Jeff Guo <jia.guo@intel.com> --- drivers/net/iavf/iavf_rxtx_vec_common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h index a6ba22758..25bb502de 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_common.h +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h @@ -33,6 +33,7 @@ reassemble_packets(struct iavf_rx_queue *rxq, struct rte_mbuf **rx_bufs, if (!split_flags[buf_idx]) { /* it's the last packet of the set */ start->hash = end->hash; + start->vlan_tci = end->vlan_tci; start->ol_flags = end->ol_flags; /* we need to strip crc for the whole packet */ start->pkt_len -= rxq->crc_len; -- 2.20.1
On 05/20, Jeff Guo wrote:
>Base on HW, if a packet be split into multiple segments, the L2TAG
>should only be valid on the last Rx descriptor. So fix it by setting
>L2TAG into mbuf when processing the last split packet.
>
>Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
>
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
>---
> drivers/net/iavf/iavf_rxtx_vec_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h
>index a6ba22758..25bb502de 100644
>--- a/drivers/net/iavf/iavf_rxtx_vec_common.h
>+++ b/drivers/net/iavf/iavf_rxtx_vec_common.h
>@@ -33,6 +33,7 @@ reassemble_packets(struct iavf_rx_queue *rxq, struct rte_mbuf **rx_bufs,
> if (!split_flags[buf_idx]) {
> /* it's the last packet of the set */
> start->hash = end->hash;
>+ start->vlan_tci = end->vlan_tci;
> start->ol_flags = end->ol_flags;
> /* we need to strip crc for the whole packet */
> start->pkt_len -= rxq->crc_len;
>--
>2.20.1
>
Applied to dpdk-next-net-intel, Thanks.