DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] net/ice: fix error setting for L2TAG
  2020-05-20 21:46 [dpdk-dev] net/ice: fix error setting for L2TAG Jeff Guo
@ 2020-05-20 10:00 ` Zhang, Qi Z
  2020-05-21  0:23 ` Ye Xiaolong
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2020-05-20 10:00 UTC (permalink / raw)
  To: Guo, Jia, Yang, Qiming; +Cc: Ye, Xiaolong, dev



> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Thursday, May 21, 2020 5:46 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org; Guo, Jia
> <jia.guo@intel.com>
> Subject: [dpdk-dev] net/ice: fix error setting for L2TAG
> 
> Base on HW, if a packet be split into multiple segments, the L2TAG should
> only be valid on the last Rx descriptor. So fix it by setting L2TAG into mbuf
> when processing the last split packet.
> 
> Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev]  net/ice: fix error setting for L2TAG
@ 2020-05-20 21:46 Jeff Guo
  2020-05-20 10:00 ` Zhang, Qi Z
  2020-05-21  0:23 ` Ye Xiaolong
  0 siblings, 2 replies; 3+ messages in thread
From: Jeff Guo @ 2020-05-20 21:46 UTC (permalink / raw)
  To: qi.z.zhang, qiming.yang; +Cc: xiaolong.ye, dev, jia.guo

Base on HW, if a packet be split into multiple segments, the L2TAG
should only be valid on the last Rx descriptor. So fix it by setting
L2TAG into mbuf when processing the last split packet.

Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 drivers/net/ice/ice_rxtx_vec_common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h
index 6b57ff2ae..46e3be98a 100644
--- a/drivers/net/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/ice/ice_rxtx_vec_common.h
@@ -29,6 +29,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct rte_mbuf **rx_bufs,
 			if (!split_flags[buf_idx]) {
 				/* it's the last packet of the set */
 				start->hash = end->hash;
+				start->vlan_tci = end->vlan_tci;
 				start->ol_flags = end->ol_flags;
 				/* we need to strip crc for the whole packet */
 				start->pkt_len -= rxq->crc_len;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] net/ice: fix error setting for L2TAG
  2020-05-20 21:46 [dpdk-dev] net/ice: fix error setting for L2TAG Jeff Guo
  2020-05-20 10:00 ` Zhang, Qi Z
@ 2020-05-21  0:23 ` Ye Xiaolong
  1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2020-05-21  0:23 UTC (permalink / raw)
  To: Jeff Guo; +Cc: qi.z.zhang, qiming.yang, dev

On 05/20, Jeff Guo wrote:
>Base on HW, if a packet be split into multiple segments, the L2TAG
>should only be valid on the last Rx descriptor. So fix it by setting
>L2TAG into mbuf when processing the last split packet.
>
>Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx")
>
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
>---
> drivers/net/ice/ice_rxtx_vec_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h
>index 6b57ff2ae..46e3be98a 100644
>--- a/drivers/net/ice/ice_rxtx_vec_common.h
>+++ b/drivers/net/ice/ice_rxtx_vec_common.h
>@@ -29,6 +29,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct rte_mbuf **rx_bufs,
> 			if (!split_flags[buf_idx]) {
> 				/* it's the last packet of the set */
> 				start->hash = end->hash;
>+				start->vlan_tci = end->vlan_tci;
> 				start->ol_flags = end->ol_flags;
> 				/* we need to strip crc for the whole packet */
> 				start->pkt_len -= rxq->crc_len;
>-- 
>2.20.1
>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-21  0:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 21:46 [dpdk-dev] net/ice: fix error setting for L2TAG Jeff Guo
2020-05-20 10:00 ` Zhang, Qi Z
2020-05-21  0:23 ` Ye Xiaolong

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git