From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 450AEA0093; Thu, 21 May 2020 02:31:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 221371C2A0; Thu, 21 May 2020 02:31:55 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F1F671C2A0 for ; Thu, 21 May 2020 02:31:53 +0200 (CEST) IronPort-SDR: 0Fg6sVuBzc7cAR6no0E9ilsrtZtoVndt1rRMuzdrPc3pXbHCazM0JKlYOhYVhcXsAFpFGSrQmx 1cSC/h5ZSx9Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 17:31:53 -0700 IronPort-SDR: +LP8+rgeoaTKrcduF4TQFfxDL9ZurMRLzfUcEFH9TsX6PDbc706Ed8zfdkRsJ7+TLyY7hUO9sn Z5d9r3xj+oIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,415,1583222400"; d="scan'208";a="289534833" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga004.fm.intel.com with ESMTP; 20 May 2020 17:31:51 -0700 Date: Thu, 21 May 2020 08:23:14 +0800 From: Ye Xiaolong To: Jeff Guo Cc: qi.z.zhang@intel.com, qiming.yang@intel.com, dev@dpdk.org Message-ID: <20200521002314.GE99392@intel.com> References: <20200520214614.34513-1-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520214614.34513-1-jia.guo@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] net/ice: fix error setting for L2TAG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/20, Jeff Guo wrote: >Base on HW, if a packet be split into multiple segments, the L2TAG >should only be valid on the last Rx descriptor. So fix it by setting >L2TAG into mbuf when processing the last split packet. > >Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx") > >Signed-off-by: Jeff Guo >--- > drivers/net/ice/ice_rxtx_vec_common.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h >index 6b57ff2ae..46e3be98a 100644 >--- a/drivers/net/ice/ice_rxtx_vec_common.h >+++ b/drivers/net/ice/ice_rxtx_vec_common.h >@@ -29,6 +29,7 @@ ice_rx_reassemble_packets(struct ice_rx_queue *rxq, struct rte_mbuf **rx_bufs, > if (!split_flags[buf_idx]) { > /* it's the last packet of the set */ > start->hash = end->hash; >+ start->vlan_tci = end->vlan_tci; > start->ol_flags = end->ol_flags; > /* we need to strip crc for the whole packet */ > start->pkt_len -= rxq->crc_len; >-- >2.20.1 > Applied to dpdk-next-net-intel, Thanks.