From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Ciara Power <ciara.power@intel.com>,
"Laatz, Kevin" <kevin.laatz@intel.com>, dpdk-dev <dev@dpdk.org>,
Jerin Jacob <jerinj@marvell.com>,
David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs
Date: Fri, 22 May 2020 17:48:18 +0100 [thread overview]
Message-ID: <20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CALBAE1P3cGPvOWZbBxPDswL=q3H6iWJgebYmdhz=PX2kGCVDfg@mail.gmail.com>
On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> On Fri, May 22, 2020 at 7:21 PM Ciara Power <ciara.power@intel.com> wrote:
> >
> > Initially, printf was used to indicate and error/warning resulting from
> > telemetry initialisation. This is now fixed to use EAL logs for
> > warnings, and the unnecessary printf for an error is removed.
> >
> > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> > Fixes: dd6275a424ac ("telemetry: fix error log output")
> > Cc: david.marchand@redhat.com
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > ---
> > lib/librte_eal/freebsd/eal.c | 4 +++-
> > lib/librte_eal/linux/eal.c | 4 +++-
> > lib/librte_telemetry/rte_telemetry.h | 9 +++++++++
> > lib/librte_telemetry/telemetry.c | 2 --
> > 4 files changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
> > index 14b52168e..07456059e 100644
> > --- a/lib/librte_eal/freebsd/eal.c
> > +++ b/lib/librte_eal/freebsd/eal.c
> > @@ -956,13 +956,15 @@ rte_eal_init(int argc, char **argv)
> > return -1;
> > }
> > if (!internal_config.no_telemetry) {
> > - const char *error_str;
> > + const char *error_str = NULL;
> > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > &internal_config.ctrl_cpuset, &error_str)
> > != 0) {
> > rte_eal_init_alert(error_str);
> > return -1;
> > }
> > + if (error_str != NULL)
> > + RTE_LOG(WARNING, EAL, "%s\n", error_str);
> > }
> >
> > eal_mcfg_complete();
> > diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> > index 9620d2544..10317a660 100644
> > --- a/lib/librte_eal/linux/eal.c
> > +++ b/lib/librte_eal/linux/eal.c
> > @@ -1294,13 +1294,15 @@ rte_eal_init(int argc, char **argv)
> > return -1;
> > }
> > if (!internal_config.no_telemetry) {
> > - const char *error_str;
> > + const char *error_str = NULL;
> > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > &internal_config.ctrl_cpuset, &error_str)
> > != 0) {
> > rte_eal_init_alert(error_str);
> > return -1;
> > }
> > + if (error_str != NULL)
> > + RTE_LOG(WARNING, EAL, "%s\n", error_str);
>
> "EAL: No legacy callbacks, legacy socket not created" comes all the times now.
> Should we treat this as a warning? as it comes for with for the
> built-in applications?
> If it is important why not have a default handler in the EAL library?
>
Perhaps the warning level could be changed to INFO.
BTW: if you compile with jansson library available, the legacy callbacks
will be available and this will be silenced.
/Bruce
next prev parent reply other threads:[~2020-05-22 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 13:48 Ciara Power
2020-05-22 15:00 ` Bruce Richardson
2020-05-22 16:34 ` Jerin Jacob
2020-05-22 16:48 ` Bruce Richardson [this message]
2020-05-22 17:00 ` Jerin Jacob
2020-05-24 16:05 ` Thomas Monjalon
2020-05-25 9:55 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).