From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93799A0350; Fri, 22 May 2020 23:27:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B5571D9BD; Fri, 22 May 2020 23:27:37 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id B9BF01D9BC for ; Fri, 22 May 2020 23:27:35 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id AC55130C007; Fri, 22 May 2020 14:27:34 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com AC55130C007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1590182854; bh=XUf4Rqus0ry00vn5RZQ76B2W1ho7iPikGGNfMf/PXRI=; h=From:To:Cc:Subject:Date:From; b=rsCclxmw0gUpYPWitRGxSIsXB/DemwYH0t5/kso3SVN3ZaeEC9clPWYrrh86e9SLg LpQQsIx59/qwYT8lKCWe/XcyZehkqTdeMLFRFLKSdBb+c/ZQWG+Z8YbQ031lSkJ7C3 dh6adI6sC6lxiXRmPM5eSa/Ac2ksnDgTrJZxUeHg= Received: from localhost.localdomain (unknown [10.230.185.215]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 5FCD3140069; Fri, 22 May 2020 14:27:33 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Fri, 22 May 2020 14:27:31 -0700 Message-Id: <20200522212731.94269-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We are freeing flow_stats a little early. This results in a segfault when the driver accesses the members during cleanup. Move the call to bnxt_free_flow_stats_info() to prevent this. Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index e63578109..e8b4c058a 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp) static void bnxt_free_mem(struct bnxt *bp, bool reconfig) { - bnxt_free_flow_stats_info(bp); - bnxt_free_filter_mem(bp); bnxt_free_vnic_attributes(bp); bnxt_free_vnic_mem(bp); @@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev) bnxt_uninit_ctx_mem(bp); bnxt_uninit_locks(bp); + bnxt_free_flow_stats_info(bp); rte_free(bp->ptp_cfg); bp->ptp_cfg = NULL; return rc; -- 2.21.1 (Apple Git-122.3)