From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6565AA04EF; Mon, 25 May 2020 11:55:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4308B1D8CB; Mon, 25 May 2020 11:55:26 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3454D1D158 for ; Mon, 25 May 2020 11:55:25 +0200 (CEST) IronPort-SDR: oQYwUbIKMxZBAoz7RV2/+SakyQNqBu5IGohXaRtBOOV3QTFupq/P7fizcGRg0re1kfE5WaI2f/ fd9Op+2Um8rw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 02:55:24 -0700 IronPort-SDR: 12yb34Tj+JiCRpS1A5hTMF0wsIOHp26gDHKJH8Va3oAvu3qhnVAeROZaon+X/UFXtmOHQ8NkTk b4fASp2n1cDA== X-IronPort-AV: E=Sophos;i="5.73,433,1583222400"; d="scan'208";a="413463291" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.22.226]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 May 2020 02:55:22 -0700 Date: Mon, 25 May 2020 10:55:18 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Jerin Jacob , Ciara Power , Jerin Jacob , dev@dpdk.org, "Laatz, Kevin" , David Marchand , "Wiles, Keith" Message-ID: <20200525095518.GD891@bricha3-MOBL.ger.corp.intel.com> References: <20200522134839.15911-1-ciara.power@intel.com> <20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com> <1682317.61fhrPp9xr@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1682317.61fhrPp9xr@thomas> Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, May 24, 2020 at 06:05:53PM +0200, Thomas Monjalon wrote: > 22/05/2020 18:48, Bruce Richardson: > > On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote: > > > On Fri, May 22, 2020 at 7:21 PM Ciara Power wrote: > > > > > > > > Initially, printf was used to indicate and error/warning resulting from > > > > telemetry initialisation. This is now fixed to use EAL logs for > > > > warnings, and the unnecessary printf for an error is removed. > > > > > > > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency") > > > > Fixes: dd6275a424ac ("telemetry: fix error log output") > > > > Cc: david.marchand@redhat.com > > > > > > > > Signed-off-by: Ciara Power > > > > --- > > > > --- a/lib/librte_eal/linux/eal.c > > > > +++ b/lib/librte_eal/linux/eal.c > > > > + if (error_str != NULL) > > > > + RTE_LOG(WARNING, EAL, "%s\n", error_str); > > > > > > "EAL: No legacy callbacks, legacy socket not created" comes all the times now. > > > Should we treat this as a warning? as it comes for with for the > > > built-in applications? > > > If it is important why not have a default handler in the EAL library? > > > > Perhaps the warning level could be changed to INFO. > > BTW: if you compile with jansson library available, the legacy callbacks > > will be available and this will be silenced. > > Applied with log level set as NOTICE. > Thanks.