DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev]  net/iavf: fix flow uninit issue
@ 2020-05-27  7:16 Jeff Guo
  2020-05-28  2:14 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Guo @ 2020-05-27  7:16 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang, jingjing.wu, qiming.yang
  Cc: xiaolong.ye, dev, jia.guo

When closing VF device, the process of shutdown adminq should be after of
the process of uninit the flow, since the VF might be still use the adminq
to uninit flow.

Fixes: 9e03acd726cf ("net/iavf: fix flow access")
Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index e09efffd1..2b1066b0a 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1432,6 +1432,7 @@ iavf_dev_close(struct rte_eth_dev *dev)
 
 	iavf_dev_stop(dev);
 	iavf_flow_flush(dev, NULL);
+	iavf_flow_uninit(adapter);
 	iavf_shutdown_adminq(hw);
 	/* disable uio intr before callback unregister */
 	rte_intr_disable(intr_handle);
@@ -1440,8 +1441,6 @@ iavf_dev_close(struct rte_eth_dev *dev)
 	rte_intr_callback_unregister(intr_handle,
 				     iavf_dev_interrupt_handler, dev);
 	iavf_disable_irq0(hw);
-
-	iavf_flow_uninit(adapter);
 }
 
 static int
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] net/iavf: fix flow uninit issue
  2020-05-27  7:16 [dpdk-dev] net/iavf: fix flow uninit issue Jeff Guo
@ 2020-05-28  2:14 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-05-28  2:14 UTC (permalink / raw)
  To: Jeff Guo; +Cc: beilei.xing, qi.z.zhang, jingjing.wu, qiming.yang, dev

On 05/27, Jeff Guo wrote:
>When closing VF device, the process of shutdown adminq should be after of
>the process of uninit the flow, since the VF might be still use the adminq
>to uninit flow.
>
>Fixes: 9e03acd726cf ("net/iavf: fix flow access")
>Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
>---
> drivers/net/iavf/iavf_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
>index e09efffd1..2b1066b0a 100644
>--- a/drivers/net/iavf/iavf_ethdev.c
>+++ b/drivers/net/iavf/iavf_ethdev.c
>@@ -1432,6 +1432,7 @@ iavf_dev_close(struct rte_eth_dev *dev)
> 
> 	iavf_dev_stop(dev);
> 	iavf_flow_flush(dev, NULL);
>+	iavf_flow_uninit(adapter);
> 	iavf_shutdown_adminq(hw);
> 	/* disable uio intr before callback unregister */
> 	rte_intr_disable(intr_handle);
>@@ -1440,8 +1441,6 @@ iavf_dev_close(struct rte_eth_dev *dev)
> 	rte_intr_callback_unregister(intr_handle,
> 				     iavf_dev_interrupt_handler, dev);
> 	iavf_disable_irq0(hw);
>-
>-	iavf_flow_uninit(adapter);
> }
> 
> static int
>-- 
>2.20.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-28  2:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27  7:16 [dpdk-dev] net/iavf: fix flow uninit issue Jeff Guo
2020-05-28  2:14 ` Ye Xiaolong

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git