From: Stephen Hemminger <stephen@networkplumber.org>
To: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory
Date: Thu, 28 May 2020 22:48:30 -0700 [thread overview]
Message-ID: <20200528224830.20181ddd@hermes.lan> (raw)
In-Reply-To: <20200526172455.6457-1-hrvoje.habjanic@zg.ht.hr>
On Tue, 26 May 2020 19:24:55 +0200
Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr> wrote:
> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c,
> line 865), there is code to free all allocated stuff related to
> scheduler subport. First there are some checks, and in the end,
> rte_bitmap_free is called.
>
> Now, rte_bitmap_free is a dummy function, and it just checks if
> provided pointer to bitmap is valid or not. So, actual memory for
> subport is not freed.
>
> This patch fixes this by removing call to rte_bitmap_free, and
> instead calling rte_free.
>
> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
Fixes: ce7c4fd7c2ac ("sched: add pipe config to subport level")
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2020-05-29 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:24 Hrvoje Habjanic
2020-05-27 11:48 ` Singh, Jasvinder
2020-05-30 8:05 ` Hrvoje Habjanic
2020-06-24 22:47 ` Thomas Monjalon
2020-05-29 5:48 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528224830.20181ddd@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hrvoje.habjanic@zg.ht.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).