DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values
Date: Fri, 29 May 2020 09:11:54 +0800	[thread overview]
Message-ID: <20200529011154.GB75561@intel.com> (raw)
In-Reply-To: <20200528053913.98113-1-haiyue.wang@intel.com>

On 05/28, Haiyue Wang wrote:
>The PCI DSN (device serial number) to format package file name should be
>lowercase values.
>
>Fixes: d1c91179e952 ("net/ice: check DSN package file firstly")
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_dcf_parent.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
>index bdfc7d430..d13e19d78 100644
>--- a/drivers/net/ice/ice_dcf_parent.c
>+++ b/drivers/net/ice/ice_dcf_parent.c
>@@ -242,13 +242,13 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
> 	rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
> 
> 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>-		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
>+		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llx.pkg",
> 		 (unsigned long long)dsn);
> 	if (!access(pkg_name, 0))
> 		return 0;
> 
> 	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>-		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
>+		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llx.pkg",
> 		 (unsigned long long)dsn);
> 	if (!access(pkg_name, 0))
> 		return 0;
>-- 
>2.26.2
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

      reply	other threads:[~2020-05-29  1:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  5:39 Haiyue Wang
2020-05-29  1:11 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529011154.GB75561@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).