DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Fady Bader <fady@mellanox.com>, <dev@dpdk.org>,
	<thomas@monjalon.net>, <tbashar@mellanox.com>,
	<talshn@mellanox.com>, <yohadt@mellanox.com>,
	<olivier.matz@6wind.com>, <mdr@ashroe.eu>,
	<nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows
Date: Mon, 1 Jun 2020 04:54:37 +0300
Message-ID: <20200601045437.1f2f43a4@sovereign> (raw)
In-Reply-To: <bd42a5b0-4b32-3fc1-fc5c-62d70a292ea1@solarflare.com>

On Sun, 31 May 2020 16:02:21 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

[snip]
> >  
> > +#ifndef RTE_EXEC_ENV_WINDOWS
> >  #include <rte_trace_point_register.h>
> > +#endif  
> 
> I really dislike the approach. It adds too many conditional
> compilation statements which make code harder to read.
> 
> You can have dummy implementation of these functions on
> Windows to avoid the conditional compilation.

Memory management series, on which this patchset depends, does have such
wrappers: http://patchwork.dpdk.org/patch/70565/.

-- 
Dmitry Kozlyuk

  reply	other threads:[~2020-06-01  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 12:41 [dpdk-dev] [PATCH 0/5] build mempool on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows Fady Bader
2020-05-31 13:02   ` Andrew Rybchenko
2020-06-01  1:54     ` Dmitry Kozlyuk [this message]
2020-05-31 13:49   ` Jerin Jacob
2020-05-31 12:41 ` [dpdk-dev] [PATCH 2/5] eal: disable function versioning on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 3/5] mempool: use generic memory management Fady Bader
2020-05-31 13:06   ` Andrew Rybchenko
2020-05-31 12:41 ` [dpdk-dev] [PATCH 4/5] eal: export needed functions for mempool Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 5/5] mempool: mempool build on Windows Fady Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200601045437.1f2f43a4@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=fady@mellanox.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=olivier.matz@6wind.com \
    --cc=talshn@mellanox.com \
    --cc=tbashar@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=yohadt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git