From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B17E1A04EF; Mon, 1 Jun 2020 03:54:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A54C61D381; Mon, 1 Jun 2020 03:54:40 +0200 (CEST) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id 308FF397D for ; Mon, 1 Jun 2020 03:54:39 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id x22so3019253lfd.4 for ; Sun, 31 May 2020 18:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sRgUTvEfqHqPWAudZG8vMslcg56kx1twpdN0EVT0+8o=; b=NlIrLeER5h8lSpNFTGdsRKLWhHlasaWCrSrqtzR2IXdwWsW1U/sAl2OURZrJcoJXXw Oy6mC8RGfwAqA/EPFUc2Iw97CFeTm5LKJQ0T7AWBD8YD+WOvURA7xpNX5W0qPptZdsnn hMgo40OSNPAjbJbndV6vcoobGHuz011eUXO+kcPW+fuDz4kGK/7rJA4BbTbnszPruOZq zbLJDRylAp6pVWTjg+XaAsMnlphvByaPC5xrSs6HozoRI91ioIwbvU/anASceZEazAdW eTXmWnpVsrr1XIFgzewJMDDW0eXDbO2HFCfTlBvGsWCnbEXAk516JniXrxXU3AFQLCWY d2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sRgUTvEfqHqPWAudZG8vMslcg56kx1twpdN0EVT0+8o=; b=JeC5E5kASVoIivsEOVswpge/NB0wKDDShSeMhCdMpg4MKrIUQYzr7lN5Ra0NiF9H14 WL6EUfKq6b9SNbxZN1X0156sIYAFiinlRj0op18X0r7fybjKMISUKsQCbVvGeDiapXEj gjINHMgZLl2m/E4obpWL1ExDMs030zEQrg1yROGPdQKejrUe07qX+K3YaFz8fQtsdYb7 UU+PNn5V+E+tTILImrzmq45Z68/ot9s3buozpmzgwTLrj/WSsx7ye6XLFa8pbqwk5fdZ ulx9OF6SdN9pcPpvFV9CqQVdbyPh2X+qlvKp+I7Qm0/UkaIMhiUUxxbX8j71hiZSm/Sr pbgQ== X-Gm-Message-State: AOAM530uL63uoxXciOTqiavvnne1wycura9AWQ++mD3Y6yIBlANAkxY7 TByxQGyvr5qzaeU/pIkecIs= X-Google-Smtp-Source: ABdhPJyzLfC6R/hf60t5dGCXC3Q2NXEaWIqNxbc52d5GoEUuZtyuIMn0OIS1DrDHiS2kGHHcZRFrtQ== X-Received: by 2002:a05:6512:108f:: with SMTP id j15mr10025983lfg.19.1590976478629; Sun, 31 May 2020 18:54:38 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 66sm4940867lfk.54.2020.05.31.18.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 18:54:37 -0700 (PDT) Date: Mon, 1 Jun 2020 04:54:37 +0300 From: Dmitry Kozlyuk To: Andrew Rybchenko Cc: Fady Bader , , , , , , , , Message-ID: <20200601045437.1f2f43a4@sovereign> In-Reply-To: References: <20200531124151.16848-1-fady@mellanox.com> <20200531124151.16848-2-fady@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 31 May 2020 16:02:21 +0300 Andrew Rybchenko wrote: [snip] > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > #include > > +#endif > > I really dislike the approach. It adds too many conditional > compilation statements which make code harder to read. > > You can have dummy implementation of these functions on > Windows to avoid the conditional compilation. Memory management series, on which this patchset depends, does have such wrappers: http://patchwork.dpdk.org/patch/70565/. -- Dmitry Kozlyuk