From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29927A04EF; Mon, 1 Jun 2020 21:56:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 593C81BFF6; Mon, 1 Jun 2020 21:56:13 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 67D431BFF5 for ; Mon, 1 Jun 2020 21:56:11 +0200 (CEST) Received: from 2606-a000-111b-4634-0000-0000-0000-1bf2.inf6.spectrum.com ([2606:a000:111b:4634::1bf2] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1jfqXO-0003uD-OZ; Mon, 01 Jun 2020 15:56:03 -0400 Date: Mon, 1 Jun 2020 15:55:57 -0400 From: Neil Horman To: Fady Bader Cc: dev@dpdk.org, thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu Message-ID: <20200601195557.GB210755@hmswarspite.think-freely.org> References: <20200601103139.8612-1-fady@mellanox.com> <20200601103139.8612-2-fady@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200601103139.8612-2-fady@mellanox.com> X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH v2 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 01, 2020 at 01:31:36PM +0300, Fady Bader wrote: > Function versioning is not needed on Windows, also the function versioning > implementation is not supported by Windows. > Function versioning was disabled on Windows. > I get that windows doesn't seem to support symbol level versioning, but I'm not sure its reasonable to say that its not needed, unless we never have any intention of building dpdk on windows using a DSO model. The below definately solves the immediate problem, but if we plan to support windows with dynamic library builds, this just kicks the can down the road. Do we know if we have future plans of supporting dlls on windows in the future? Neil > Signed-off-by: Fady Bader > --- > lib/librte_eal/include/rte_function_versioning.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_eal/include/rte_function_versioning.h b/lib/librte_eal/include/rte_function_versioning.h > index f588f2643..cee06602e 100644 > --- a/lib/librte_eal/include/rte_function_versioning.h > +++ b/lib/librte_eal/include/rte_function_versioning.h > @@ -11,6 +11,10 @@ > #error Use of function versioning disabled, is "use_function_versioning=true" in meson.build? > #endif > > +#ifdef RTE_EXEC_ENV_WINDOWS > +#undef RTE_BUILD_SHARED_LIB > +#endif > + > #ifdef RTE_BUILD_SHARED_LIB > > /* > -- > 2.16.1.windows.4 > >