From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57FECA00C4; Thu, 4 Jun 2020 18:22:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07FF31D5C7; Thu, 4 Jun 2020 18:22:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 92DC81D57F for ; Thu, 4 Jun 2020 18:22:42 +0200 (CEST) IronPort-SDR: GH2+LGey6hVr5b0y4es/P/SBK68YFKwnvQdBvg8QepsceASSLj3V884CFFZESnrmZ8Ibo8tAU9 aH4GWFS9nFKA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 09:22:41 -0700 IronPort-SDR: FmE17mEuSiO45m1+hWuw3Bly3j3f4ha4enmVmtDz9GkanQDoIaW12jLOTOQkg/Mv6c3j3h4dC4 Nktxd2RdOCNg== X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="416965824" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.25.230]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Jun 2020 09:22:40 -0700 Date: Thu, 4 Jun 2020 17:22:36 +0100 From: Bruce Richardson To: Christian Ehrhardt Cc: Luca Boccassi , dev Message-ID: <20200604162236.GB1543@bricha3-MOBL.ger.corp.intel.com> References: <20200507072629.2374881-1-christian.ehrhardt@canonical.com> <20200507112518.GA1457@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] autotest: fix for pure python3 environments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 04, 2020 at 04:43:50PM +0200, Christian Ehrhardt wrote: > On Thu, May 7, 2020 at 1:25 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Thu, May 07, 2020 at 10:36:35AM +0100, Luca Boccassi wrote: > > On Thu, 2020-05-07 at 09:26 +0200, Christian Ehrhardt wrote: > > > Without this fix in a pure python3 environment this will run > into > > > issues like: > > > ModuleNotFoundError: No module named 'StringIO' > > > or later string encoding issues on check_output. > > > > > > Signed-off-by: Christian Ehrhardt > <[2]christian.ehrhardt@canonical.com> > > > --- > > > app/test/autotest_runner.py | 16 +++++++--------- > > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > Acked-by: Luca Boccassi <[3]bluca@debian.org> > > > > Note that this makes the file python3-only (as far as I can see) - > I > > think it's fine at this point, given python2 is EOL? > > > I think for 20.11 we should aim to have all python in DPDK python3 > only. > > IMHO Robin's feeback wasn't forcing a mandatory v2 (I wa not planning > on one). > Nothing else happened on this, since we failed to hit 20.05 I wanted to > ping again on this. > Just to note that similar changes/fixes are included in set: http://patches.dpdk.org/project/dpdk/list/?series=10204