From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEFDFA04F2; Mon, 8 Jun 2020 18:46:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0C3C2BA2; Mon, 8 Jun 2020 18:46:53 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 953A525B3 for ; Mon, 8 Jun 2020 18:46:52 +0200 (CEST) IronPort-SDR: Ku0jA/2o+t3EAHHbNQLJrjv16+mRXqAu7oqky2RGKPnVTg4WdM0w4zd589rVYUIsAyhomnpcq4 aHHnbpUOuL6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2020 09:46:51 -0700 IronPort-SDR: SMEX56/wismP410dOLB6OjxxlPRAwgDm8zKTeGqQtKwCZUOkXGoON4Wc34+qfvNcvU/zdUZO1x LPhh50VXfeIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,487,1583222400"; d="scan'208";a="288537144" Received: from silpixa00399126.ir.intel.com ([10.237.222.239]) by orsmga002.jf.intel.com with ESMTP; 08 Jun 2020 09:46:50 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Date: Mon, 8 Jun 2020 17:46:40 +0100 Message-Id: <20200608164640.189755-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than continuing to recommend an 80-char line limit, let's take a hint from the Linux kernel[1] and aim for an 100-char recommended limit instead. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 Signed-off-by: Bruce Richardson --- devtools/checkpatches.sh | 2 +- doc/guides/contributing/coding_style.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 158087f1c..4970ed830 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -15,7 +15,7 @@ VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path # to a dictionary.txt file if dictionary.txt is not in the default location. codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} # override default Linux options options="--no-tree" diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst index 4efde93f6..1db3a7bbe 100644 --- a/doc/guides/contributing/coding_style.rst +++ b/doc/guides/contributing/coding_style.rst @@ -21,7 +21,7 @@ The rules and guidelines given in this document cannot cover every situation, so * In the case of creating new files, the style should be consistent within each file in a given directory or module. * The primary reason for coding standards is to increase code readability and comprehensibility, therefore always use whatever option will make the code easiest to read. -Line length is recommended to be not more than 80 characters, including comments. +Line length is recommended to be not more than 100 characters, including comments. [Tab stop size should be assumed to be 8-characters wide]. .. note:: -- 2.25.1