From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35D42A04FC; Tue, 9 Jun 2020 11:29:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7850825D9; Tue, 9 Jun 2020 11:29:57 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BC5222142 for ; Tue, 9 Jun 2020 11:29:54 +0200 (CEST) IronPort-SDR: ZVyZkfmEkWTSGuBLbYQJqEijn8Ff374Rz1O+/fhO0YTzROVPuEn7RQxYQqHx0u1Fvc8qTZqZMW H72slJOdosVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 02:29:51 -0700 IronPort-SDR: 1w6S/5SGA12gwrl2V31RfxAC7VFsiiX79bbKhlAZf0gvOH6VBL8c32gtmUCTzFPmP3vH4tf4ud hZWJ9qWOeIbQ== X-IronPort-AV: E=Sophos;i="5.73,491,1583222400"; d="scan'208";a="472907354" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.129]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Jun 2020 02:29:51 -0700 Date: Tue, 9 Jun 2020 10:29:49 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20200609092949.GA1565@bricha3-MOBL.ger.corp.intel.com> References: <20200608164640.189755-1-bruce.richardson@intel.com> <20200608121723.7a042105@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200608121723.7a042105@hermes.lan> Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: > On Mon, 8 Jun 2020 17:46:40 +0100 > Bruce Richardson wrote: > > > Rather than continuing to recommend an 80-char line limit, let's take a hint > > from the Linux kernel[1] and aim for an 100-char recommended limit instead. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > > > Signed-off-by: Bruce Richardson > > --- > > devtools/checkpatches.sh | 2 +- > > doc/guides/contributing/coding_style.rst | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index 158087f1c..4970ed830 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -15,7 +15,7 @@ VALIDATE_NEW_API=$(dirname $(readlink -f $0))/check-symbol-change.sh > > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to a valid path > > # to a dictionary.txt file if dictionary.txt is not in the default location. > > codespell=${DPDK_CHECKPATCH_CODESPELL:-enable} > > -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > > +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100} > > > > # override default Linux options > > options="--no-tree" > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst > > index 4efde93f6..1db3a7bbe 100644 > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > @@ -21,7 +21,7 @@ The rules and guidelines given in this document cannot cover every situation, so > > * In the case of creating new files, the style should be consistent within each file in a given directory or module. > > * The primary reason for coding standards is to increase code readability and comprehensibility, therefore always use whatever option will make the code easiest to read. > > > > -Line length is recommended to be not more than 80 characters, including comments. > > +Line length is recommended to be not more than 100 characters, including comments. > > [Tab stop size should be assumed to be 8-characters wide]. > > > > .. note:: > > I would even support going to 120 characters. > > Acked-by: Stephen Hemminger I think 100 is enough. In my case, I have a 1080p 24" monitor, and with two terminals side-by-side 100 characters just fits inside each vim window. Going to 120 would be fine for single terminal at a time, but I would find awkward for e.g. side-by-side diff comparison in meld etc.