From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCEBCA04FE; Tue, 9 Jun 2020 16:17:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B24D21BEAF; Tue, 9 Jun 2020 16:17:54 +0200 (CEST) Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by dpdk.org (Postfix) with ESMTP id 21BC91F28 for ; Tue, 9 Jun 2020 16:17:53 +0200 (CEST) Received: by mail-qv1-f65.google.com with SMTP id g11so3667018qvs.2 for ; Tue, 09 Jun 2020 07:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=radio-canada-ca.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=54vla9QLYsaLV2JqWIlKmKS5YgRmg4HzDGUmjeGuaWg=; b=kqDRI+k9tkAOF5hMujDEbtR5dvKwLjxDmo9t/FFfEIA9w3nI8Y7Q17elBiGtkOyaUo AOcQtG9IJtM/OFIuF6rMtk1znljcRvpy352rgMumQQCABcJRAlwTldePJoautV3u8Mg5 29fLUhSVTFjtEWU6RpCDDO2uJLw27a7NSAADyv4uqxpZwjSYq/mOXGsDT/zfPX4BgV4T zxQagLX2KXUIZ+qcKLoxYFsHVTnCI0PxwWJBWK0XhM5WLjsBHushsaBDuq+7E6F2UGVQ xA4V7nCwGy/FMseoA76QfeeVMqB6VDzFCZk938s0vYYlyA4MmQ0zIEZC/Osp2SwqTFLM e0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=54vla9QLYsaLV2JqWIlKmKS5YgRmg4HzDGUmjeGuaWg=; b=cIBHrlEIJIxAQN5HiXRbg2kSFZ38Q3H9vMiG7BUne0ze3LpOI6/LT9f8JjwZsM2fWC +1mxDcFWzL1+EHOLoVmBlORixKANrRgdjivOQLeNpFss6NA5TGL5h4cwXEcSYU/QREP1 x99Onvbl977yDkbZtXL5ll+EEK5l28p8tO4oA+/6UNFI8jC7f9iq+9Q+TLOQOQQdSpZ6 oURsKZxZ90HoSGAbDZo8ZPt40M5zpztNKobJIbugpaWqZgycpIyY83SkAlGWA9vHsOJx xJKQlmtqyBDNsqnLUsoKBpghaW6oHg1p6XdOxWtGqWsT0uMtwpfJXCwXQGQvpxVi+xgV AJHw== X-Gm-Message-State: AOAM53284gxLA6BaOErEoFzbQeVu/XxwcxXnlM6MNNc49A6a/WOtnWDO ojMtSryVcEg9fDUeKTo2LtwITPmTh5B1pw== X-Google-Smtp-Source: ABdhPJywhmaL21V74ZIpIRHk5nka7ymvrErfVfUdtZ1I++a5e9U0brPmiSoerho/zJWpjikYzMpFPA== X-Received: by 2002:ad4:47b1:: with SMTP id a17mr4126074qvz.16.1591712268886; Tue, 09 Jun 2020 07:17:48 -0700 (PDT) Received: from localhost.localdomain (104-163-142-249.qc.dsl.ebox.net. [104.163.142.249]) by smtp.gmail.com with ESMTPSA id a82sm10287148qkb.29.2020.06.09.07.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 07:17:48 -0700 (PDT) From: Patrick Keroulas To: dev@dpdk.org Cc: Patrick Keroulas Date: Tue, 9 Jun 2020 10:17:11 -0400 Message-Id: <20200609141713.11614-2-patrick.keroulas@radio-canada.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200609141713.11614-1-patrick.keroulas@radio-canada.ca> References: <20200609141713.11614-1-patrick.keroulas@radio-canada.ca> Subject: [dpdk-dev] [RFC] [PATCH v1 1/3] net/mlx5: add timestamp-to-ns converter from libibverbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" While some devices update their own clock info to provide current time, mlx5dv part of libibverbs already handles this and also converts any raw counter cycle to nanoseconds. Signed-off-by: Patrick Keroulas --- drivers/common/mlx5/mlx5_glue.c | 16 ++++++++++++++++ drivers/common/mlx5/mlx5_glue.h | 4 ++++ drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++++++++++++++++++++++++++ 5 files changed, 52 insertions(+) diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c index f270f677b..756f24b8b 100644 --- a/drivers/common/mlx5/mlx5_glue.c +++ b/drivers/common/mlx5/mlx5_glue.c @@ -80,6 +80,20 @@ mlx5_glue_query_rt_values_ex(struct ibv_context *context, return ibv_query_rt_values_ex(context, values); } +static int +mlx5_glue_get_clock_info(struct ibv_context *context, + struct mlx5dv_clock_info *clock_info) +{ + return mlx5dv_get_clock_info(context, clock_info); +} + +static uint64_t +mlx5_glue_mlx5dv_ts_to_ns(struct mlx5dv_clock_info *clock_info, + uint64_t device_timestamp) +{ + return mlx5dv_ts_to_ns(clock_info, device_timestamp); +} + static int mlx5_glue_query_port(struct ibv_context *context, uint8_t port_num, struct ibv_port_attr *port_attr) @@ -1195,6 +1209,8 @@ const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue) { .query_device = mlx5_glue_query_device, .query_device_ex = mlx5_glue_query_device_ex, .query_rt_values_ex = mlx5_glue_query_rt_values_ex, + .get_clock_info = mlx5_glue_get_clock_info, + .convert_ts_to_ns = mlx5_glue_mlx5dv_ts_to_ns, .query_port = mlx5_glue_query_port, .create_comp_channel = mlx5_glue_create_comp_channel, .destroy_comp_channel = mlx5_glue_destroy_comp_channel, diff --git a/drivers/common/mlx5/mlx5_glue.h b/drivers/common/mlx5/mlx5_glue.h index 81d6a2267..d4b3bd793 100644 --- a/drivers/common/mlx5/mlx5_glue.h +++ b/drivers/common/mlx5/mlx5_glue.h @@ -123,6 +123,10 @@ struct mlx5_glue { struct ibv_port_attr *port_attr); struct ibv_comp_channel *(*create_comp_channel) (struct ibv_context *context); + int (*get_clock_info)(struct ibv_context *context, + struct mlx5dv_clock_info *clock_info); + uint64_t (*convert_ts_to_ns)(struct mlx5dv_clock_info *clock_info, + uint64_t device_timestamp); int (*destroy_comp_channel)(struct ibv_comp_channel *channel); struct ibv_cq *(*create_cq)(struct ibv_context *context, int cqe, void *cq_context, diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 5589772eb..7b201844c 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1569,6 +1569,7 @@ const struct eth_dev_ops mlx5_dev_ops = { .xstats_get_names = mlx5_xstats_get_names, .fw_version_get = mlx5_fw_version_get, .dev_infos_get = mlx5_dev_infos_get, + .convert_ts_to_ns = mlx5_convert_ts_to_ns, .read_clock = mlx5_read_clock, .dev_supported_ptypes_get = mlx5_dev_supported_ptypes_get, .vlan_filter_set = mlx5_vlan_filter_set, diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index d9f5d816f..905e24487 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -656,6 +656,7 @@ int mlx5_set_flags(struct rte_eth_dev *dev, unsigned int keep, unsigned int flags); int mlx5_dev_configure(struct rte_eth_dev *dev); int mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info); +int mlx5_convert_ts_to_ns(struct rte_eth_dev *dev, uint64_t *timestamp); int mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock); int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size); const uint32_t *mlx5_dev_supported_ptypes_get(struct rte_eth_dev *dev); diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 47f11b963..1d0411f6b 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -690,6 +690,36 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) return 0; } +/** + * Convert raw clock counter to nanoseconds + * + * @param dev + * Pointer to Ethernet device structure. + * @param[in&out] timestamp + * Pointer to the timestamp to be converted. + * + * @return + * 0 if the clock has correctly been read + * The value of errno in case of error + */ +int +mlx5_convert_ts_to_ns(struct rte_eth_dev *dev, uint64_t *timestamp) +{ + struct mlx5_priv *priv = dev->data->dev_private; + struct ibv_context *ctx = priv->sh->ctx; + struct mlx5dv_clock_info clock_info; + + int err = mlx5_glue->get_clock_info(ctx, &clock_info); + if (err != 0) { + DRV_LOG(WARNING, "Could not get the clock info!"); + return err; + } + + *timestamp = mlx5_glue->convert_ts_to_ns(&clock_info, *timestamp); + + return err; +} + /** * Get device current raw clock counter * -- 2.17.1