From: <jerinj@marvell.com>
To: <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
"Marko Kovacevic" <marko.kovacevic@intel.com>
Cc: <thomas@monjalon.net>, <maxime.coquelin@redhat.com>,
<david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>
Subject: [dpdk-dev] [PATCH] bus/pci: optimize bus scan
Date: Wed, 10 Jun 2020 17:20:50 +0530 [thread overview]
Message-ID: <20200610115050.1636260-1-jerinj@marvell.com> (raw)
From: Jerin Jacob <jerinj@marvell.com>
In order to optimize the PCI management, RTE_KDRV_NONE based
device driver probing removed by not adding them to list in
the scan phase.
The legacy virtio is the only consumer of RTE_KDRV_NONE based device
driver probe scheme. The legacy virtio support will be available
through the existing VFIO/UIO based kernel driver scheme.
This patch also removes the deprecation notice for the same.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 8 --------
drivers/bus/pci/linux/pci.c | 25 +++----------------------
2 files changed, 3 insertions(+), 30 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 0bee92425..d1034f60f 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -130,11 +130,3 @@ Deprecation Notices
Python 2 support will be completely removed in 20.11.
In 20.08, explicit deprecation warnings will be displayed when running
scripts with Python 2.
-
-* pci: Remove ``RTE_KDRV_NONE`` based device driver probing.
- In order to optimize the DPDK PCI enumeration management, ``RTE_KDRV_NONE``
- based device driver probing will be removed in v20.08.
- The legacy virtio is the only consumer of ``RTE_KDRV_NONE`` based device
- driver probe scheme. The legacy virtio support will be available through
- the existing VFIO/UIO based kernel driver scheme.
- More details at https://patches.dpdk.org/patch/69351/
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index da2f55b3a..a2198abf4 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -330,9 +330,10 @@ pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)
dev->kdrv = RTE_KDRV_UIO_GENERIC;
else
dev->kdrv = RTE_KDRV_UNKNOWN;
- } else
+ } else {
dev->kdrv = RTE_KDRV_NONE;
-
+ return 0;
+ }
/* device is valid, add in list (sorted) */
if (TAILQ_EMPTY(&rte_pci_bus.device_list)) {
rte_pci_add_device(dev);
@@ -772,11 +773,6 @@ rte_pci_ioport_map(struct rte_pci_device *dev, int bar,
ret = pci_ioport_map(dev, bar, p);
#else
ret = pci_uio_ioport_map(dev, bar, p);
-#endif
- break;
- case RTE_KDRV_NONE:
-#if defined(RTE_ARCH_X86)
- ret = pci_ioport_map(dev, bar, p);
#endif
break;
default:
@@ -805,11 +801,6 @@ rte_pci_ioport_read(struct rte_pci_ioport *p,
case RTE_KDRV_UIO_GENERIC:
pci_uio_ioport_read(p, data, len, offset);
break;
- case RTE_KDRV_NONE:
-#if defined(RTE_ARCH_X86)
- pci_uio_ioport_read(p, data, len, offset);
-#endif
- break;
default:
break;
}
@@ -831,11 +822,6 @@ rte_pci_ioport_write(struct rte_pci_ioport *p,
case RTE_KDRV_UIO_GENERIC:
pci_uio_ioport_write(p, data, len, offset);
break;
- case RTE_KDRV_NONE:
-#if defined(RTE_ARCH_X86)
- pci_uio_ioport_write(p, data, len, offset);
-#endif
- break;
default:
break;
}
@@ -861,11 +847,6 @@ rte_pci_ioport_unmap(struct rte_pci_ioport *p)
ret = 0;
#else
ret = pci_uio_ioport_unmap(p);
-#endif
- break;
- case RTE_KDRV_NONE:
-#if defined(RTE_ARCH_X86)
- ret = 0;
#endif
break;
default:
--
2.26.2
next reply other threads:[~2020-06-10 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 11:50 jerinj [this message]
2020-06-16 21:39 ` Thomas Monjalon
2020-06-24 8:53 ` Jerin Jacob
2020-06-24 11:46 ` [dpdk-dev] [PATCH v2] " jerinj
2020-06-24 21:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610115050.1636260-1-jerinj@marvell.com \
--to=jerinj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).