DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal/vfio: reduce severity of startup messages
@ 2020-06-11 18:40 Stephen Hemminger
  2020-06-12  0:10 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2020-06-11 18:40 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Stephen Hemminger

The startup of VFIO is too noisy. Logging is expensive on some
systems, and distracting to the user.

It should not be logging at NOTICE level, reduce it to INFO level.
It really should be DEBUG here but that would hide it by default.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/linux/eal_vfio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c
index d26e1649a54e..cb869bfafaf0 100644
--- a/lib/librte_eal/linux/eal_vfio.c
+++ b/lib/librte_eal/linux/eal_vfio.c
@@ -891,7 +891,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
 		/* we have successfully initialized VFIO, notify user */
 		const struct vfio_iommu_type *t =
 				default_vfio_cfg->vfio_iommu_type;
-		RTE_LOG(NOTICE, EAL, "  using IOMMU type %d (%s)\n",
+		RTE_LOG(INFO, EAL, "  using IOMMU type %d (%s)\n",
 				t->type_id, t->name);
 	}
 
@@ -1069,7 +1069,7 @@ rte_vfio_enable(const char *modname)
 
 	/* check if we have VFIO driver enabled */
 	if (default_vfio_cfg->vfio_container_fd != -1) {
-		RTE_LOG(NOTICE, EAL, "VFIO support initialized\n");
+		RTE_LOG(INFO, EAL, "VFIO support initialized\n");
 		default_vfio_cfg->vfio_enabled = 1;
 	} else {
 		RTE_LOG(NOTICE, EAL, "VFIO support could not be initialized\n");
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] eal/vfio: reduce severity of startup messages
  2020-06-11 18:40 [dpdk-dev] [PATCH] eal/vfio: reduce severity of startup messages Stephen Hemminger
@ 2020-06-12  0:10 ` Stephen Hemminger
  2020-06-12  9:07   ` Burakov, Anatoly
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2020-06-12  0:10 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, Stephen Hemminger

The startup of VFIO is too noisy. Logging is expensive on some
systems, and distracting to the user.

It should not be logging at NOTICE level, reduce it to INFO level.
It really should be DEBUG here but that would hide it by default.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - add one more place

 lib/librte_eal/linux/eal_vfio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c
index d26e1649a54e..88a8c3b959cc 100644
--- a/lib/librte_eal/linux/eal_vfio.c
+++ b/lib/librte_eal/linux/eal_vfio.c
@@ -891,7 +891,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
 		/* we have successfully initialized VFIO, notify user */
 		const struct vfio_iommu_type *t =
 				default_vfio_cfg->vfio_iommu_type;
-		RTE_LOG(NOTICE, EAL, "  using IOMMU type %d (%s)\n",
+		RTE_LOG(INFO, EAL, "  using IOMMU type %d (%s)\n",
 				t->type_id, t->name);
 	}
 
@@ -1069,7 +1069,7 @@ rte_vfio_enable(const char *modname)
 
 	/* check if we have VFIO driver enabled */
 	if (default_vfio_cfg->vfio_container_fd != -1) {
-		RTE_LOG(NOTICE, EAL, "VFIO support initialized\n");
+		RTE_LOG(INFO, EAL, "VFIO support initialized\n");
 		default_vfio_cfg->vfio_enabled = 1;
 	} else {
 		RTE_LOG(NOTICE, EAL, "VFIO support could not be initialized\n");
@@ -1145,7 +1145,7 @@ vfio_set_iommu_type(int vfio_container_fd)
 		int ret = ioctl(vfio_container_fd, VFIO_SET_IOMMU,
 				t->type_id);
 		if (!ret) {
-			RTE_LOG(NOTICE, EAL, "  using IOMMU type %d (%s)\n",
+			RTE_LOG(INFO, EAL, "  using IOMMU type %d (%s)\n",
 					t->type_id, t->name);
 			return t;
 		}
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] eal/vfio: reduce severity of startup messages
  2020-06-12  0:10 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
@ 2020-06-12  9:07   ` Burakov, Anatoly
  2020-07-07 11:54     ` David Marchand
  0 siblings, 1 reply; 4+ messages in thread
From: Burakov, Anatoly @ 2020-06-12  9:07 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

On 12-Jun-20 1:10 AM, Stephen Hemminger wrote:
> The startup of VFIO is too noisy. Logging is expensive on some
> systems, and distracting to the user.
> 
> It should not be logging at NOTICE level, reduce it to INFO level.
> It really should be DEBUG here but that would hide it by default.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

No objections. They're important for trouble-shooting, but we can always 
use --log-level in that case.

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] eal/vfio: reduce severity of startup messages
  2020-06-12  9:07   ` Burakov, Anatoly
@ 2020-07-07 11:54     ` David Marchand
  0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-07-07 11:54 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Burakov, Anatoly

On Fri, Jun 12, 2020 at 11:07 AM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 12-Jun-20 1:10 AM, Stephen Hemminger wrote:
> > The startup of VFIO is too noisy. Logging is expensive on some
> > systems, and distracting to the user.
> >
> > It should not be logging at NOTICE level, reduce it to INFO level.
> > It really should be DEBUG here but that would hide it by default.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-07 11:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 18:40 [dpdk-dev] [PATCH] eal/vfio: reduce severity of startup messages Stephen Hemminger
2020-06-12  0:10 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-06-12  9:07   ` Burakov, Anatoly
2020-07-07 11:54     ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git