From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 850ECA00BE; Fri, 12 Jun 2020 05:49:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 056321BF87; Fri, 12 Jun 2020 05:46:42 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B15791BF7B for ; Fri, 12 Jun 2020 05:46:39 +0200 (CEST) IronPort-SDR: AMK9butWFdDansXEzTTNA0rzNCi+ytLLSzAbHv78DCKT1KGxK2+7Yewuh+1fomG8SQ1on891qn 5uHpJ1RJEf9A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 20:46:39 -0700 IronPort-SDR: AsexCuHTCECdLwM+RBVmFwln4Hm3ErEmx7K6Iy18LtPEf81+tFacq+KoQtkc0WuWA5VH6QL2yS 9mzoqz3BCsBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="289759597" Received: from intel.sh.intel.com ([10.239.255.18]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:37 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Guinan Sun , Todd Fujinaka Date: Fri, 12 Jun 2020 03:24:08 +0000 Message-Id: <20200612032410.20864-20-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200612032410.20864-1-guinanx.sun@intel.com> References: <20200612032410.20864-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH 19/21] net/ixgbe/base: remove default advertising for 2.5G and 5G X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We are seeing interoperability issues with switches when 2.5G and 5G are advertised by default, so default to off. LINUX ONLY: We will need to add a note to our README on how to enable 2.5G and 5G. The netwmask is a combination of: 0x020 1000baseT Full 0x800000000000 2500baseT Full 0x1000000000000 5000baseT Full 0x1000 10000baseT Full Combine the two into the advertisement flags: ethtool -s advertise ethX Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_phy.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c index f859b152e..8d4d9bbfe 100644 --- a/drivers/net/ixgbe/base/ixgbe_phy.c +++ b/drivers/net/ixgbe/base/ixgbe_phy.c @@ -915,10 +915,6 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw) hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL; switch (hw->mac.type) { - case ixgbe_mac_X550: - hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL; - hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL; - break; case ixgbe_mac_X550EM_x: case ixgbe_mac_X550EM_a: hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL; -- 2.17.1