From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, Kevin Traynor <ktraynor@redhat.com>
Subject: [dpdk-dev] [PATCH] test/eal: check invalid cpu value
Date: Fri, 12 Jun 2020 13:09:59 +0100 [thread overview]
Message-ID: <20200612120959.25626-1-ktraynor@redhat.com> (raw)
When using --lcores option, CPU_SETSIZE allows a range of
0-1023. Check it is not being exceeded.
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test/test_eal_flags.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 4ee809e3d..044cc1c59 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -528,4 +528,7 @@ test_missing_c_flag(void)
"--lcores",
"0-1,2@(5-7),(3-5)@(0,2),(0,6),7"};
+ /* check an invalid cpu value >= CPU_SETSIZE */
+ const char * const argv30[] = { prgname, prefix, mp_flag,
+ "--lcores", "3@1024" };
if (launch_proc(argv2) != 0) {
@@ -577,5 +580,6 @@ test_missing_c_flag(void)
launch_proc(argv24) == 0 || launch_proc(argv25) == 0 ||
launch_proc(argv26) == 0 || launch_proc(argv27) == 0 ||
- launch_proc(argv28) == 0) {
+ launch_proc(argv28) == 0 || launch_proc(argv30) == 0) {
+
printf("Error - "
"process ran without error with invalid --lcore flag\n");
--
2.21.3
next reply other threads:[~2020-06-12 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200612121031eucas1p2e5d39ccf4ebc398d4b4655fb9f5ac6e1@eucas1p2.samsung.com>
2020-06-12 12:09 ` Kevin Traynor [this message]
2020-07-08 23:04 ` Lukasz Wojciechowski
2020-07-20 10:20 ` Kevin Traynor
2020-07-20 10:17 ` Kevin Traynor
2020-07-20 10:19 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
2020-07-20 11:08 ` Lukasz Wojciechowski
2020-07-21 18:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612120959.25626-1-ktraynor@redhat.com \
--to=ktraynor@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).