DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@gmail.com>
To: dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, patrick.keroulas@radio-canada.ca
Subject: Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps
Date: Tue, 16 Jun 2020 15:02:51 -0400	[thread overview]
Message-ID: <20200616150251.GB120813@t480s.localdomain> (raw)
In-Reply-To: <20200610193938.218768-1-vivien.didelot@gmail.com>

Hi Ferruh,

On Wed, 10 Jun 2020 15:39:38 -0400, Vivien Didelot <vivien.didelot@gmail.com> wrote:
> When hardware timestamping is enabled on Rx path, system time should
> no longer be used to calculate the timestamps when dumping packets.
> 
> Instead, use the value stored by the driver in mbuf->timestamp
> and assume it is already converted to nanoseconds (otherwise the
> application may edit the packet headers itself afterwards).
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Patrick Keroulas <patrick.keroulas@radio-canada.ca>

Any feedback on this patch?


Thank you,

	Vivien

  reply	other threads:[~2020-06-17  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 19:39 Vivien Didelot
2020-06-16 19:02 ` Vivien Didelot [this message]
2020-06-17  8:16 ` Ferruh Yigit
2020-06-23 22:10   ` Vivien Didelot
2020-06-25 16:35     ` Olivier Matz
2020-06-25 18:49       ` Vivien Didelot
2020-06-26 13:52         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200616150251.GB120813@t480s.localdomain \
    --to=vivien.didelot@gmail.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=patrick.keroulas@radio-canada.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).