From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A64AA04A5; Wed, 17 Jun 2020 10:47:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 410F51E2B; Wed, 17 Jun 2020 10:47:23 +0200 (CEST) Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by dpdk.org (Postfix) with ESMTP id 5EAB81BFA1 for ; Tue, 16 Jun 2020 21:02:54 +0200 (CEST) Received: by mail-qv1-f68.google.com with SMTP id cv17so10015407qvb.13 for ; Tue, 16 Jun 2020 12:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=3XYrkrs8uNKK6p5xWVM3TbBqJg6+PzHwcAeOpvGKmeQ=; b=e2/W/v/M2bEdUraPUGXxxdAtCuMC4rIhRvKkyRozOb+/VySFNFqkSrGoeex3JQ0T4A cxSTT5QmO/v/YfY0l3EAtbNXoKzA3VHE5IFLceZSMWQGBD99p394psAXhMkVpp/Oe0VP IoeEW2+JTyBLIAVGoVSOg9bioNrDHrNOyOdkxwF4Ys0ojxUArZhA+/7mbZsyo3xkB2Ie kx5IkvPyeitpyEzXatKvGOYoSypZtyTx1TvCtoFbt1P+Lt4MWpTzNY25gupom/no9+Wk OZWquJ38RQxWxv3CPJa8DV9JKnzpC8p8zs+G2TA06OgkRR+geq2LA0Fot0t28gUa8h5o lhxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=3XYrkrs8uNKK6p5xWVM3TbBqJg6+PzHwcAeOpvGKmeQ=; b=MGlCM2ncBc+7Io7U7J5OpRT9p+YvqdWMy1EOUbWP+Q7g8pcJkjoAB86pCHVf2igNOV TWBFMxeZgRR/oyCH5bVOaGyuj+UrbP7+Lho0MK1n207/Ifr4OjyBmJVvA4zWwidvFzG2 cRErldf2AqDqzQ9pQQN3oWNnVFEGk+M60wDqWusK4BLzN4DFjs9sQ4othsL0HIANCHLY Qmn71+DBJzR8DXsSqvRFllnRcY/OEHbg2kC6K8C+fzKf/1vlSCEo7rBIG+UWKZ2fcs6H bxizgRsVJHjcMVRvHeeg0iyUWYQWoZzZpFuCcaA4g9ka2qaOIHrC2OwQB5rm00dXHd+/ zXuA== X-Gm-Message-State: AOAM532Lsg6PBelQDcjsiRA7pVUenyAfDV/cgtctHIU8HH8nQu9RMokL 0D7CiR+KFlPu+vRVBtsV9r8nDeat X-Google-Smtp-Source: ABdhPJy+w+MX0NOc09y91rqAM4N5WtQjm9gO3HTvpqI24QlW72DiXeCyMXLAIUcW7ccD7uVMSgw9HQ== X-Received: by 2002:a0c:f388:: with SMTP id i8mr3865900qvk.224.1592334173442; Tue, 16 Jun 2020 12:02:53 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id i3sm14433905qkf.39.2020.06.16.12.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 12:02:52 -0700 (PDT) Date: Tue, 16 Jun 2020 15:02:51 -0400 Message-ID: <20200616150251.GB120813@t480s.localdomain> From: Vivien Didelot To: dev@dpdk.org Cc: Ferruh Yigit , patrick.keroulas@radio-canada.ca In-Reply-To: <20200610193938.218768-1-vivien.didelot@gmail.com> References: <20200610193938.218768-1-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 17 Jun 2020 10:47:22 +0200 Subject: Re: [dpdk-dev] [PATCH] net/pcap: support hardware Tx timestamps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On Wed, 10 Jun 2020 15:39:38 -0400, Vivien Didelot wrote: > When hardware timestamping is enabled on Rx path, system time should > no longer be used to calculate the timestamps when dumping packets. > > Instead, use the value stored by the driver in mbuf->timestamp > and assume it is already converted to nanoseconds (otherwise the > application may edit the packet headers itself afterwards). > > Signed-off-by: Vivien Didelot > Signed-off-by: Patrick Keroulas Any feedback on this patch? Thank you, Vivien