It seems to be a typo Signed-off-by: Sergey Lvov <log0div0@gmail.com> --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 612a64599..3ef0df84a 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) if (internals->slaves[i].port_id == internals->current_primary_port) { if (rte_eth_dev_default_mac_addr_set( - internals->primary_port, + internals->current_primary_port, bonded_eth_dev->data->mac_addrs)) { RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", internals->current_primary_port); -- 2.17.1
Yes, this does look like a typo on someone's part. Please change use net/bonding: instead of pmd_bond: Please add a Fixes: line Please add a Cc: stable@dpdk.org On 6/17/20 3:02 PM, Sergey Lvov wrote: > It seems to be a typo > > Signed-off-by: Sergey Lvov <log0div0@gmail.com> > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 612a64599..3ef0df84a 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev *bonded_eth_dev) > if (internals->slaves[i].port_id == > internals->current_primary_port) { > if (rte_eth_dev_default_mac_addr_set( > - internals->primary_port, > + internals->current_primary_port, > bonded_eth_dev->data->mac_addrs)) { > RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address", > internals->current_primary_port); >
Hi, Chas Williams & Sergey Lvov There was a two-patch series about bonding those are still in reviewing state, and the one of them includes the identical modification. Thanks. http://patches.dpdk.org/patch/68742/ The series include two patches: http://patches.dpdk.org/patch/68742/ http://patches.dpdk.org/patch/68743/ Best Regards Xavier On 2020/6/19 4:32, Chas Williams wrote: > Yes, this does look like a typo on someone's part. > > Please change use net/bonding: instead of pmd_bond: > Please add a Fixes: line > Please add a Cc: stable@dpdk.org > > On 6/17/20 3:02 PM, Sergey Lvov wrote: > > It seems to be a typo > > > > Signed-off-by: Sergey Lvov <log0div0@gmail.com> > > --- > > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c > b/drivers/net/bonding/rte_eth_bond_pmd.c > > index 612a64599..3ef0df84a 100644 > > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev > *bonded_eth_dev) > > if (internals->slaves[i].port_id == > > internals->current_primary_port) { > > if (rte_eth_dev_default_mac_addr_set( > > - internals->primary_port, > > + internals->current_primary_port, > > bonded_eth_dev->data->mac_addrs)) { > > RTE_BOND_LOG(ERR, "Failed to update port Id %d > MAC address", > > internals->current_primary_port); > > >
Hi, Sergey Lvov There was a two-patch series about bonding those are still in reviewing state, and the one of them includes the identical modification. http://patches.dpdk.org/patch/68742/ Would you like to review it and give 'Signed-off-by' on the patch if there are no object? Thanks, Xavier On 2020/6/19 9:19, Wei Hu (Xavier) wrote: > Hi, Chas Williams & Sergey Lvov > > There was a two-patch series about bonding those are still in > reviewing state, > > and the one of them includes the identical modification. Thanks. > > http://patches.dpdk.org/patch/68742/ > > > The series include two patches: > http://patches.dpdk.org/patch/68742/ > http://patches.dpdk.org/patch/68743/ > > Best Regards > Xavier > > > On 2020/6/19 4:32, Chas Williams wrote: >> Yes, this does look like a typo on someone's part. >> >> Please change use net/bonding: instead of pmd_bond: >> Please add a Fixes: line >> Please add a Cc: stable@dpdk.org >> >> On 6/17/20 3:02 PM, Sergey Lvov wrote: >> > It seems to be a typo >> > >> > Signed-off-by: Sergey Lvov <log0div0@gmail.com> >> > --- >> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c >> b/drivers/net/bonding/rte_eth_bond_pmd.c >> > index 612a64599..3ef0df84a 100644 >> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c >> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev >> *bonded_eth_dev) >> > if (internals->slaves[i].port_id == >> > internals->current_primary_port) { >> > if (rte_eth_dev_default_mac_addr_set( >> > - internals->primary_port, >> > + internals->current_primary_port, >> > bonded_eth_dev->data->mac_addrs)) { >> > RTE_BOND_LOG(ERR, "Failed to update port Id >> %d MAC address", >> > internals->current_primary_port); >> > >> >
Hi, Sergey Lvov Thanks for you reporting issues, The identical modification had been applied to dpdk-next-net. http://patches.dpdk.org/patch/68742/ repo: http://dpdk.org/git/next/dpdk-next-net f109ce2c5c6b114f533ffcb69460385ac04db215 net/bonding: fix MAC address when switching active port Could you like to 'Signed-off-by' on the patch if there are no object? Thanks, Xavier On 2020/7/11 18:01, Wei Hu (Xavier) wrote: > > Hi, Sergey Lvov > > > There was a two-patch series about bonding those are still in > reviewing state, > > and the one of them includes the identical modification. > > http://patches.dpdk.org/patch/68742/ > > Would you like to review it and give 'Signed-off-by' on the patch if > there are no object? > > Thanks, Xavier > > > On 2020/6/19 9:19, Wei Hu (Xavier) wrote: >> Hi, Chas Williams & Sergey Lvov >> >> There was a two-patch series about bonding those are still in >> reviewing state, >> >> and the one of them includes the identical modification. Thanks. >> >> http://patches.dpdk.org/patch/68742/ >> >> >> The series include two patches: >> http://patches.dpdk.org/patch/68742/ >> http://patches.dpdk.org/patch/68743/ >> >> Best Regards >> Xavier >> >> >> On 2020/6/19 4:32, Chas Williams wrote: >>> Yes, this does look like a typo on someone's part. >>> >>> Please change use net/bonding: instead of pmd_bond: >>> Please add a Fixes: line >>> Please add a Cc: stable@dpdk.org >>> >>> On 6/17/20 3:02 PM, Sergey Lvov wrote: >>> > It seems to be a typo >>> > >>> > Signed-off-by: Sergey Lvov <log0div0@gmail.com> >>> > --- >>> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- >>> > 1 file changed, 1 insertion(+), 1 deletion(-) >>> > >>> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c >>> b/drivers/net/bonding/rte_eth_bond_pmd.c >>> > index 612a64599..3ef0df84a 100644 >>> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c >>> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >>> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev >>> *bonded_eth_dev) >>> > if (internals->slaves[i].port_id == >>> > internals->current_primary_port) { >>> > if (rte_eth_dev_default_mac_addr_set( >>> > - internals->primary_port, >>> > + internals->current_primary_port, >>> > bonded_eth_dev->data->mac_addrs)) { >>> > RTE_BOND_LOG(ERR, "Failed to update port Id >>> %d MAC address", >>> > internals->current_primary_port); >>> > >>> >> >