* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-26 12:53 Kevin Traynor
@ 2020-06-28 3:51 ` Chen, BoX C
2020-06-29 9:03 ` Kevin Traynor
2020-06-28 5:42 ` Pei Zhang
` (3 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Chen, BoX C @ 2020-06-28 3:51 UTC (permalink / raw)
To: Kevin Traynor, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Stokes, Ian,
Jerin Jacob, Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi,
Pei Zhang, Yu, PingX, Xu, Qian Q, Raslan Darawsheh,
Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan
Hi, Kevin
Update LTS 18.11.9 test result for Intel part. All passed and no new issue is found.
* Intel(R) Testing
# Basic Intel(R) NIC testing
* PF(i40e):Passed
* PF(ixgbe):Passed
* VF(i40e):Passed
* Build or compile: Passed
* Intel NIC single core/NIC performance: Passed
#Basic cryptodev and virtio testing
* vhost/virtio basic loopback, PVP and performance test: Passed.
* cryptodev Function: Passed.
* cryptodev Performance: Passed.
known unstable issue of test case 1c1t 3CPM. not effect LTS release.
Thanks.
Regards,
Chen Bo
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: June 26, 2020 20:53
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
> Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.9 (LTS) patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for LTS release 18.11.9.
>
> The planned date for the final release is 3rd July.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>
> These patches are located at branch 18.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> rc2:
> Creating this to include important VF fix.
> http://inbox.dpdk.org/dev/20200625035046.19820-1-
> haiyue.wang@intel.com/
>
> New patches in rc2:
> 145bb0e780 bus/pci: fix VF memory access
> 420a437247 net/tap: fix mbuf double free when writev fails
>
> Thanks.
>
> Kevin.
>
> ---
> Adam Dybkowski (2):
> app/crypto-perf: fix display of sample test vector
> cryptodev: fix SHA-1 digest enum comment
>
> Ajit Khaparde (3):
> net/bnxt: fix FW version query
> net/bnxt: fix error log for command timeout
> net/bnxt: fix using RSS config struct
>
> Alex Kiselev (1):
> lpm6: fix size of tbl8 group
>
> Alexander Kozyrev (1):
> net/mlx5: fix Tx queue release debug log timing
>
> Alvin Zhang (1):
> net/e1000: fix port hotplug for multi-process
>
> Amit Gupta (1):
> net/octeontx: fix meson build for disabled drivers
>
> Andrew Rybchenko (1):
> net/sfc: fix reported promiscuous/multicast mode
>
> Apeksha Gupta (1):
> bus/fslmc: fix dereferencing null pointer
>
> Arek Kusztal (1):
> crypto/qat: fix cipher descriptor for ZUC and SNOW
>
> Bing Zhao (1):
> mem: fix overflow on allocation
>
> Bruce Richardson (1):
> drivers: fix log type variables for -fno-common
>
> Cheng Peng (1):
> net/iavf: fix stats query error code
>
> Darek Stojaczyk (1):
> pci: accept 32-bit domain numbers
>
> David Christensen (2):
> pci: fix build on ppc
> eal/ppc: fix build with gcc 9.3
>
> David Marchand (4):
> mem: mark pages as not accessed when reserving VA
> eal: fix typo in endian conversion macros
> remove references to private PCI probe function
> doc: prefer https when pointing to dpdk.org
>
> Dekel Peled (2):
> net/mlx5: fix mask used for IPv6 item validation
> net/mlx5: fix CVLAN tag set in IP item translation
>
> Eugeny Parshutin (1):
> ethdev: fix build when vtune profiling is on
>
> Fan Zhang (1):
> vhost/crypto: add missing user protocol flag
>
> Ferruh Yigit (3):
> net/null: fix secondary burst function selection
> net/null: remove redundant check
> examples/kni: fix crash during MTU set
>
> Gaetan Rivet (4):
> doc: fix number of failsafe sub-devices
> net/ring: fix device pointer on allocation
> pci: reject negative values in PCI id
> kvargs: fix strcmp helper documentation
>
> Gavin Hu (1):
> net/i40e: relax barrier in Tx for NEON
>
> Guinan Sun (2):
> net/ixgbe: fix statistics in flow control mode
> net/ixgbe: check driver type in MACsec API
>
> Haifeng Lin (1):
> eal/arm64: fix precise TSC
>
> Haiyue Wang (1):
> bus/pci: fix VF memory access
>
> Harry van Haaren (3):
> service: fix crash on exit
> examples/eventdev: fix crash on exit
> test/flow_classify: enable multi-sockets system
>
> Hemant Agrawal (3):
> drivers: add crypto as dependency for event drivers
> bus/fslmc: fix size of qman fq descriptor
> mempool/dpaa2: install missing header with meson
>
> Honnappa Nagarahalli (2):
> service: fix race condition for MT unsafe service
> service: fix identification of service running on other lcore
>
> Igor Chauskin (2):
> net/ena/base: make allocation macros thread-safe
> net/ena/base: prevent allocation of zero sized memory
>
> Igor Romanov (7):
> net/sfc: fix initialization error path
> net/sfc: fix Rx queue start failure path
> net/sfc/base: reduce filter priorities to implemented only
> net/sfc/base: reject automatic filter creation by users
> net/sfc/base: refactor filter lookup loop in EF10
> net/sfc/base: handle manual and auto filter clashes in EF10
> net/sfc/base: fix manual filter delete in EF10
>
> Itsuro Oda (2):
> net/vhost: fix potential memory leak on close
> vhost: make IOTLB cache name unique among processes
>
> Ivan Dyukov (3):
> net/virtio-user: fix devargs parsing
> app: remove extra new line after link duplex
> examples: remove extra new line after link duplex
>
> Jasvinder Singh (3):
> net/softnic: fix memory leak for thread
> net/softnic: fix resource leak for pipeline
> examples/ip_pipeline: remove check of null response
>
> Jeff Guo (2):
> net/i40e: fix setting L2TAG
> net/iavf: fix setting L2TAG
>
> Jim Harris (1):
> contigmem: cleanup properly when load fails
>
> Junyu Jiang (2):
> examples/vmdq: fix output of pools/queues
> examples/vmdq: fix RSS configuration
>
> Kalesh AP (2):
> net/bnxt: fix VLAN add when port is stopped
> app/testpmd: fix memory failure handling for i40e DDP
>
> Kevin Traynor (14):
> kni: fix ethtool build with kernel 5.6
> net/avp: fix gcc 10 maybe-uninitialized warning
> eal/x86: ignore gcc 10 stringop-overflow warnings
> crypto/kasumi: fix extern declaration
> build: disable gcc 10 zero-length-bounds warning
> kni: fix ethtool dev_open build error
> kni: fix ethtool pointer type build error
> drivers/crypto: disable gcc 10 fno-common errors
> kni: fix gcc 10 ethtool build error
> kni: fix ethtool maybe-uninitialized warnings
> crypto/octeontx: fix gcc 10 -fno-common build errors
> app/testpmd: disable gcc 10 -fno-common build errors
> examples/vm_power: fix build because of missing include
> version: 18.11.9-rc1
>
> Konstantin Ananyev (1):
> security: fix crash at accessing non-implemented ops
>
> Li Feng (1):
> mem: mark pages as not accessed when freeing memory
>
> Louise Kilheeney (1):
> examples/l2fwd-keepalive: fix mbuf pool size
>
> Luca Boccassi (2):
> fix various typos found by Lintian
> usertools: check for pci.ids in /usr/share/misc
>
> Lukasz Wojciechowski (5):
> drivers/crypto: fix log type variables for -fno-common
> security: fix verification of parameters
> security: fix return types in documentation
> security: fix session counter
> test: remove redundant macro
>
> Mattias Rönnblom (3):
> event/dsw: remove redundant control ring poll
> event/dsw: remove unnecessary read barrier
> event/dsw: avoid reusing previously recorded events
>
> Michael Baum (1):
> net/mlx4: fix drop queue error handling
>
> Michael Haeuptle (1):
> vfio: fix race condition with sysfs
>
> Michal Krawczyk (5):
> net/ena/base: fix testing for supported hash function
> net/ena/base: fix documentation of functions
> net/ena/base: fix indentation in CQ polling
> net/ena/base: fix indentation of multiple defines
> net/ena: set IO ring size to valid value
>
> Muhammad Bilal (2):
> fix same typo in multiple places
> doc: fix typo in contributors guide
>
> Nicolas Chautru (1):
> bbdev: fix doxygen comments
>
> Nithin Dabilpuram (1):
> devtools: fix symbol map change check
>
> Olivier Matz (3):
> test/kvargs: fix to consider empty elements as valid
> test/kvargs: fix invalid cases check
> kvargs: fix invalid token parsing on FreeBSD
>
> Pablo de Lara (3):
> test/crypto: fix flag check
> crypto/openssl: fix out-of-place encryption
> doc: add NASM installation steps
>
> Pavan Nikhilesh (2):
> eventdev: fix probe and remove for secondary process
> app/eventdev: check Tx adapter service ID
>
> Phil Yang (1):
> service: remove rte prefix from static functions
>
> Qiming Yang (3):
> net/i40e: fix X722 performance
> doc: fix multicast filter feature announcement
> net/i40e: fix queue related exception handling
>
> Rasesh Mody (3):
> net/qede: fix link state configuration
> net/qede: fix port reconfiguration
> examples/kni: fix MTU change to setup Tx queue
>
> Raslan Darawsheh (3):
> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
> app/testpmd: add parsing for QinQ VLAN headers
> net/mlx5: fix matching for UDP tunnels with Verbs
>
> Rohit Raj (1):
> net/dpaa2: fix 10G port negotiation
>
> Roland Qi (1):
> vhost: fix peer close check
>
> Ruifeng Wang (1):
> test: skip some subtests in no-huge mode
>
> Sarosh Arif (1):
> doc: fix typo in contributors guide
>
> Somnath Kotur (1):
> bus/pci: fix devargs on probing again
>
> Stephen Hemminger (21):
> ethdev: fix spelling
> net/mvneta: do not use PMD log type
> net/virtio: do not use PMD log type
> net/tap: do not use PMD log type
> net/bnxt: do not use PMD log type
> net/dpaa: use dynamic log type
> net/thunderx: use dynamic log type
> net/netvsc: propagate descriptor limits from VF
> net/netvsc: handle Rx packets during multi-channel setup
> net/netvsc: split send buffers from Tx descriptors
> net/netvsc: fix memory free on device close
> net/netvsc: remove process event optimization
> net/netvsc: handle Tx completions based on burst size
> net/netvsc: avoid possible live lock
> lpm6: fix comments spelling
> eal: fix comments spelling
> net/netvsc: fix comment spelling
> bus/vmbus: fix comment spelling
> net/tap: fix crash in flow destroy
> eal: fix C++17 compilation
> net/vmxnet3: handle bad host framing
>
> Sunil Kumar Kori (1):
> eal: fix log message print for regex
>
> Thomas Monjalon (11):
> doc: fix sphinx compatibility
> log: fix level picked with globbing on type register
> doc: fix matrix CSS for recent sphinx
> net/mlx4: fix build with -fno-common
> app: fix usage help of options separated by dashes
> net/mvpp2: fix build with gcc 10
> examples/vm_power: drop Unix path limit redefinition
> doc: fix build with doxygen 1.8.18
> doc: fix API index
> mlx5: fix build with -fno-common
> examples/vm_power: fix build with -fno-common
>
> Timothy Redaelli (3):
> app/pipeline: fix build with gcc 10
> examples/eventdev: fix build with gcc 10
> crypto/octeontx: fix build with gcc 10
>
> Ting Xu (1):
> app/testpmd: fix DCB set
>
> Vijaya Mohan Guvva (1):
> bus/pci: fix UIO resource access from secondary process
>
> Wei Hu (Xavier) (2):
> vfio: fix use after free with multiprocess
> app/testpmd: fix statistics after reset
>
> Wei Zhao (4):
> net/i40e: fix flow director for ARP packets
> doc: add i40e limitation for flow director
> net/i40e: fix flush of flow director filter
> net/i40e: fix wild pointer
>
> Xiaolong Ye (3):
> net/virtio: fix outdated comment
> vhost: remove unused variable
> doc: fix log level example in Linux guide
>
> Xiaoyu Min (1):
> net/mlx5: fix RSS enablement
>
> Xiaoyun Li (2):
> net/ixgbe/base: update copyright
> net/i40e/base: update copyright
>
> Xuan Ding (2):
> vhost: prevent zero-copy with incompatible client mode
> vhost: fix zero-copy server mode
>
> Yunjian Wang (14):
> kvargs: fix buffer overflow when parsing list
> net/tap: remove unused assert
> net/tap: fix mbuf and mem leak during queue release
> net/tap: fix check for mbuf number of segment
> net/tap: fix file close on remove
> net/tap: fix fd leak on creation failure
> net/tap: fix unexpected link handler
> net/tap: fix queues fd check before close
> net/octeontx: fix dangling pointer on init failure
> crypto/ccp: fix fd leak on probe failure
> net/failsafe: fix fd leak
> crypto/caam_jr: fix check of file descriptors
> crypto/caam_jr: fix IRQ functions return type
> net/tap: fix mbuf double free when writev fails
>
> Yuri Chipchev (1):
> event/dsw: fix enqueue burst return value
>
> Zhihong Peng (1):
> net/ixgbe: fix link status synchronization on BSD
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-28 3:51 ` Chen, BoX C
@ 2020-06-29 9:03 ` Kevin Traynor
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Traynor @ 2020-06-29 9:03 UTC (permalink / raw)
To: Chen, BoX C, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Stokes, Ian,
Jerin Jacob, Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi,
Pei Zhang, Yu, PingX, Xu, Qian Q, Raslan Darawsheh,
Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan
On 28/06/2020 04:51, Chen, BoX C wrote:
> Hi, Kevin
> Update LTS 18.11.9 test result for Intel part. All passed and no new issue is found.
>
> * Intel(R) Testing
>
> # Basic Intel(R) NIC testing
> * PF(i40e):Passed
> * PF(ixgbe):Passed
> * VF(i40e):Passed
> * Build or compile: Passed
> * Intel NIC single core/NIC performance: Passed
>
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Passed.
> * cryptodev Function: Passed.
> * cryptodev Performance: Passed.
> known unstable issue of test case 1c1t 3CPM. not effect LTS release.
>
> Thanks.
>
> Regards,
> Chen Bo
>
Thanks for the report Chen Bo.
Kevin.
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: June 26, 2020 20:53
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
>> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
>> <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
>> Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: 18.11.9 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.9.
>>
>> The planned date for the final release is 3rd July.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>> https://dpdk.org/browse/dpdk-stable/
>>
>> rc2:
>> Creating this to include important VF fix.
>> http://inbox.dpdk.org/dev/20200625035046.19820-1-
>> haiyue.wang@intel.com/
>>
>> New patches in rc2:
>> 145bb0e780 bus/pci: fix VF memory access
>> 420a437247 net/tap: fix mbuf double free when writev fails
>>
>> Thanks.
>>
>> Kevin.
>>
>> ---
>> Adam Dybkowski (2):
>> app/crypto-perf: fix display of sample test vector
>> cryptodev: fix SHA-1 digest enum comment
>>
>> Ajit Khaparde (3):
>> net/bnxt: fix FW version query
>> net/bnxt: fix error log for command timeout
>> net/bnxt: fix using RSS config struct
>>
>> Alex Kiselev (1):
>> lpm6: fix size of tbl8 group
>>
>> Alexander Kozyrev (1):
>> net/mlx5: fix Tx queue release debug log timing
>>
>> Alvin Zhang (1):
>> net/e1000: fix port hotplug for multi-process
>>
>> Amit Gupta (1):
>> net/octeontx: fix meson build for disabled drivers
>>
>> Andrew Rybchenko (1):
>> net/sfc: fix reported promiscuous/multicast mode
>>
>> Apeksha Gupta (1):
>> bus/fslmc: fix dereferencing null pointer
>>
>> Arek Kusztal (1):
>> crypto/qat: fix cipher descriptor for ZUC and SNOW
>>
>> Bing Zhao (1):
>> mem: fix overflow on allocation
>>
>> Bruce Richardson (1):
>> drivers: fix log type variables for -fno-common
>>
>> Cheng Peng (1):
>> net/iavf: fix stats query error code
>>
>> Darek Stojaczyk (1):
>> pci: accept 32-bit domain numbers
>>
>> David Christensen (2):
>> pci: fix build on ppc
>> eal/ppc: fix build with gcc 9.3
>>
>> David Marchand (4):
>> mem: mark pages as not accessed when reserving VA
>> eal: fix typo in endian conversion macros
>> remove references to private PCI probe function
>> doc: prefer https when pointing to dpdk.org
>>
>> Dekel Peled (2):
>> net/mlx5: fix mask used for IPv6 item validation
>> net/mlx5: fix CVLAN tag set in IP item translation
>>
>> Eugeny Parshutin (1):
>> ethdev: fix build when vtune profiling is on
>>
>> Fan Zhang (1):
>> vhost/crypto: add missing user protocol flag
>>
>> Ferruh Yigit (3):
>> net/null: fix secondary burst function selection
>> net/null: remove redundant check
>> examples/kni: fix crash during MTU set
>>
>> Gaetan Rivet (4):
>> doc: fix number of failsafe sub-devices
>> net/ring: fix device pointer on allocation
>> pci: reject negative values in PCI id
>> kvargs: fix strcmp helper documentation
>>
>> Gavin Hu (1):
>> net/i40e: relax barrier in Tx for NEON
>>
>> Guinan Sun (2):
>> net/ixgbe: fix statistics in flow control mode
>> net/ixgbe: check driver type in MACsec API
>>
>> Haifeng Lin (1):
>> eal/arm64: fix precise TSC
>>
>> Haiyue Wang (1):
>> bus/pci: fix VF memory access
>>
>> Harry van Haaren (3):
>> service: fix crash on exit
>> examples/eventdev: fix crash on exit
>> test/flow_classify: enable multi-sockets system
>>
>> Hemant Agrawal (3):
>> drivers: add crypto as dependency for event drivers
>> bus/fslmc: fix size of qman fq descriptor
>> mempool/dpaa2: install missing header with meson
>>
>> Honnappa Nagarahalli (2):
>> service: fix race condition for MT unsafe service
>> service: fix identification of service running on other lcore
>>
>> Igor Chauskin (2):
>> net/ena/base: make allocation macros thread-safe
>> net/ena/base: prevent allocation of zero sized memory
>>
>> Igor Romanov (7):
>> net/sfc: fix initialization error path
>> net/sfc: fix Rx queue start failure path
>> net/sfc/base: reduce filter priorities to implemented only
>> net/sfc/base: reject automatic filter creation by users
>> net/sfc/base: refactor filter lookup loop in EF10
>> net/sfc/base: handle manual and auto filter clashes in EF10
>> net/sfc/base: fix manual filter delete in EF10
>>
>> Itsuro Oda (2):
>> net/vhost: fix potential memory leak on close
>> vhost: make IOTLB cache name unique among processes
>>
>> Ivan Dyukov (3):
>> net/virtio-user: fix devargs parsing
>> app: remove extra new line after link duplex
>> examples: remove extra new line after link duplex
>>
>> Jasvinder Singh (3):
>> net/softnic: fix memory leak for thread
>> net/softnic: fix resource leak for pipeline
>> examples/ip_pipeline: remove check of null response
>>
>> Jeff Guo (2):
>> net/i40e: fix setting L2TAG
>> net/iavf: fix setting L2TAG
>>
>> Jim Harris (1):
>> contigmem: cleanup properly when load fails
>>
>> Junyu Jiang (2):
>> examples/vmdq: fix output of pools/queues
>> examples/vmdq: fix RSS configuration
>>
>> Kalesh AP (2):
>> net/bnxt: fix VLAN add when port is stopped
>> app/testpmd: fix memory failure handling for i40e DDP
>>
>> Kevin Traynor (14):
>> kni: fix ethtool build with kernel 5.6
>> net/avp: fix gcc 10 maybe-uninitialized warning
>> eal/x86: ignore gcc 10 stringop-overflow warnings
>> crypto/kasumi: fix extern declaration
>> build: disable gcc 10 zero-length-bounds warning
>> kni: fix ethtool dev_open build error
>> kni: fix ethtool pointer type build error
>> drivers/crypto: disable gcc 10 fno-common errors
>> kni: fix gcc 10 ethtool build error
>> kni: fix ethtool maybe-uninitialized warnings
>> crypto/octeontx: fix gcc 10 -fno-common build errors
>> app/testpmd: disable gcc 10 -fno-common build errors
>> examples/vm_power: fix build because of missing include
>> version: 18.11.9-rc1
>>
>> Konstantin Ananyev (1):
>> security: fix crash at accessing non-implemented ops
>>
>> Li Feng (1):
>> mem: mark pages as not accessed when freeing memory
>>
>> Louise Kilheeney (1):
>> examples/l2fwd-keepalive: fix mbuf pool size
>>
>> Luca Boccassi (2):
>> fix various typos found by Lintian
>> usertools: check for pci.ids in /usr/share/misc
>>
>> Lukasz Wojciechowski (5):
>> drivers/crypto: fix log type variables for -fno-common
>> security: fix verification of parameters
>> security: fix return types in documentation
>> security: fix session counter
>> test: remove redundant macro
>>
>> Mattias Rönnblom (3):
>> event/dsw: remove redundant control ring poll
>> event/dsw: remove unnecessary read barrier
>> event/dsw: avoid reusing previously recorded events
>>
>> Michael Baum (1):
>> net/mlx4: fix drop queue error handling
>>
>> Michael Haeuptle (1):
>> vfio: fix race condition with sysfs
>>
>> Michal Krawczyk (5):
>> net/ena/base: fix testing for supported hash function
>> net/ena/base: fix documentation of functions
>> net/ena/base: fix indentation in CQ polling
>> net/ena/base: fix indentation of multiple defines
>> net/ena: set IO ring size to valid value
>>
>> Muhammad Bilal (2):
>> fix same typo in multiple places
>> doc: fix typo in contributors guide
>>
>> Nicolas Chautru (1):
>> bbdev: fix doxygen comments
>>
>> Nithin Dabilpuram (1):
>> devtools: fix symbol map change check
>>
>> Olivier Matz (3):
>> test/kvargs: fix to consider empty elements as valid
>> test/kvargs: fix invalid cases check
>> kvargs: fix invalid token parsing on FreeBSD
>>
>> Pablo de Lara (3):
>> test/crypto: fix flag check
>> crypto/openssl: fix out-of-place encryption
>> doc: add NASM installation steps
>>
>> Pavan Nikhilesh (2):
>> eventdev: fix probe and remove for secondary process
>> app/eventdev: check Tx adapter service ID
>>
>> Phil Yang (1):
>> service: remove rte prefix from static functions
>>
>> Qiming Yang (3):
>> net/i40e: fix X722 performance
>> doc: fix multicast filter feature announcement
>> net/i40e: fix queue related exception handling
>>
>> Rasesh Mody (3):
>> net/qede: fix link state configuration
>> net/qede: fix port reconfiguration
>> examples/kni: fix MTU change to setup Tx queue
>>
>> Raslan Darawsheh (3):
>> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
>> app/testpmd: add parsing for QinQ VLAN headers
>> net/mlx5: fix matching for UDP tunnels with Verbs
>>
>> Rohit Raj (1):
>> net/dpaa2: fix 10G port negotiation
>>
>> Roland Qi (1):
>> vhost: fix peer close check
>>
>> Ruifeng Wang (1):
>> test: skip some subtests in no-huge mode
>>
>> Sarosh Arif (1):
>> doc: fix typo in contributors guide
>>
>> Somnath Kotur (1):
>> bus/pci: fix devargs on probing again
>>
>> Stephen Hemminger (21):
>> ethdev: fix spelling
>> net/mvneta: do not use PMD log type
>> net/virtio: do not use PMD log type
>> net/tap: do not use PMD log type
>> net/bnxt: do not use PMD log type
>> net/dpaa: use dynamic log type
>> net/thunderx: use dynamic log type
>> net/netvsc: propagate descriptor limits from VF
>> net/netvsc: handle Rx packets during multi-channel setup
>> net/netvsc: split send buffers from Tx descriptors
>> net/netvsc: fix memory free on device close
>> net/netvsc: remove process event optimization
>> net/netvsc: handle Tx completions based on burst size
>> net/netvsc: avoid possible live lock
>> lpm6: fix comments spelling
>> eal: fix comments spelling
>> net/netvsc: fix comment spelling
>> bus/vmbus: fix comment spelling
>> net/tap: fix crash in flow destroy
>> eal: fix C++17 compilation
>> net/vmxnet3: handle bad host framing
>>
>> Sunil Kumar Kori (1):
>> eal: fix log message print for regex
>>
>> Thomas Monjalon (11):
>> doc: fix sphinx compatibility
>> log: fix level picked with globbing on type register
>> doc: fix matrix CSS for recent sphinx
>> net/mlx4: fix build with -fno-common
>> app: fix usage help of options separated by dashes
>> net/mvpp2: fix build with gcc 10
>> examples/vm_power: drop Unix path limit redefinition
>> doc: fix build with doxygen 1.8.18
>> doc: fix API index
>> mlx5: fix build with -fno-common
>> examples/vm_power: fix build with -fno-common
>>
>> Timothy Redaelli (3):
>> app/pipeline: fix build with gcc 10
>> examples/eventdev: fix build with gcc 10
>> crypto/octeontx: fix build with gcc 10
>>
>> Ting Xu (1):
>> app/testpmd: fix DCB set
>>
>> Vijaya Mohan Guvva (1):
>> bus/pci: fix UIO resource access from secondary process
>>
>> Wei Hu (Xavier) (2):
>> vfio: fix use after free with multiprocess
>> app/testpmd: fix statistics after reset
>>
>> Wei Zhao (4):
>> net/i40e: fix flow director for ARP packets
>> doc: add i40e limitation for flow director
>> net/i40e: fix flush of flow director filter
>> net/i40e: fix wild pointer
>>
>> Xiaolong Ye (3):
>> net/virtio: fix outdated comment
>> vhost: remove unused variable
>> doc: fix log level example in Linux guide
>>
>> Xiaoyu Min (1):
>> net/mlx5: fix RSS enablement
>>
>> Xiaoyun Li (2):
>> net/ixgbe/base: update copyright
>> net/i40e/base: update copyright
>>
>> Xuan Ding (2):
>> vhost: prevent zero-copy with incompatible client mode
>> vhost: fix zero-copy server mode
>>
>> Yunjian Wang (14):
>> kvargs: fix buffer overflow when parsing list
>> net/tap: remove unused assert
>> net/tap: fix mbuf and mem leak during queue release
>> net/tap: fix check for mbuf number of segment
>> net/tap: fix file close on remove
>> net/tap: fix fd leak on creation failure
>> net/tap: fix unexpected link handler
>> net/tap: fix queues fd check before close
>> net/octeontx: fix dangling pointer on init failure
>> crypto/ccp: fix fd leak on probe failure
>> net/failsafe: fix fd leak
>> crypto/caam_jr: fix check of file descriptors
>> crypto/caam_jr: fix IRQ functions return type
>> net/tap: fix mbuf double free when writev fails
>>
>> Yuri Chipchev (1):
>> event/dsw: fix enqueue burst return value
>>
>> Zhihong Peng (1):
>> net/ixgbe: fix link status synchronization on BSD
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-26 12:53 Kevin Traynor
2020-06-28 3:51 ` Chen, BoX C
@ 2020-06-28 5:42 ` Pei Zhang
2020-06-29 9:04 ` Kevin Traynor
2020-06-30 8:54 ` Ali Alnubani
` (2 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Pei Zhang @ 2020-06-28 5:42 UTC (permalink / raw)
To: Kevin Traynor
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin walker, David Christensen, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Luca Boccassi,
pingx yu, qian q xu, Raslan Darawsheh, Thomas Monjalon,
yuan peng, zhaoyan chen
Hi Kevin,
Testing with dpdk 18.11.9-rc2 from Red Hat looks good.
We cover below 13 scenarios and and all get PASS on RHEL8 testing:
(1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
(7)Guest with vhost-user 2 queues throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)PVP 1Q live migration testing: PASS
(10)PVP 1Q cross numa node live migration testing: PASS
(11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
Versions:
kernel 4.18
qemu 5.0
dpdk: git://dpdk.org/dpdk-stable remotes/origin/18.11
# git log -1
commit 7afca2cda1555a3ca551269f90c1d768b9f5ac20 (HEAD, tag: v18.11.9-rc2, origin/18.11)
Author: Kevin Traynor <ktraynor@redhat.com>
Date: Fri Jun 26 11:35:46 2020 +0100
version: 18.11.9-rc2
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
NICs: X540-AT2 NIC(ixgbe, 10G)
Best regards,
Pei
----- Original Message -----
From: "Kevin Traynor" <ktraynor@redhat.com>
To: stable@dpdk.org
Cc: dev@dpdk.org, "Abhishek Marathe" <Abhishek.Marathe@microsoft.com>, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen" <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>, "Kevin Traynor" <ktraynor@redhat.com>, "Luca Boccassi" <bluca@debian.org>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
Sent: Friday, June 26, 2020 8:53:06 PM
Subject: 18.11.9 (LTS) patches review and test
Hi all,
Here is a list of patches targeted for LTS release 18.11.9.
The planned date for the final release is 3rd July.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
These patches are located at branch 18.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
rc2:
Creating this to include important VF fix.
http://inbox.dpdk.org/dev/20200625035046.19820-1-haiyue.wang@intel.com/
New patches in rc2:
145bb0e780 bus/pci: fix VF memory access
420a437247 net/tap: fix mbuf double free when writev fails
Thanks.
Kevin.
---
Adam Dybkowski (2):
app/crypto-perf: fix display of sample test vector
cryptodev: fix SHA-1 digest enum comment
Ajit Khaparde (3):
net/bnxt: fix FW version query
net/bnxt: fix error log for command timeout
net/bnxt: fix using RSS config struct
Alex Kiselev (1):
lpm6: fix size of tbl8 group
Alexander Kozyrev (1):
net/mlx5: fix Tx queue release debug log timing
Alvin Zhang (1):
net/e1000: fix port hotplug for multi-process
Amit Gupta (1):
net/octeontx: fix meson build for disabled drivers
Andrew Rybchenko (1):
net/sfc: fix reported promiscuous/multicast mode
Apeksha Gupta (1):
bus/fslmc: fix dereferencing null pointer
Arek Kusztal (1):
crypto/qat: fix cipher descriptor for ZUC and SNOW
Bing Zhao (1):
mem: fix overflow on allocation
Bruce Richardson (1):
drivers: fix log type variables for -fno-common
Cheng Peng (1):
net/iavf: fix stats query error code
Darek Stojaczyk (1):
pci: accept 32-bit domain numbers
David Christensen (2):
pci: fix build on ppc
eal/ppc: fix build with gcc 9.3
David Marchand (4):
mem: mark pages as not accessed when reserving VA
eal: fix typo in endian conversion macros
remove references to private PCI probe function
doc: prefer https when pointing to dpdk.org
Dekel Peled (2):
net/mlx5: fix mask used for IPv6 item validation
net/mlx5: fix CVLAN tag set in IP item translation
Eugeny Parshutin (1):
ethdev: fix build when vtune profiling is on
Fan Zhang (1):
vhost/crypto: add missing user protocol flag
Ferruh Yigit (3):
net/null: fix secondary burst function selection
net/null: remove redundant check
examples/kni: fix crash during MTU set
Gaetan Rivet (4):
doc: fix number of failsafe sub-devices
net/ring: fix device pointer on allocation
pci: reject negative values in PCI id
kvargs: fix strcmp helper documentation
Gavin Hu (1):
net/i40e: relax barrier in Tx for NEON
Guinan Sun (2):
net/ixgbe: fix statistics in flow control mode
net/ixgbe: check driver type in MACsec API
Haifeng Lin (1):
eal/arm64: fix precise TSC
Haiyue Wang (1):
bus/pci: fix VF memory access
Harry van Haaren (3):
service: fix crash on exit
examples/eventdev: fix crash on exit
test/flow_classify: enable multi-sockets system
Hemant Agrawal (3):
drivers: add crypto as dependency for event drivers
bus/fslmc: fix size of qman fq descriptor
mempool/dpaa2: install missing header with meson
Honnappa Nagarahalli (2):
service: fix race condition for MT unsafe service
service: fix identification of service running on other lcore
Igor Chauskin (2):
net/ena/base: make allocation macros thread-safe
net/ena/base: prevent allocation of zero sized memory
Igor Romanov (7):
net/sfc: fix initialization error path
net/sfc: fix Rx queue start failure path
net/sfc/base: reduce filter priorities to implemented only
net/sfc/base: reject automatic filter creation by users
net/sfc/base: refactor filter lookup loop in EF10
net/sfc/base: handle manual and auto filter clashes in EF10
net/sfc/base: fix manual filter delete in EF10
Itsuro Oda (2):
net/vhost: fix potential memory leak on close
vhost: make IOTLB cache name unique among processes
Ivan Dyukov (3):
net/virtio-user: fix devargs parsing
app: remove extra new line after link duplex
examples: remove extra new line after link duplex
Jasvinder Singh (3):
net/softnic: fix memory leak for thread
net/softnic: fix resource leak for pipeline
examples/ip_pipeline: remove check of null response
Jeff Guo (2):
net/i40e: fix setting L2TAG
net/iavf: fix setting L2TAG
Jim Harris (1):
contigmem: cleanup properly when load fails
Junyu Jiang (2):
examples/vmdq: fix output of pools/queues
examples/vmdq: fix RSS configuration
Kalesh AP (2):
net/bnxt: fix VLAN add when port is stopped
app/testpmd: fix memory failure handling for i40e DDP
Kevin Traynor (14):
kni: fix ethtool build with kernel 5.6
net/avp: fix gcc 10 maybe-uninitialized warning
eal/x86: ignore gcc 10 stringop-overflow warnings
crypto/kasumi: fix extern declaration
build: disable gcc 10 zero-length-bounds warning
kni: fix ethtool dev_open build error
kni: fix ethtool pointer type build error
drivers/crypto: disable gcc 10 fno-common errors
kni: fix gcc 10 ethtool build error
kni: fix ethtool maybe-uninitialized warnings
crypto/octeontx: fix gcc 10 -fno-common build errors
app/testpmd: disable gcc 10 -fno-common build errors
examples/vm_power: fix build because of missing include
version: 18.11.9-rc1
Konstantin Ananyev (1):
security: fix crash at accessing non-implemented ops
Li Feng (1):
mem: mark pages as not accessed when freeing memory
Louise Kilheeney (1):
examples/l2fwd-keepalive: fix mbuf pool size
Luca Boccassi (2):
fix various typos found by Lintian
usertools: check for pci.ids in /usr/share/misc
Lukasz Wojciechowski (5):
drivers/crypto: fix log type variables for -fno-common
security: fix verification of parameters
security: fix return types in documentation
security: fix session counter
test: remove redundant macro
Mattias Rönnblom (3):
event/dsw: remove redundant control ring poll
event/dsw: remove unnecessary read barrier
event/dsw: avoid reusing previously recorded events
Michael Baum (1):
net/mlx4: fix drop queue error handling
Michael Haeuptle (1):
vfio: fix race condition with sysfs
Michal Krawczyk (5):
net/ena/base: fix testing for supported hash function
net/ena/base: fix documentation of functions
net/ena/base: fix indentation in CQ polling
net/ena/base: fix indentation of multiple defines
net/ena: set IO ring size to valid value
Muhammad Bilal (2):
fix same typo in multiple places
doc: fix typo in contributors guide
Nicolas Chautru (1):
bbdev: fix doxygen comments
Nithin Dabilpuram (1):
devtools: fix symbol map change check
Olivier Matz (3):
test/kvargs: fix to consider empty elements as valid
test/kvargs: fix invalid cases check
kvargs: fix invalid token parsing on FreeBSD
Pablo de Lara (3):
test/crypto: fix flag check
crypto/openssl: fix out-of-place encryption
doc: add NASM installation steps
Pavan Nikhilesh (2):
eventdev: fix probe and remove for secondary process
app/eventdev: check Tx adapter service ID
Phil Yang (1):
service: remove rte prefix from static functions
Qiming Yang (3):
net/i40e: fix X722 performance
doc: fix multicast filter feature announcement
net/i40e: fix queue related exception handling
Rasesh Mody (3):
net/qede: fix link state configuration
net/qede: fix port reconfiguration
examples/kni: fix MTU change to setup Tx queue
Raslan Darawsheh (3):
net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
app/testpmd: add parsing for QinQ VLAN headers
net/mlx5: fix matching for UDP tunnels with Verbs
Rohit Raj (1):
net/dpaa2: fix 10G port negotiation
Roland Qi (1):
vhost: fix peer close check
Ruifeng Wang (1):
test: skip some subtests in no-huge mode
Sarosh Arif (1):
doc: fix typo in contributors guide
Somnath Kotur (1):
bus/pci: fix devargs on probing again
Stephen Hemminger (21):
ethdev: fix spelling
net/mvneta: do not use PMD log type
net/virtio: do not use PMD log type
net/tap: do not use PMD log type
net/bnxt: do not use PMD log type
net/dpaa: use dynamic log type
net/thunderx: use dynamic log type
net/netvsc: propagate descriptor limits from VF
net/netvsc: handle Rx packets during multi-channel setup
net/netvsc: split send buffers from Tx descriptors
net/netvsc: fix memory free on device close
net/netvsc: remove process event optimization
net/netvsc: handle Tx completions based on burst size
net/netvsc: avoid possible live lock
lpm6: fix comments spelling
eal: fix comments spelling
net/netvsc: fix comment spelling
bus/vmbus: fix comment spelling
net/tap: fix crash in flow destroy
eal: fix C++17 compilation
net/vmxnet3: handle bad host framing
Sunil Kumar Kori (1):
eal: fix log message print for regex
Thomas Monjalon (11):
doc: fix sphinx compatibility
log: fix level picked with globbing on type register
doc: fix matrix CSS for recent sphinx
net/mlx4: fix build with -fno-common
app: fix usage help of options separated by dashes
net/mvpp2: fix build with gcc 10
examples/vm_power: drop Unix path limit redefinition
doc: fix build with doxygen 1.8.18
doc: fix API index
mlx5: fix build with -fno-common
examples/vm_power: fix build with -fno-common
Timothy Redaelli (3):
app/pipeline: fix build with gcc 10
examples/eventdev: fix build with gcc 10
crypto/octeontx: fix build with gcc 10
Ting Xu (1):
app/testpmd: fix DCB set
Vijaya Mohan Guvva (1):
bus/pci: fix UIO resource access from secondary process
Wei Hu (Xavier) (2):
vfio: fix use after free with multiprocess
app/testpmd: fix statistics after reset
Wei Zhao (4):
net/i40e: fix flow director for ARP packets
doc: add i40e limitation for flow director
net/i40e: fix flush of flow director filter
net/i40e: fix wild pointer
Xiaolong Ye (3):
net/virtio: fix outdated comment
vhost: remove unused variable
doc: fix log level example in Linux guide
Xiaoyu Min (1):
net/mlx5: fix RSS enablement
Xiaoyun Li (2):
net/ixgbe/base: update copyright
net/i40e/base: update copyright
Xuan Ding (2):
vhost: prevent zero-copy with incompatible client mode
vhost: fix zero-copy server mode
Yunjian Wang (14):
kvargs: fix buffer overflow when parsing list
net/tap: remove unused assert
net/tap: fix mbuf and mem leak during queue release
net/tap: fix check for mbuf number of segment
net/tap: fix file close on remove
net/tap: fix fd leak on creation failure
net/tap: fix unexpected link handler
net/tap: fix queues fd check before close
net/octeontx: fix dangling pointer on init failure
crypto/ccp: fix fd leak on probe failure
net/failsafe: fix fd leak
crypto/caam_jr: fix check of file descriptors
crypto/caam_jr: fix IRQ functions return type
net/tap: fix mbuf double free when writev fails
Yuri Chipchev (1):
event/dsw: fix enqueue burst return value
Zhihong Peng (1):
net/ixgbe: fix link status synchronization on BSD
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-28 5:42 ` Pei Zhang
@ 2020-06-29 9:04 ` Kevin Traynor
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Traynor @ 2020-06-29 9:04 UTC (permalink / raw)
To: Pei Zhang
Cc: stable, dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin walker, David Christensen, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Luca Boccassi,
pingx yu, qian q xu, Raslan Darawsheh, Thomas Monjalon,
yuan peng, zhaoyan chen
On 28/06/2020 06:42, Pei Zhang wrote:
> Hi Kevin,
>
> Testing with dpdk 18.11.9-rc2 from Red Hat looks good.
>
> We cover below 13 scenarios and and all get PASS on RHEL8 testing:
>
> (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
> (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
> (3)Guest with device assignment(VF) throughput testing: PASS
> (4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
> (5)PVP vhost-user 2Q throughput testing: PASS
> (6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
> (7)Guest with vhost-user 2 queues throughput testing: PASS
> (8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
> (9)PVP 1Q live migration testing: PASS
> (10)PVP 1Q cross numa node live migration testing: PASS
> (11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
> (12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
> (13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
>
> Versions:
>
> kernel 4.18
> qemu 5.0
> dpdk: git://dpdk.org/dpdk-stable remotes/origin/18.11
>
> # git log -1
> commit 7afca2cda1555a3ca551269f90c1d768b9f5ac20 (HEAD, tag: v18.11.9-rc2, origin/18.11)
> Author: Kevin Traynor <ktraynor@redhat.com>
> Date: Fri Jun 26 11:35:46 2020 +0100
>
> version: 18.11.9-rc2
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> NICs: X540-AT2 NIC(ixgbe, 10G)
>
> Best regards,
>
> Pei
>
Thanks for testing Pei,
Kevin.
> ----- Original Message -----
> From: "Kevin Traynor" <ktraynor@redhat.com>
> To: stable@dpdk.org
> Cc: dev@dpdk.org, "Abhishek Marathe" <Abhishek.Marathe@microsoft.com>, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen" <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>, "Kevin Traynor" <ktraynor@redhat.com>, "Luca Boccassi" <bluca@debian.org>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
> Sent: Friday, June 26, 2020 8:53:06 PM
> Subject: 18.11.9 (LTS) patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for LTS release 18.11.9.
>
> The planned date for the final release is 3rd July.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>
> These patches are located at branch 18.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> rc2:
> Creating this to include important VF fix.
> http://inbox.dpdk.org/dev/20200625035046.19820-1-haiyue.wang@intel.com/
>
> New patches in rc2:
> 145bb0e780 bus/pci: fix VF memory access
> 420a437247 net/tap: fix mbuf double free when writev fails
>
> Thanks.
>
> Kevin.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-26 12:53 Kevin Traynor
2020-06-28 3:51 ` Chen, BoX C
2020-06-28 5:42 ` Pei Zhang
@ 2020-06-30 8:54 ` Ali Alnubani
2020-06-30 9:52 ` Kevin Traynor
2020-06-30 15:38 ` Govindharajan, Hariprasad
2020-07-03 17:26 ` Kevin Traynor
4 siblings, 1 reply; 16+ messages in thread
From: Ali Alnubani @ 2020-06-30 8:54 UTC (permalink / raw)
To: Kevin Traynor, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
zhaoyan.chen
Hi,
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Friday, June 26, 2020 3:53 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>;
> Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com;
> qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas
> Monjalon <thomas@monjalon.net>; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 18.11.9 (LTS) patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for LTS release 18.11.9.
>
> The planned date for the final release is 3rd July.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
We ran the following tests on Mellanox hardware for this version:
- Basic functionality:
Send and receive multiple types of traffic.
- testpmd xstats counter tests.
- testpmd timestamp tests.
- Changing/checking link status through testpmd.
- RTE flow and flow_director tests:
Items: eth / vlan / ipv4 / ipv6 / tcp / udp / gre
Actions: drop / queue / rss / mark / flag
- Some RSS tests.
- VLAN stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
Testing matrix:
- NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 14.27.1016
- NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 16.27.2008
We found 2 issues:
- Failure to restart ports with kernels newer than 5.6 (call to mmap failed on UAR for txq).
- Applications fail to start with CONFIG_RTE_LIBRTE_MLX5_DEBUG enabled (mlx5_ifindex: Assertion `priv->if_index' failed).
We are discussing these issues internally, and we see no other regressions blocking the release.
Regards,
Ali
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 8:54 ` Ali Alnubani
@ 2020-06-30 9:52 ` Kevin Traynor
2020-06-30 10:02 ` Ali Alnubani
0 siblings, 1 reply; 16+ messages in thread
From: Kevin Traynor @ 2020-06-30 9:52 UTC (permalink / raw)
To: Ali Alnubani, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
zhaoyan.chen
On 30/06/2020 09:54, Ali Alnubani wrote:
> Hi,
>
Hi Ali,
Thanks for testing.
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Friday, June 26, 2020 3:53 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
>> Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>;
>> Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com;
>> qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas
>> Monjalon <thomas@monjalon.net>; yuan.peng@intel.com;
>> zhaoyan.chen@intel.com
>> Subject: 18.11.9 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.9.
>>
>> The planned date for the final release is 3rd July.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>
> We ran the following tests on Mellanox hardware for this version:
> - Basic functionality:
> Send and receive multiple types of traffic.
> - testpmd xstats counter tests.
> - testpmd timestamp tests.
> - Changing/checking link status through testpmd.
> - RTE flow and flow_director tests:
> Items: eth / vlan / ipv4 / ipv6 / tcp / udp / gre
> Actions: drop / queue / rss / mark / flag
> - Some RSS tests.
> - VLAN stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
>
> Testing matrix:
> - NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 14.27.1016
> - NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 16.27.2008
>
> We found 2 issues:
> - Failure to restart ports with kernels newer than 5.6 (call to mmap failed on UAR for txq).
> - Applications fail to start with CONFIG_RTE_LIBRTE_MLX5_DEBUG enabled (mlx5_ifindex: Assertion `priv->if_index' failed).
Are these regressions? i.e. does 18.11.8 fail in the same way in the
same testbed
> We are discussing these issues internally, and we see no other regressions blocking the release.
>
ok, please let me know the outcome and if any patches need to be
added/removed to resolve these issues.
thanks,
Kevin.
> Regards,
> Ali
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 9:52 ` Kevin Traynor
@ 2020-06-30 10:02 ` Ali Alnubani
2020-07-10 8:53 ` Kevin Traynor
0 siblings, 1 reply; 16+ messages in thread
From: Ali Alnubani @ 2020-06-30 10:02 UTC (permalink / raw)
To: Kevin Traynor, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
zhaoyan.chen
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Tuesday, June 30, 2020 12:53 PM
> To: Ali Alnubani <alialnu@mellanox.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; benjamin.walker@intel.com; David
> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>;
> Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com;
> qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas
> Monjalon <thomas@monjalon.net>; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: Re: 18.11.9 (LTS) patches review and test
>
> On 30/06/2020 09:54, Ali Alnubani wrote:
> > Hi,
> >
>
> Hi Ali,
>
> Thanks for testing.
>
> >> -----Original Message-----
> >> From: Kevin Traynor <ktraynor@redhat.com>
> >> Sent: Friday, June 26, 2020 3:53 PM
> >> To: stable@dpdk.org
> >> Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> >> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> >> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen
> >> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> >> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> >> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
> >> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> >> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
> >> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh
> >> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>;
> >> yuan.peng@intel.com; zhaoyan.chen@intel.com
> >> Subject: 18.11.9 (LTS) patches review and test
> >>
> >> Hi all,
> >>
> >> Here is a list of patches targeted for LTS release 18.11.9.
> >>
> >> The planned date for the final release is 3rd July.
> >>
> >> Please help with testing and validation of your use cases and report
> >> any issues/results with reply-all to this mail. For the final release
> >> the fixes and reported validations will be added to the release notes.
> >>
> >
> > We ran the following tests on Mellanox hardware for this version:
> > - Basic functionality:
> > Send and receive multiple types of traffic.
> > - testpmd xstats counter tests.
> > - testpmd timestamp tests.
> > - Changing/checking link status through testpmd.
> > - RTE flow and flow_director tests:
> > Items: eth / vlan / ipv4 / ipv6 / tcp / udp / gre
> > Actions: drop / queue / rss / mark / flag
> > - Some RSS tests.
> > - VLAN stripping and insertion tests.
> > - Checksum and TSO tests.
> > - ptype tests.
> > - l3fwd-power example application tests.
> > - Multi-process example applications tests.
> >
> > Testing matrix:
> > - NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver:
> > MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 14.27.1016
> > - NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0
> > / Firmware: 16.27.2008
> >
> > We found 2 issues:
> > - Failure to restart ports with kernels newer than 5.6 (call to mmap failed on
> UAR for txq).
> > - Applications fail to start with CONFIG_RTE_LIBRTE_MLX5_DEBUG enabled
> (mlx5_ifindex: Assertion `priv->if_index' failed).
>
> Are these regressions? i.e. does 18.11.8 fail in the same way in the same
> testbed
The first issue reproduces in previous releases as well, but only with kernels newer than 5.6.
The second one seems to have started reproducing in v18.11.7, but I only noticed it while testing this release.
>
> > We are discussing these issues internally, and we see no other regressions
> blocking the release.
> >
>
> ok, please let me know the outcome and if any patches need to be
> added/removed to resolve these issues.
Will do.
>
> thanks,
> Kevin.
>
> > Regards,
> > Ali
> >
Thanks,
Ali
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 10:02 ` Ali Alnubani
@ 2020-07-10 8:53 ` Kevin Traynor
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Traynor @ 2020-07-10 8:53 UTC (permalink / raw)
To: Ali Alnubani, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, benjamin.walker,
David Christensen, Hemant Agrawal, Ian Stokes, Jerin Jacob,
John McNamara, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, pingx.yu,
qian.q.xu, Raslan Darawsheh, Thomas Monjalon, yuan.peng,
zhaoyan.chen
On 30/06/2020 11:02, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, June 30, 2020 12:53 PM
>> To: Ali Alnubani <alialnu@mellanox.com>; stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; benjamin.walker@intel.com; David
>> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
>> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
>> Ju-Hyoung Lee <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>;
>> Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com;
>> qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas
>> Monjalon <thomas@monjalon.net>; yuan.peng@intel.com;
>> zhaoyan.chen@intel.com
>> Subject: Re: 18.11.9 (LTS) patches review and test
>>
>> On 30/06/2020 09:54, Ali Alnubani wrote:
>>> Hi,
>>>
>>
>> Hi Ali,
>>
>> Thanks for testing.
>>
>>>> -----Original Message-----
>>>> From: Kevin Traynor <ktraynor@redhat.com>
>>>> Sent: Friday, June 26, 2020 3:53 PM
>>>> To: stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe
>> <Abhishek.Marathe@microsoft.com>;
>>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
>>>> <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen
>>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
>> <hemant.agrawal@nxp.com>;
>>>> Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>>>> John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee
>>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>;
>>>> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh
>>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>;
>>>> yuan.peng@intel.com; zhaoyan.chen@intel.com
>>>> Subject: 18.11.9 (LTS) patches review and test
>>>>
>>>> Hi all,
>>>>
>>>> Here is a list of patches targeted for LTS release 18.11.9.
>>>>
>>>> The planned date for the final release is 3rd July.
>>>>
>>>> Please help with testing and validation of your use cases and report
>>>> any issues/results with reply-all to this mail. For the final release
>>>> the fixes and reported validations will be added to the release notes.
>>>>
>>>
>>> We ran the following tests on Mellanox hardware for this version:
>>> - Basic functionality:
>>> Send and receive multiple types of traffic.
>>> - testpmd xstats counter tests.
>>> - testpmd timestamp tests.
>>> - Changing/checking link status through testpmd.
>>> - RTE flow and flow_director tests:
>>> Items: eth / vlan / ipv4 / ipv6 / tcp / udp / gre
>>> Actions: drop / queue / rss / mark / flag
>>> - Some RSS tests.
>>> - VLAN stripping and insertion tests.
>>> - Checksum and TSO tests.
>>> - ptype tests.
>>> - l3fwd-power example application tests.
>>> - Multi-process example applications tests.
>>>
>>> Testing matrix:
>>> - NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver:
>>> MLNX_OFED_LINUX-5.0-2.1.8.0 / Firmware: 14.27.1016
>>> - NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.0-2.1.8.0
>>> / Firmware: 16.27.2008
>>>
>>> We found 2 issues:
>>> - Failure to restart ports with kernels newer than 5.6 (call to mmap failed on
>> UAR for txq).
>>> - Applications fail to start with CONFIG_RTE_LIBRTE_MLX5_DEBUG enabled
>> (mlx5_ifindex: Assertion `priv->if_index' failed).
>>
To wrap this thread, the following series were applied for the above
issues and Ali re-ran validation.
http://inbox.dpdk.org/stable/1594105971-14738-1-git-send-email-viacheslavo@mellanox.com/
http://inbox.dpdk.org/stable/1593700670-25730-1-git-send-email-viacheslavo@mellanox.com/
>> Are these regressions? i.e. does 18.11.8 fail in the same way in the same
>> testbed
>
> The first issue reproduces in previous releases as well, but only with kernels newer than 5.6.
> The second one seems to have started reproducing in v18.11.7, but I only noticed it while testing this release.
>
>>
>>> We are discussing these issues internally, and we see no other regressions
>> blocking the release.
>>>
>>
>> ok, please let me know the outcome and if any patches need to be
>> added/removed to resolve these issues.
>
> Will do.
>
>>
>> thanks,
>> Kevin.
>>
>>> Regards,
>>> Ali
>>>
>
> Thanks,
> Ali
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-26 12:53 Kevin Traynor
` (2 preceding siblings ...)
2020-06-30 8:54 ` Ali Alnubani
@ 2020-06-30 15:38 ` Govindharajan, Hariprasad
2020-06-30 16:21 ` Kevin Traynor
2020-07-03 17:26 ` Kevin Traynor
4 siblings, 1 reply; 16+ messages in thread
From: Govindharajan, Hariprasad @ 2020-06-30 15:38 UTC (permalink / raw)
To: Kevin Traynor, stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Stokes, Ian,
Jerin Jacob, Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi,
Pei Zhang, Yu, PingX, Xu, Qian Q, Raslan Darawsheh,
Thomas Monjalon, Peng, Yuan, Chen, Zhaoyan
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Traynor
> Sent: Friday, June 26, 2020 1:53 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
> Zhaoyan <zhaoyan.chen@intel.com>
> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test
>
> Hi all,
>
> Here is a list of patches targeted for LTS release 18.11.9.
>
> The planned date for the final release is 3rd July.
>
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>
> These patches are located at branch 18.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> rc2:
> Creating this to include important VF fix.
> http://inbox.dpdk.org/dev/20200625035046.19820-1-
> haiyue.wang@intel.com/
>
> New patches in rc2:
> 145bb0e780 bus/pci: fix VF memory access
> 420a437247 net/tap: fix mbuf double free when writev fails
>
> Thanks.
>
> Kevin.
[Govindharajan, Hariprasad] Hi Kevin,
The following performance and functional tests carried out with ixgbe, i40e and vhost devices
DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12
P2p throughput
P2p multi queue
PVP rss
vHost reconnect
Flow control
Zero copy feature could not be tested.
From ovs, zero copy is used only vhost user client. So this particular patch 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy support in ovs.
so for ovs to move to support 18.11.9, it should probably remove support for zero-copy in the ovs code base?
Regards
G Hariprasad
>
> ---
> Adam Dybkowski (2):
> app/crypto-perf: fix display of sample test vector
> cryptodev: fix SHA-1 digest enum comment
>
> Ajit Khaparde (3):
> net/bnxt: fix FW version query
> net/bnxt: fix error log for command timeout
> net/bnxt: fix using RSS config struct
>
> Alex Kiselev (1):
> lpm6: fix size of tbl8 group
>
> Alexander Kozyrev (1):
> net/mlx5: fix Tx queue release debug log timing
>
> Alvin Zhang (1):
> net/e1000: fix port hotplug for multi-process
>
> Amit Gupta (1):
> net/octeontx: fix meson build for disabled drivers
>
> Andrew Rybchenko (1):
> net/sfc: fix reported promiscuous/multicast mode
>
> Apeksha Gupta (1):
> bus/fslmc: fix dereferencing null pointer
>
> Arek Kusztal (1):
> crypto/qat: fix cipher descriptor for ZUC and SNOW
>
> Bing Zhao (1):
> mem: fix overflow on allocation
>
> Bruce Richardson (1):
> drivers: fix log type variables for -fno-common
>
> Cheng Peng (1):
> net/iavf: fix stats query error code
>
> Darek Stojaczyk (1):
> pci: accept 32-bit domain numbers
>
> David Christensen (2):
> pci: fix build on ppc
> eal/ppc: fix build with gcc 9.3
>
> David Marchand (4):
> mem: mark pages as not accessed when reserving VA
> eal: fix typo in endian conversion macros
> remove references to private PCI probe function
> doc: prefer https when pointing to dpdk.org
>
> Dekel Peled (2):
> net/mlx5: fix mask used for IPv6 item validation
> net/mlx5: fix CVLAN tag set in IP item translation
>
> Eugeny Parshutin (1):
> ethdev: fix build when vtune profiling is on
>
> Fan Zhang (1):
> vhost/crypto: add missing user protocol flag
>
> Ferruh Yigit (3):
> net/null: fix secondary burst function selection
> net/null: remove redundant check
> examples/kni: fix crash during MTU set
>
> Gaetan Rivet (4):
> doc: fix number of failsafe sub-devices
> net/ring: fix device pointer on allocation
> pci: reject negative values in PCI id
> kvargs: fix strcmp helper documentation
>
> Gavin Hu (1):
> net/i40e: relax barrier in Tx for NEON
>
> Guinan Sun (2):
> net/ixgbe: fix statistics in flow control mode
> net/ixgbe: check driver type in MACsec API
>
> Haifeng Lin (1):
> eal/arm64: fix precise TSC
>
> Haiyue Wang (1):
> bus/pci: fix VF memory access
>
> Harry van Haaren (3):
> service: fix crash on exit
> examples/eventdev: fix crash on exit
> test/flow_classify: enable multi-sockets system
>
> Hemant Agrawal (3):
> drivers: add crypto as dependency for event drivers
> bus/fslmc: fix size of qman fq descriptor
> mempool/dpaa2: install missing header with meson
>
> Honnappa Nagarahalli (2):
> service: fix race condition for MT unsafe service
> service: fix identification of service running on other lcore
>
> Igor Chauskin (2):
> net/ena/base: make allocation macros thread-safe
> net/ena/base: prevent allocation of zero sized memory
>
> Igor Romanov (7):
> net/sfc: fix initialization error path
> net/sfc: fix Rx queue start failure path
> net/sfc/base: reduce filter priorities to implemented only
> net/sfc/base: reject automatic filter creation by users
> net/sfc/base: refactor filter lookup loop in EF10
> net/sfc/base: handle manual and auto filter clashes in EF10
> net/sfc/base: fix manual filter delete in EF10
>
> Itsuro Oda (2):
> net/vhost: fix potential memory leak on close
> vhost: make IOTLB cache name unique among processes
>
> Ivan Dyukov (3):
> net/virtio-user: fix devargs parsing
> app: remove extra new line after link duplex
> examples: remove extra new line after link duplex
>
> Jasvinder Singh (3):
> net/softnic: fix memory leak for thread
> net/softnic: fix resource leak for pipeline
> examples/ip_pipeline: remove check of null response
>
> Jeff Guo (2):
> net/i40e: fix setting L2TAG
> net/iavf: fix setting L2TAG
>
> Jim Harris (1):
> contigmem: cleanup properly when load fails
>
> Junyu Jiang (2):
> examples/vmdq: fix output of pools/queues
> examples/vmdq: fix RSS configuration
>
> Kalesh AP (2):
> net/bnxt: fix VLAN add when port is stopped
> app/testpmd: fix memory failure handling for i40e DDP
>
> Kevin Traynor (14):
> kni: fix ethtool build with kernel 5.6
> net/avp: fix gcc 10 maybe-uninitialized warning
> eal/x86: ignore gcc 10 stringop-overflow warnings
> crypto/kasumi: fix extern declaration
> build: disable gcc 10 zero-length-bounds warning
> kni: fix ethtool dev_open build error
> kni: fix ethtool pointer type build error
> drivers/crypto: disable gcc 10 fno-common errors
> kni: fix gcc 10 ethtool build error
> kni: fix ethtool maybe-uninitialized warnings
> crypto/octeontx: fix gcc 10 -fno-common build errors
> app/testpmd: disable gcc 10 -fno-common build errors
> examples/vm_power: fix build because of missing include
> version: 18.11.9-rc1
>
> Konstantin Ananyev (1):
> security: fix crash at accessing non-implemented ops
>
> Li Feng (1):
> mem: mark pages as not accessed when freeing memory
>
> Louise Kilheeney (1):
> examples/l2fwd-keepalive: fix mbuf pool size
>
> Luca Boccassi (2):
> fix various typos found by Lintian
> usertools: check for pci.ids in /usr/share/misc
>
> Lukasz Wojciechowski (5):
> drivers/crypto: fix log type variables for -fno-common
> security: fix verification of parameters
> security: fix return types in documentation
> security: fix session counter
> test: remove redundant macro
>
> Mattias Rönnblom (3):
> event/dsw: remove redundant control ring poll
> event/dsw: remove unnecessary read barrier
> event/dsw: avoid reusing previously recorded events
>
> Michael Baum (1):
> net/mlx4: fix drop queue error handling
>
> Michael Haeuptle (1):
> vfio: fix race condition with sysfs
>
> Michal Krawczyk (5):
> net/ena/base: fix testing for supported hash function
> net/ena/base: fix documentation of functions
> net/ena/base: fix indentation in CQ polling
> net/ena/base: fix indentation of multiple defines
> net/ena: set IO ring size to valid value
>
> Muhammad Bilal (2):
> fix same typo in multiple places
> doc: fix typo in contributors guide
>
> Nicolas Chautru (1):
> bbdev: fix doxygen comments
>
> Nithin Dabilpuram (1):
> devtools: fix symbol map change check
>
> Olivier Matz (3):
> test/kvargs: fix to consider empty elements as valid
> test/kvargs: fix invalid cases check
> kvargs: fix invalid token parsing on FreeBSD
>
> Pablo de Lara (3):
> test/crypto: fix flag check
> crypto/openssl: fix out-of-place encryption
> doc: add NASM installation steps
>
> Pavan Nikhilesh (2):
> eventdev: fix probe and remove for secondary process
> app/eventdev: check Tx adapter service ID
>
> Phil Yang (1):
> service: remove rte prefix from static functions
>
> Qiming Yang (3):
> net/i40e: fix X722 performance
> doc: fix multicast filter feature announcement
> net/i40e: fix queue related exception handling
>
> Rasesh Mody (3):
> net/qede: fix link state configuration
> net/qede: fix port reconfiguration
> examples/kni: fix MTU change to setup Tx queue
>
> Raslan Darawsheh (3):
> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
> app/testpmd: add parsing for QinQ VLAN headers
> net/mlx5: fix matching for UDP tunnels with Verbs
>
> Rohit Raj (1):
> net/dpaa2: fix 10G port negotiation
>
> Roland Qi (1):
> vhost: fix peer close check
>
> Ruifeng Wang (1):
> test: skip some subtests in no-huge mode
>
> Sarosh Arif (1):
> doc: fix typo in contributors guide
>
> Somnath Kotur (1):
> bus/pci: fix devargs on probing again
>
> Stephen Hemminger (21):
> ethdev: fix spelling
> net/mvneta: do not use PMD log type
> net/virtio: do not use PMD log type
> net/tap: do not use PMD log type
> net/bnxt: do not use PMD log type
> net/dpaa: use dynamic log type
> net/thunderx: use dynamic log type
> net/netvsc: propagate descriptor limits from VF
> net/netvsc: handle Rx packets during multi-channel setup
> net/netvsc: split send buffers from Tx descriptors
> net/netvsc: fix memory free on device close
> net/netvsc: remove process event optimization
> net/netvsc: handle Tx completions based on burst size
> net/netvsc: avoid possible live lock
> lpm6: fix comments spelling
> eal: fix comments spelling
> net/netvsc: fix comment spelling
> bus/vmbus: fix comment spelling
> net/tap: fix crash in flow destroy
> eal: fix C++17 compilation
> net/vmxnet3: handle bad host framing
>
> Sunil Kumar Kori (1):
> eal: fix log message print for regex
>
> Thomas Monjalon (11):
> doc: fix sphinx compatibility
> log: fix level picked with globbing on type register
> doc: fix matrix CSS for recent sphinx
> net/mlx4: fix build with -fno-common
> app: fix usage help of options separated by dashes
> net/mvpp2: fix build with gcc 10
> examples/vm_power: drop Unix path limit redefinition
> doc: fix build with doxygen 1.8.18
> doc: fix API index
> mlx5: fix build with -fno-common
> examples/vm_power: fix build with -fno-common
>
> Timothy Redaelli (3):
> app/pipeline: fix build with gcc 10
> examples/eventdev: fix build with gcc 10
> crypto/octeontx: fix build with gcc 10
>
> Ting Xu (1):
> app/testpmd: fix DCB set
>
> Vijaya Mohan Guvva (1):
> bus/pci: fix UIO resource access from secondary process
>
> Wei Hu (Xavier) (2):
> vfio: fix use after free with multiprocess
> app/testpmd: fix statistics after reset
>
> Wei Zhao (4):
> net/i40e: fix flow director for ARP packets
> doc: add i40e limitation for flow director
> net/i40e: fix flush of flow director filter
> net/i40e: fix wild pointer
>
> Xiaolong Ye (3):
> net/virtio: fix outdated comment
> vhost: remove unused variable
> doc: fix log level example in Linux guide
>
> Xiaoyu Min (1):
> net/mlx5: fix RSS enablement
>
> Xiaoyun Li (2):
> net/ixgbe/base: update copyright
> net/i40e/base: update copyright
>
> Xuan Ding (2):
> vhost: prevent zero-copy with incompatible client mode
> vhost: fix zero-copy server mode
>
> Yunjian Wang (14):
> kvargs: fix buffer overflow when parsing list
> net/tap: remove unused assert
> net/tap: fix mbuf and mem leak during queue release
> net/tap: fix check for mbuf number of segment
> net/tap: fix file close on remove
> net/tap: fix fd leak on creation failure
> net/tap: fix unexpected link handler
> net/tap: fix queues fd check before close
> net/octeontx: fix dangling pointer on init failure
> crypto/ccp: fix fd leak on probe failure
> net/failsafe: fix fd leak
> crypto/caam_jr: fix check of file descriptors
> crypto/caam_jr: fix IRQ functions return type
> net/tap: fix mbuf double free when writev fails
>
> Yuri Chipchev (1):
> event/dsw: fix enqueue burst return value
>
> Zhihong Peng (1):
> net/ixgbe: fix link status synchronization on BSD
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 15:38 ` Govindharajan, Hariprasad
@ 2020-06-30 16:21 ` Kevin Traynor
2020-06-30 16:32 ` Stokes, Ian
0 siblings, 1 reply; 16+ messages in thread
From: Kevin Traynor @ 2020-06-30 16:21 UTC (permalink / raw)
To: Govindharajan, Hariprasad, stable, Stokes, Ian, ciara.loftus
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Yu,
PingX, Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan,
Chen, Zhaoyan
On 30/06/2020 16:38, Govindharajan, Hariprasad wrote:
>
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Traynor
>> Sent: Friday, June 26, 2020 1:53 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
>> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
>> Darawsheh <rasland@mellanox.com>; Thomas Monjalon
>> <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
>> Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.9.
>>
>> The planned date for the final release is 3rd July.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>> https://dpdk.org/browse/dpdk-stable/
>>
>> rc2:
>> Creating this to include important VF fix.
>> http://inbox.dpdk.org/dev/20200625035046.19820-1-
>> haiyue.wang@intel.com/
>>
>> New patches in rc2:
>> 145bb0e780 bus/pci: fix VF memory access
>> 420a437247 net/tap: fix mbuf double free when writev fails
>>
>> Thanks.
>>
>> Kevin.
> [Govindharajan, Hariprasad] Hi Kevin,
>
Hi G Hariprasad,
Thanks for testing.
> The following performance and functional tests carried out with ixgbe, i40e and vhost devices
>
> DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12
>
> P2p throughput
> P2p multi queue
> PVP rss
> vHost reconnect
> Flow control
>
> Zero copy feature could not be tested.
> From ovs, zero copy is used only vhost user client. So this particular patch 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy support in ovs.
> so for ovs to move to support 18.11.9, it should probably remove support for zero-copy in the ovs code base?
>
The code says that zero copy is incompatible with vhost client mode.
It seems that the check for client/server was incorrect, and now it is
fixed and correctly detects this incompatible combination and returns an
error to OVS.
I don't think we can call that breaking. It was previously incompatible
also, it just didn't return an error as there was a bug.
I don't see an issue with having this patch and the new behaviour.
Ian/Ciara, let me know if I'm missing something.
thanks,
Kevin.
> Regards
> G Hariprasad
>>
>> ---
>> Adam Dybkowski (2):
>> app/crypto-perf: fix display of sample test vector
>> cryptodev: fix SHA-1 digest enum comment
>>
>> Ajit Khaparde (3):
>> net/bnxt: fix FW version query
>> net/bnxt: fix error log for command timeout
>> net/bnxt: fix using RSS config struct
>>
>> Alex Kiselev (1):
>> lpm6: fix size of tbl8 group
>>
>> Alexander Kozyrev (1):
>> net/mlx5: fix Tx queue release debug log timing
>>
>> Alvin Zhang (1):
>> net/e1000: fix port hotplug for multi-process
>>
>> Amit Gupta (1):
>> net/octeontx: fix meson build for disabled drivers
>>
>> Andrew Rybchenko (1):
>> net/sfc: fix reported promiscuous/multicast mode
>>
>> Apeksha Gupta (1):
>> bus/fslmc: fix dereferencing null pointer
>>
>> Arek Kusztal (1):
>> crypto/qat: fix cipher descriptor for ZUC and SNOW
>>
>> Bing Zhao (1):
>> mem: fix overflow on allocation
>>
>> Bruce Richardson (1):
>> drivers: fix log type variables for -fno-common
>>
>> Cheng Peng (1):
>> net/iavf: fix stats query error code
>>
>> Darek Stojaczyk (1):
>> pci: accept 32-bit domain numbers
>>
>> David Christensen (2):
>> pci: fix build on ppc
>> eal/ppc: fix build with gcc 9.3
>>
>> David Marchand (4):
>> mem: mark pages as not accessed when reserving VA
>> eal: fix typo in endian conversion macros
>> remove references to private PCI probe function
>> doc: prefer https when pointing to dpdk.org
>>
>> Dekel Peled (2):
>> net/mlx5: fix mask used for IPv6 item validation
>> net/mlx5: fix CVLAN tag set in IP item translation
>>
>> Eugeny Parshutin (1):
>> ethdev: fix build when vtune profiling is on
>>
>> Fan Zhang (1):
>> vhost/crypto: add missing user protocol flag
>>
>> Ferruh Yigit (3):
>> net/null: fix secondary burst function selection
>> net/null: remove redundant check
>> examples/kni: fix crash during MTU set
>>
>> Gaetan Rivet (4):
>> doc: fix number of failsafe sub-devices
>> net/ring: fix device pointer on allocation
>> pci: reject negative values in PCI id
>> kvargs: fix strcmp helper documentation
>>
>> Gavin Hu (1):
>> net/i40e: relax barrier in Tx for NEON
>>
>> Guinan Sun (2):
>> net/ixgbe: fix statistics in flow control mode
>> net/ixgbe: check driver type in MACsec API
>>
>> Haifeng Lin (1):
>> eal/arm64: fix precise TSC
>>
>> Haiyue Wang (1):
>> bus/pci: fix VF memory access
>>
>> Harry van Haaren (3):
>> service: fix crash on exit
>> examples/eventdev: fix crash on exit
>> test/flow_classify: enable multi-sockets system
>>
>> Hemant Agrawal (3):
>> drivers: add crypto as dependency for event drivers
>> bus/fslmc: fix size of qman fq descriptor
>> mempool/dpaa2: install missing header with meson
>>
>> Honnappa Nagarahalli (2):
>> service: fix race condition for MT unsafe service
>> service: fix identification of service running on other lcore
>>
>> Igor Chauskin (2):
>> net/ena/base: make allocation macros thread-safe
>> net/ena/base: prevent allocation of zero sized memory
>>
>> Igor Romanov (7):
>> net/sfc: fix initialization error path
>> net/sfc: fix Rx queue start failure path
>> net/sfc/base: reduce filter priorities to implemented only
>> net/sfc/base: reject automatic filter creation by users
>> net/sfc/base: refactor filter lookup loop in EF10
>> net/sfc/base: handle manual and auto filter clashes in EF10
>> net/sfc/base: fix manual filter delete in EF10
>>
>> Itsuro Oda (2):
>> net/vhost: fix potential memory leak on close
>> vhost: make IOTLB cache name unique among processes
>>
>> Ivan Dyukov (3):
>> net/virtio-user: fix devargs parsing
>> app: remove extra new line after link duplex
>> examples: remove extra new line after link duplex
>>
>> Jasvinder Singh (3):
>> net/softnic: fix memory leak for thread
>> net/softnic: fix resource leak for pipeline
>> examples/ip_pipeline: remove check of null response
>>
>> Jeff Guo (2):
>> net/i40e: fix setting L2TAG
>> net/iavf: fix setting L2TAG
>>
>> Jim Harris (1):
>> contigmem: cleanup properly when load fails
>>
>> Junyu Jiang (2):
>> examples/vmdq: fix output of pools/queues
>> examples/vmdq: fix RSS configuration
>>
>> Kalesh AP (2):
>> net/bnxt: fix VLAN add when port is stopped
>> app/testpmd: fix memory failure handling for i40e DDP
>>
>> Kevin Traynor (14):
>> kni: fix ethtool build with kernel 5.6
>> net/avp: fix gcc 10 maybe-uninitialized warning
>> eal/x86: ignore gcc 10 stringop-overflow warnings
>> crypto/kasumi: fix extern declaration
>> build: disable gcc 10 zero-length-bounds warning
>> kni: fix ethtool dev_open build error
>> kni: fix ethtool pointer type build error
>> drivers/crypto: disable gcc 10 fno-common errors
>> kni: fix gcc 10 ethtool build error
>> kni: fix ethtool maybe-uninitialized warnings
>> crypto/octeontx: fix gcc 10 -fno-common build errors
>> app/testpmd: disable gcc 10 -fno-common build errors
>> examples/vm_power: fix build because of missing include
>> version: 18.11.9-rc1
>>
>> Konstantin Ananyev (1):
>> security: fix crash at accessing non-implemented ops
>>
>> Li Feng (1):
>> mem: mark pages as not accessed when freeing memory
>>
>> Louise Kilheeney (1):
>> examples/l2fwd-keepalive: fix mbuf pool size
>>
>> Luca Boccassi (2):
>> fix various typos found by Lintian
>> usertools: check for pci.ids in /usr/share/misc
>>
>> Lukasz Wojciechowski (5):
>> drivers/crypto: fix log type variables for -fno-common
>> security: fix verification of parameters
>> security: fix return types in documentation
>> security: fix session counter
>> test: remove redundant macro
>>
>> Mattias Rönnblom (3):
>> event/dsw: remove redundant control ring poll
>> event/dsw: remove unnecessary read barrier
>> event/dsw: avoid reusing previously recorded events
>>
>> Michael Baum (1):
>> net/mlx4: fix drop queue error handling
>>
>> Michael Haeuptle (1):
>> vfio: fix race condition with sysfs
>>
>> Michal Krawczyk (5):
>> net/ena/base: fix testing for supported hash function
>> net/ena/base: fix documentation of functions
>> net/ena/base: fix indentation in CQ polling
>> net/ena/base: fix indentation of multiple defines
>> net/ena: set IO ring size to valid value
>>
>> Muhammad Bilal (2):
>> fix same typo in multiple places
>> doc: fix typo in contributors guide
>>
>> Nicolas Chautru (1):
>> bbdev: fix doxygen comments
>>
>> Nithin Dabilpuram (1):
>> devtools: fix symbol map change check
>>
>> Olivier Matz (3):
>> test/kvargs: fix to consider empty elements as valid
>> test/kvargs: fix invalid cases check
>> kvargs: fix invalid token parsing on FreeBSD
>>
>> Pablo de Lara (3):
>> test/crypto: fix flag check
>> crypto/openssl: fix out-of-place encryption
>> doc: add NASM installation steps
>>
>> Pavan Nikhilesh (2):
>> eventdev: fix probe and remove for secondary process
>> app/eventdev: check Tx adapter service ID
>>
>> Phil Yang (1):
>> service: remove rte prefix from static functions
>>
>> Qiming Yang (3):
>> net/i40e: fix X722 performance
>> doc: fix multicast filter feature announcement
>> net/i40e: fix queue related exception handling
>>
>> Rasesh Mody (3):
>> net/qede: fix link state configuration
>> net/qede: fix port reconfiguration
>> examples/kni: fix MTU change to setup Tx queue
>>
>> Raslan Darawsheh (3):
>> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
>> app/testpmd: add parsing for QinQ VLAN headers
>> net/mlx5: fix matching for UDP tunnels with Verbs
>>
>> Rohit Raj (1):
>> net/dpaa2: fix 10G port negotiation
>>
>> Roland Qi (1):
>> vhost: fix peer close check
>>
>> Ruifeng Wang (1):
>> test: skip some subtests in no-huge mode
>>
>> Sarosh Arif (1):
>> doc: fix typo in contributors guide
>>
>> Somnath Kotur (1):
>> bus/pci: fix devargs on probing again
>>
>> Stephen Hemminger (21):
>> ethdev: fix spelling
>> net/mvneta: do not use PMD log type
>> net/virtio: do not use PMD log type
>> net/tap: do not use PMD log type
>> net/bnxt: do not use PMD log type
>> net/dpaa: use dynamic log type
>> net/thunderx: use dynamic log type
>> net/netvsc: propagate descriptor limits from VF
>> net/netvsc: handle Rx packets during multi-channel setup
>> net/netvsc: split send buffers from Tx descriptors
>> net/netvsc: fix memory free on device close
>> net/netvsc: remove process event optimization
>> net/netvsc: handle Tx completions based on burst size
>> net/netvsc: avoid possible live lock
>> lpm6: fix comments spelling
>> eal: fix comments spelling
>> net/netvsc: fix comment spelling
>> bus/vmbus: fix comment spelling
>> net/tap: fix crash in flow destroy
>> eal: fix C++17 compilation
>> net/vmxnet3: handle bad host framing
>>
>> Sunil Kumar Kori (1):
>> eal: fix log message print for regex
>>
>> Thomas Monjalon (11):
>> doc: fix sphinx compatibility
>> log: fix level picked with globbing on type register
>> doc: fix matrix CSS for recent sphinx
>> net/mlx4: fix build with -fno-common
>> app: fix usage help of options separated by dashes
>> net/mvpp2: fix build with gcc 10
>> examples/vm_power: drop Unix path limit redefinition
>> doc: fix build with doxygen 1.8.18
>> doc: fix API index
>> mlx5: fix build with -fno-common
>> examples/vm_power: fix build with -fno-common
>>
>> Timothy Redaelli (3):
>> app/pipeline: fix build with gcc 10
>> examples/eventdev: fix build with gcc 10
>> crypto/octeontx: fix build with gcc 10
>>
>> Ting Xu (1):
>> app/testpmd: fix DCB set
>>
>> Vijaya Mohan Guvva (1):
>> bus/pci: fix UIO resource access from secondary process
>>
>> Wei Hu (Xavier) (2):
>> vfio: fix use after free with multiprocess
>> app/testpmd: fix statistics after reset
>>
>> Wei Zhao (4):
>> net/i40e: fix flow director for ARP packets
>> doc: add i40e limitation for flow director
>> net/i40e: fix flush of flow director filter
>> net/i40e: fix wild pointer
>>
>> Xiaolong Ye (3):
>> net/virtio: fix outdated comment
>> vhost: remove unused variable
>> doc: fix log level example in Linux guide
>>
>> Xiaoyu Min (1):
>> net/mlx5: fix RSS enablement
>>
>> Xiaoyun Li (2):
>> net/ixgbe/base: update copyright
>> net/i40e/base: update copyright
>>
>> Xuan Ding (2):
>> vhost: prevent zero-copy with incompatible client mode
>> vhost: fix zero-copy server mode
>>
>> Yunjian Wang (14):
>> kvargs: fix buffer overflow when parsing list
>> net/tap: remove unused assert
>> net/tap: fix mbuf and mem leak during queue release
>> net/tap: fix check for mbuf number of segment
>> net/tap: fix file close on remove
>> net/tap: fix fd leak on creation failure
>> net/tap: fix unexpected link handler
>> net/tap: fix queues fd check before close
>> net/octeontx: fix dangling pointer on init failure
>> crypto/ccp: fix fd leak on probe failure
>> net/failsafe: fix fd leak
>> crypto/caam_jr: fix check of file descriptors
>> crypto/caam_jr: fix IRQ functions return type
>> net/tap: fix mbuf double free when writev fails
>>
>> Yuri Chipchev (1):
>> event/dsw: fix enqueue burst return value
>>
>> Zhihong Peng (1):
>> net/ixgbe: fix link status synchronization on BSD
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 16:21 ` Kevin Traynor
@ 2020-06-30 16:32 ` Stokes, Ian
2020-06-30 17:03 ` Kevin Traynor
0 siblings, 1 reply; 16+ messages in thread
From: Stokes, Ian @ 2020-06-30 16:32 UTC (permalink / raw)
To: Kevin Traynor, Govindharajan, Hariprasad, stable, Loftus, Ciara
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Yu,
PingX, Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan,
Chen, Zhaoyan
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Tuesday, June 30, 2020 5:21 PM
> To: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
> stable@dpdk.org; Stokes, Ian <ian.stokes@intel.com>; Loftus, Ciara
> <ciara.loftus@intel.com>
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
>
> On 30/06/2020 16:38, Govindharajan, Hariprasad wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Traynor
> >> Sent: Friday, June 26, 2020 1:53 PM
> >> To: stable@dpdk.org
> >> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> >> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> >> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>;
> >> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> >> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
> >> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> >> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> >> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
> >> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
> >> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
> >> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> >> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test
> >>
> >> Hi all,
> >>
> >> Here is a list of patches targeted for LTS release 18.11.9.
> >>
> >> The planned date for the final release is 3rd July.
> >>
> >> Please help with testing and validation of your use cases and report
> >> any issues/results with reply-all to this mail. For the final release
> >> the fixes and reported validations will be added to the release notes.
> >>
> >> A release candidate tarball can be found at:
> >>
> >> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
> >>
> >> These patches are located at branch 18.11 of dpdk-stable repo:
> >> https://dpdk.org/browse/dpdk-stable/
> >>
> >> rc2:
> >> Creating this to include important VF fix.
> >> http://inbox.dpdk.org/dev/20200625035046.19820-1-
> >> haiyue.wang@intel.com/
> >>
> >> New patches in rc2:
> >> 145bb0e780 bus/pci: fix VF memory access
> >> 420a437247 net/tap: fix mbuf double free when writev fails
> >>
> >> Thanks.
> >>
> >> Kevin.
> > [Govindharajan, Hariprasad] Hi Kevin,
> >
>
> Hi G Hariprasad,
>
> Thanks for testing.
>
> > The following performance and functional tests carried out with ixgbe,
> > i40e and vhost devices
> >
> > DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12
> >
> > P2p throughput
> > P2p multi queue
> > PVP rss
> > vHost reconnect
> > Flow control
> >
> > Zero copy feature could not be tested.
> > From ovs, zero copy is used only vhost user client. So this particular patch
> 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy
> support in ovs.
> > so for ovs to move to support 18.11.9, it should probably remove support for
> zero-copy in the ovs code base?
> >
>
> The code says that zero copy is incompatible with vhost client mode.
> It seems that the check for client/server was incorrect, and now it is fixed and
> correctly detects this incompatible combination and returns an error to OVS.
>
> I don't think we can call that breaking. It was previously incompatible also, it just
> didn't return an error as there was a bug.
>
> I don't see an issue with having this patch and the new behaviour.
>
> Ian/Ciara, let me know if I'm missing something.
I think OVS only supports zero copy for vhostuserclient devices. In this case it looks like that’s no longer supported. I guess the real question becomes should the support in OVS be removed now? It is not broken as you said, just no longer supported in the OVS use case.
I don’t think it needs to block the release of this, but it's a follow up for the OVS. I believe you'd see the same behavior for OVS master and 2.13.
BR
Ian
>
> thanks,
> Kevin.
>
> > Regards
> > G Hariprasad
> >>
> >> ---
> >> Adam Dybkowski (2):
> >> app/crypto-perf: fix display of sample test vector
> >> cryptodev: fix SHA-1 digest enum comment
> >>
> >> Ajit Khaparde (3):
> >> net/bnxt: fix FW version query
> >> net/bnxt: fix error log for command timeout
> >> net/bnxt: fix using RSS config struct
> >>
> >> Alex Kiselev (1):
> >> lpm6: fix size of tbl8 group
> >>
> >> Alexander Kozyrev (1):
> >> net/mlx5: fix Tx queue release debug log timing
> >>
> >> Alvin Zhang (1):
> >> net/e1000: fix port hotplug for multi-process
> >>
> >> Amit Gupta (1):
> >> net/octeontx: fix meson build for disabled drivers
> >>
> >> Andrew Rybchenko (1):
> >> net/sfc: fix reported promiscuous/multicast mode
> >>
> >> Apeksha Gupta (1):
> >> bus/fslmc: fix dereferencing null pointer
> >>
> >> Arek Kusztal (1):
> >> crypto/qat: fix cipher descriptor for ZUC and SNOW
> >>
> >> Bing Zhao (1):
> >> mem: fix overflow on allocation
> >>
> >> Bruce Richardson (1):
> >> drivers: fix log type variables for -fno-common
> >>
> >> Cheng Peng (1):
> >> net/iavf: fix stats query error code
> >>
> >> Darek Stojaczyk (1):
> >> pci: accept 32-bit domain numbers
> >>
> >> David Christensen (2):
> >> pci: fix build on ppc
> >> eal/ppc: fix build with gcc 9.3
> >>
> >> David Marchand (4):
> >> mem: mark pages as not accessed when reserving VA
> >> eal: fix typo in endian conversion macros
> >> remove references to private PCI probe function
> >> doc: prefer https when pointing to dpdk.org
> >>
> >> Dekel Peled (2):
> >> net/mlx5: fix mask used for IPv6 item validation
> >> net/mlx5: fix CVLAN tag set in IP item translation
> >>
> >> Eugeny Parshutin (1):
> >> ethdev: fix build when vtune profiling is on
> >>
> >> Fan Zhang (1):
> >> vhost/crypto: add missing user protocol flag
> >>
> >> Ferruh Yigit (3):
> >> net/null: fix secondary burst function selection
> >> net/null: remove redundant check
> >> examples/kni: fix crash during MTU set
> >>
> >> Gaetan Rivet (4):
> >> doc: fix number of failsafe sub-devices
> >> net/ring: fix device pointer on allocation
> >> pci: reject negative values in PCI id
> >> kvargs: fix strcmp helper documentation
> >>
> >> Gavin Hu (1):
> >> net/i40e: relax barrier in Tx for NEON
> >>
> >> Guinan Sun (2):
> >> net/ixgbe: fix statistics in flow control mode
> >> net/ixgbe: check driver type in MACsec API
> >>
> >> Haifeng Lin (1):
> >> eal/arm64: fix precise TSC
> >>
> >> Haiyue Wang (1):
> >> bus/pci: fix VF memory access
> >>
> >> Harry van Haaren (3):
> >> service: fix crash on exit
> >> examples/eventdev: fix crash on exit
> >> test/flow_classify: enable multi-sockets system
> >>
> >> Hemant Agrawal (3):
> >> drivers: add crypto as dependency for event drivers
> >> bus/fslmc: fix size of qman fq descriptor
> >> mempool/dpaa2: install missing header with meson
> >>
> >> Honnappa Nagarahalli (2):
> >> service: fix race condition for MT unsafe service
> >> service: fix identification of service running on other lcore
> >>
> >> Igor Chauskin (2):
> >> net/ena/base: make allocation macros thread-safe
> >> net/ena/base: prevent allocation of zero sized memory
> >>
> >> Igor Romanov (7):
> >> net/sfc: fix initialization error path
> >> net/sfc: fix Rx queue start failure path
> >> net/sfc/base: reduce filter priorities to implemented only
> >> net/sfc/base: reject automatic filter creation by users
> >> net/sfc/base: refactor filter lookup loop in EF10
> >> net/sfc/base: handle manual and auto filter clashes in EF10
> >> net/sfc/base: fix manual filter delete in EF10
> >>
> >> Itsuro Oda (2):
> >> net/vhost: fix potential memory leak on close
> >> vhost: make IOTLB cache name unique among processes
> >>
> >> Ivan Dyukov (3):
> >> net/virtio-user: fix devargs parsing
> >> app: remove extra new line after link duplex
> >> examples: remove extra new line after link duplex
> >>
> >> Jasvinder Singh (3):
> >> net/softnic: fix memory leak for thread
> >> net/softnic: fix resource leak for pipeline
> >> examples/ip_pipeline: remove check of null response
> >>
> >> Jeff Guo (2):
> >> net/i40e: fix setting L2TAG
> >> net/iavf: fix setting L2TAG
> >>
> >> Jim Harris (1):
> >> contigmem: cleanup properly when load fails
> >>
> >> Junyu Jiang (2):
> >> examples/vmdq: fix output of pools/queues
> >> examples/vmdq: fix RSS configuration
> >>
> >> Kalesh AP (2):
> >> net/bnxt: fix VLAN add when port is stopped
> >> app/testpmd: fix memory failure handling for i40e DDP
> >>
> >> Kevin Traynor (14):
> >> kni: fix ethtool build with kernel 5.6
> >> net/avp: fix gcc 10 maybe-uninitialized warning
> >> eal/x86: ignore gcc 10 stringop-overflow warnings
> >> crypto/kasumi: fix extern declaration
> >> build: disable gcc 10 zero-length-bounds warning
> >> kni: fix ethtool dev_open build error
> >> kni: fix ethtool pointer type build error
> >> drivers/crypto: disable gcc 10 fno-common errors
> >> kni: fix gcc 10 ethtool build error
> >> kni: fix ethtool maybe-uninitialized warnings
> >> crypto/octeontx: fix gcc 10 -fno-common build errors
> >> app/testpmd: disable gcc 10 -fno-common build errors
> >> examples/vm_power: fix build because of missing include
> >> version: 18.11.9-rc1
> >>
> >> Konstantin Ananyev (1):
> >> security: fix crash at accessing non-implemented ops
> >>
> >> Li Feng (1):
> >> mem: mark pages as not accessed when freeing memory
> >>
> >> Louise Kilheeney (1):
> >> examples/l2fwd-keepalive: fix mbuf pool size
> >>
> >> Luca Boccassi (2):
> >> fix various typos found by Lintian
> >> usertools: check for pci.ids in /usr/share/misc
> >>
> >> Lukasz Wojciechowski (5):
> >> drivers/crypto: fix log type variables for -fno-common
> >> security: fix verification of parameters
> >> security: fix return types in documentation
> >> security: fix session counter
> >> test: remove redundant macro
> >>
> >> Mattias Rönnblom (3):
> >> event/dsw: remove redundant control ring poll
> >> event/dsw: remove unnecessary read barrier
> >> event/dsw: avoid reusing previously recorded events
> >>
> >> Michael Baum (1):
> >> net/mlx4: fix drop queue error handling
> >>
> >> Michael Haeuptle (1):
> >> vfio: fix race condition with sysfs
> >>
> >> Michal Krawczyk (5):
> >> net/ena/base: fix testing for supported hash function
> >> net/ena/base: fix documentation of functions
> >> net/ena/base: fix indentation in CQ polling
> >> net/ena/base: fix indentation of multiple defines
> >> net/ena: set IO ring size to valid value
> >>
> >> Muhammad Bilal (2):
> >> fix same typo in multiple places
> >> doc: fix typo in contributors guide
> >>
> >> Nicolas Chautru (1):
> >> bbdev: fix doxygen comments
> >>
> >> Nithin Dabilpuram (1):
> >> devtools: fix symbol map change check
> >>
> >> Olivier Matz (3):
> >> test/kvargs: fix to consider empty elements as valid
> >> test/kvargs: fix invalid cases check
> >> kvargs: fix invalid token parsing on FreeBSD
> >>
> >> Pablo de Lara (3):
> >> test/crypto: fix flag check
> >> crypto/openssl: fix out-of-place encryption
> >> doc: add NASM installation steps
> >>
> >> Pavan Nikhilesh (2):
> >> eventdev: fix probe and remove for secondary process
> >> app/eventdev: check Tx adapter service ID
> >>
> >> Phil Yang (1):
> >> service: remove rte prefix from static functions
> >>
> >> Qiming Yang (3):
> >> net/i40e: fix X722 performance
> >> doc: fix multicast filter feature announcement
> >> net/i40e: fix queue related exception handling
> >>
> >> Rasesh Mody (3):
> >> net/qede: fix link state configuration
> >> net/qede: fix port reconfiguration
> >> examples/kni: fix MTU change to setup Tx queue
> >>
> >> Raslan Darawsheh (3):
> >> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
> >> app/testpmd: add parsing for QinQ VLAN headers
> >> net/mlx5: fix matching for UDP tunnels with Verbs
> >>
> >> Rohit Raj (1):
> >> net/dpaa2: fix 10G port negotiation
> >>
> >> Roland Qi (1):
> >> vhost: fix peer close check
> >>
> >> Ruifeng Wang (1):
> >> test: skip some subtests in no-huge mode
> >>
> >> Sarosh Arif (1):
> >> doc: fix typo in contributors guide
> >>
> >> Somnath Kotur (1):
> >> bus/pci: fix devargs on probing again
> >>
> >> Stephen Hemminger (21):
> >> ethdev: fix spelling
> >> net/mvneta: do not use PMD log type
> >> net/virtio: do not use PMD log type
> >> net/tap: do not use PMD log type
> >> net/bnxt: do not use PMD log type
> >> net/dpaa: use dynamic log type
> >> net/thunderx: use dynamic log type
> >> net/netvsc: propagate descriptor limits from VF
> >> net/netvsc: handle Rx packets during multi-channel setup
> >> net/netvsc: split send buffers from Tx descriptors
> >> net/netvsc: fix memory free on device close
> >> net/netvsc: remove process event optimization
> >> net/netvsc: handle Tx completions based on burst size
> >> net/netvsc: avoid possible live lock
> >> lpm6: fix comments spelling
> >> eal: fix comments spelling
> >> net/netvsc: fix comment spelling
> >> bus/vmbus: fix comment spelling
> >> net/tap: fix crash in flow destroy
> >> eal: fix C++17 compilation
> >> net/vmxnet3: handle bad host framing
> >>
> >> Sunil Kumar Kori (1):
> >> eal: fix log message print for regex
> >>
> >> Thomas Monjalon (11):
> >> doc: fix sphinx compatibility
> >> log: fix level picked with globbing on type register
> >> doc: fix matrix CSS for recent sphinx
> >> net/mlx4: fix build with -fno-common
> >> app: fix usage help of options separated by dashes
> >> net/mvpp2: fix build with gcc 10
> >> examples/vm_power: drop Unix path limit redefinition
> >> doc: fix build with doxygen 1.8.18
> >> doc: fix API index
> >> mlx5: fix build with -fno-common
> >> examples/vm_power: fix build with -fno-common
> >>
> >> Timothy Redaelli (3):
> >> app/pipeline: fix build with gcc 10
> >> examples/eventdev: fix build with gcc 10
> >> crypto/octeontx: fix build with gcc 10
> >>
> >> Ting Xu (1):
> >> app/testpmd: fix DCB set
> >>
> >> Vijaya Mohan Guvva (1):
> >> bus/pci: fix UIO resource access from secondary process
> >>
> >> Wei Hu (Xavier) (2):
> >> vfio: fix use after free with multiprocess
> >> app/testpmd: fix statistics after reset
> >>
> >> Wei Zhao (4):
> >> net/i40e: fix flow director for ARP packets
> >> doc: add i40e limitation for flow director
> >> net/i40e: fix flush of flow director filter
> >> net/i40e: fix wild pointer
> >>
> >> Xiaolong Ye (3):
> >> net/virtio: fix outdated comment
> >> vhost: remove unused variable
> >> doc: fix log level example in Linux guide
> >>
> >> Xiaoyu Min (1):
> >> net/mlx5: fix RSS enablement
> >>
> >> Xiaoyun Li (2):
> >> net/ixgbe/base: update copyright
> >> net/i40e/base: update copyright
> >>
> >> Xuan Ding (2):
> >> vhost: prevent zero-copy with incompatible client mode
> >> vhost: fix zero-copy server mode
> >>
> >> Yunjian Wang (14):
> >> kvargs: fix buffer overflow when parsing list
> >> net/tap: remove unused assert
> >> net/tap: fix mbuf and mem leak during queue release
> >> net/tap: fix check for mbuf number of segment
> >> net/tap: fix file close on remove
> >> net/tap: fix fd leak on creation failure
> >> net/tap: fix unexpected link handler
> >> net/tap: fix queues fd check before close
> >> net/octeontx: fix dangling pointer on init failure
> >> crypto/ccp: fix fd leak on probe failure
> >> net/failsafe: fix fd leak
> >> crypto/caam_jr: fix check of file descriptors
> >> crypto/caam_jr: fix IRQ functions return type
> >> net/tap: fix mbuf double free when writev fails
> >>
> >> Yuri Chipchev (1):
> >> event/dsw: fix enqueue burst return value
> >>
> >> Zhihong Peng (1):
> >> net/ixgbe: fix link status synchronization on BSD
> >
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 16:32 ` Stokes, Ian
@ 2020-06-30 17:03 ` Kevin Traynor
2020-07-06 15:57 ` Kevin Traynor
0 siblings, 1 reply; 16+ messages in thread
From: Kevin Traynor @ 2020-06-30 17:03 UTC (permalink / raw)
To: Stokes, Ian, Govindharajan, Hariprasad, stable, Loftus, Ciara
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Yu,
PingX, Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan,
Chen, Zhaoyan
On 30/06/2020 17:32, Stokes, Ian wrote:
>
>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, June 30, 2020 5:21 PM
>> To: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
>> stable@dpdk.org; Stokes, Ian <ian.stokes@intel.com>; Loftus, Ciara
>> <ciara.loftus@intel.com>
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
>> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh
>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
>>
>> On 30/06/2020 16:38, Govindharajan, Hariprasad wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Traynor
>>>> Sent: Friday, June 26, 2020 1:53 PM
>>>> To: stable@dpdk.org
>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
>>>> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>;
>>>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
>>>> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>>>> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
>>>> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test
>>>>
>>>> Hi all,
>>>>
>>>> Here is a list of patches targeted for LTS release 18.11.9.
>>>>
>>>> The planned date for the final release is 3rd July.
>>>>
>>>> Please help with testing and validation of your use cases and report
>>>> any issues/results with reply-all to this mail. For the final release
>>>> the fixes and reported validations will be added to the release notes.
>>>>
>>>> A release candidate tarball can be found at:
>>>>
>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>>>>
>>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>> https://dpdk.org/browse/dpdk-stable/
>>>>
>>>> rc2:
>>>> Creating this to include important VF fix.
>>>> http://inbox.dpdk.org/dev/20200625035046.19820-1-
>>>> haiyue.wang@intel.com/
>>>>
>>>> New patches in rc2:
>>>> 145bb0e780 bus/pci: fix VF memory access
>>>> 420a437247 net/tap: fix mbuf double free when writev fails
>>>>
>>>> Thanks.
>>>>
>>>> Kevin.
>>> [Govindharajan, Hariprasad] Hi Kevin,
>>>
>>
>> Hi G Hariprasad,
>>
>> Thanks for testing.
>>
>>> The following performance and functional tests carried out with ixgbe,
>>> i40e and vhost devices
>>>
>>> DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12
>>>
>>> P2p throughput
>>> P2p multi queue
>>> PVP rss
>>> vHost reconnect
>>> Flow control
>>>
>>> Zero copy feature could not be tested.
>>> From ovs, zero copy is used only vhost user client. So this particular patch
>> 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy
>> support in ovs.
>>> so for ovs to move to support 18.11.9, it should probably remove support for
>> zero-copy in the ovs code base?
>>>
>>
>> The code says that zero copy is incompatible with vhost client mode.
>> It seems that the check for client/server was incorrect, and now it is fixed and
>> correctly detects this incompatible combination and returns an error to OVS.
>>
>> I don't think we can call that breaking. It was previously incompatible also, it just
>> didn't return an error as there was a bug.
>>
>> I don't see an issue with having this patch and the new behaviour.
>>
>> Ian/Ciara, let me know if I'm missing something.
>
> I think OVS only supports zero copy for vhostuserclient devices. In this case it looks like that’s no longer supported. I guess the real question becomes should the support in OVS be removed now? It is not broken as you said, just no longer supported in the OVS use case.
>
ah ok, it's not the commit above then, it's this one is the issue
commit 81e025d7ed6a802845909df6fb90505508dc0fbf
Author: Xuan Ding <xuan.ding@intel.com>
Date: Wed Apr 29 02:59:46 2020 +0000
vhost: prevent zero-copy with incompatible client mode
[ upstream commit 715070ea10e6da1169deef2a3ea77ae934b4c333 ]
In server mode, virtio-user inits under the assumption that vhost-user
supports a list of features. However, this could be problematic when
in_order feature is negotiated but not supported by vhost-user when
enables dequeue_zero_copy later.
Add handling when vhost-user enables dequeue_zero_copy as client.
--
It's unfortunate that it is both fixing a bug and removing functionality
at the same time :/
> I don’t think it needs to block the release of this, but it's a follow up for the OVS. I believe you'd see the same behavior for OVS master and 2.13.
>
Yes, these patches are already in 19.11.3.
> BR
> Ian
>
>>
>> thanks,
>> Kevin.
>>
>>> Regards
>>> G Hariprasad
>>>>
>>>> ---
>>>> Adam Dybkowski (2):
>>>> app/crypto-perf: fix display of sample test vector
>>>> cryptodev: fix SHA-1 digest enum comment
>>>>
>>>> Ajit Khaparde (3):
>>>> net/bnxt: fix FW version query
>>>> net/bnxt: fix error log for command timeout
>>>> net/bnxt: fix using RSS config struct
>>>>
>>>> Alex Kiselev (1):
>>>> lpm6: fix size of tbl8 group
>>>>
>>>> Alexander Kozyrev (1):
>>>> net/mlx5: fix Tx queue release debug log timing
>>>>
>>>> Alvin Zhang (1):
>>>> net/e1000: fix port hotplug for multi-process
>>>>
>>>> Amit Gupta (1):
>>>> net/octeontx: fix meson build for disabled drivers
>>>>
>>>> Andrew Rybchenko (1):
>>>> net/sfc: fix reported promiscuous/multicast mode
>>>>
>>>> Apeksha Gupta (1):
>>>> bus/fslmc: fix dereferencing null pointer
>>>>
>>>> Arek Kusztal (1):
>>>> crypto/qat: fix cipher descriptor for ZUC and SNOW
>>>>
>>>> Bing Zhao (1):
>>>> mem: fix overflow on allocation
>>>>
>>>> Bruce Richardson (1):
>>>> drivers: fix log type variables for -fno-common
>>>>
>>>> Cheng Peng (1):
>>>> net/iavf: fix stats query error code
>>>>
>>>> Darek Stojaczyk (1):
>>>> pci: accept 32-bit domain numbers
>>>>
>>>> David Christensen (2):
>>>> pci: fix build on ppc
>>>> eal/ppc: fix build with gcc 9.3
>>>>
>>>> David Marchand (4):
>>>> mem: mark pages as not accessed when reserving VA
>>>> eal: fix typo in endian conversion macros
>>>> remove references to private PCI probe function
>>>> doc: prefer https when pointing to dpdk.org
>>>>
>>>> Dekel Peled (2):
>>>> net/mlx5: fix mask used for IPv6 item validation
>>>> net/mlx5: fix CVLAN tag set in IP item translation
>>>>
>>>> Eugeny Parshutin (1):
>>>> ethdev: fix build when vtune profiling is on
>>>>
>>>> Fan Zhang (1):
>>>> vhost/crypto: add missing user protocol flag
>>>>
>>>> Ferruh Yigit (3):
>>>> net/null: fix secondary burst function selection
>>>> net/null: remove redundant check
>>>> examples/kni: fix crash during MTU set
>>>>
>>>> Gaetan Rivet (4):
>>>> doc: fix number of failsafe sub-devices
>>>> net/ring: fix device pointer on allocation
>>>> pci: reject negative values in PCI id
>>>> kvargs: fix strcmp helper documentation
>>>>
>>>> Gavin Hu (1):
>>>> net/i40e: relax barrier in Tx for NEON
>>>>
>>>> Guinan Sun (2):
>>>> net/ixgbe: fix statistics in flow control mode
>>>> net/ixgbe: check driver type in MACsec API
>>>>
>>>> Haifeng Lin (1):
>>>> eal/arm64: fix precise TSC
>>>>
>>>> Haiyue Wang (1):
>>>> bus/pci: fix VF memory access
>>>>
>>>> Harry van Haaren (3):
>>>> service: fix crash on exit
>>>> examples/eventdev: fix crash on exit
>>>> test/flow_classify: enable multi-sockets system
>>>>
>>>> Hemant Agrawal (3):
>>>> drivers: add crypto as dependency for event drivers
>>>> bus/fslmc: fix size of qman fq descriptor
>>>> mempool/dpaa2: install missing header with meson
>>>>
>>>> Honnappa Nagarahalli (2):
>>>> service: fix race condition for MT unsafe service
>>>> service: fix identification of service running on other lcore
>>>>
>>>> Igor Chauskin (2):
>>>> net/ena/base: make allocation macros thread-safe
>>>> net/ena/base: prevent allocation of zero sized memory
>>>>
>>>> Igor Romanov (7):
>>>> net/sfc: fix initialization error path
>>>> net/sfc: fix Rx queue start failure path
>>>> net/sfc/base: reduce filter priorities to implemented only
>>>> net/sfc/base: reject automatic filter creation by users
>>>> net/sfc/base: refactor filter lookup loop in EF10
>>>> net/sfc/base: handle manual and auto filter clashes in EF10
>>>> net/sfc/base: fix manual filter delete in EF10
>>>>
>>>> Itsuro Oda (2):
>>>> net/vhost: fix potential memory leak on close
>>>> vhost: make IOTLB cache name unique among processes
>>>>
>>>> Ivan Dyukov (3):
>>>> net/virtio-user: fix devargs parsing
>>>> app: remove extra new line after link duplex
>>>> examples: remove extra new line after link duplex
>>>>
>>>> Jasvinder Singh (3):
>>>> net/softnic: fix memory leak for thread
>>>> net/softnic: fix resource leak for pipeline
>>>> examples/ip_pipeline: remove check of null response
>>>>
>>>> Jeff Guo (2):
>>>> net/i40e: fix setting L2TAG
>>>> net/iavf: fix setting L2TAG
>>>>
>>>> Jim Harris (1):
>>>> contigmem: cleanup properly when load fails
>>>>
>>>> Junyu Jiang (2):
>>>> examples/vmdq: fix output of pools/queues
>>>> examples/vmdq: fix RSS configuration
>>>>
>>>> Kalesh AP (2):
>>>> net/bnxt: fix VLAN add when port is stopped
>>>> app/testpmd: fix memory failure handling for i40e DDP
>>>>
>>>> Kevin Traynor (14):
>>>> kni: fix ethtool build with kernel 5.6
>>>> net/avp: fix gcc 10 maybe-uninitialized warning
>>>> eal/x86: ignore gcc 10 stringop-overflow warnings
>>>> crypto/kasumi: fix extern declaration
>>>> build: disable gcc 10 zero-length-bounds warning
>>>> kni: fix ethtool dev_open build error
>>>> kni: fix ethtool pointer type build error
>>>> drivers/crypto: disable gcc 10 fno-common errors
>>>> kni: fix gcc 10 ethtool build error
>>>> kni: fix ethtool maybe-uninitialized warnings
>>>> crypto/octeontx: fix gcc 10 -fno-common build errors
>>>> app/testpmd: disable gcc 10 -fno-common build errors
>>>> examples/vm_power: fix build because of missing include
>>>> version: 18.11.9-rc1
>>>>
>>>> Konstantin Ananyev (1):
>>>> security: fix crash at accessing non-implemented ops
>>>>
>>>> Li Feng (1):
>>>> mem: mark pages as not accessed when freeing memory
>>>>
>>>> Louise Kilheeney (1):
>>>> examples/l2fwd-keepalive: fix mbuf pool size
>>>>
>>>> Luca Boccassi (2):
>>>> fix various typos found by Lintian
>>>> usertools: check for pci.ids in /usr/share/misc
>>>>
>>>> Lukasz Wojciechowski (5):
>>>> drivers/crypto: fix log type variables for -fno-common
>>>> security: fix verification of parameters
>>>> security: fix return types in documentation
>>>> security: fix session counter
>>>> test: remove redundant macro
>>>>
>>>> Mattias Rönnblom (3):
>>>> event/dsw: remove redundant control ring poll
>>>> event/dsw: remove unnecessary read barrier
>>>> event/dsw: avoid reusing previously recorded events
>>>>
>>>> Michael Baum (1):
>>>> net/mlx4: fix drop queue error handling
>>>>
>>>> Michael Haeuptle (1):
>>>> vfio: fix race condition with sysfs
>>>>
>>>> Michal Krawczyk (5):
>>>> net/ena/base: fix testing for supported hash function
>>>> net/ena/base: fix documentation of functions
>>>> net/ena/base: fix indentation in CQ polling
>>>> net/ena/base: fix indentation of multiple defines
>>>> net/ena: set IO ring size to valid value
>>>>
>>>> Muhammad Bilal (2):
>>>> fix same typo in multiple places
>>>> doc: fix typo in contributors guide
>>>>
>>>> Nicolas Chautru (1):
>>>> bbdev: fix doxygen comments
>>>>
>>>> Nithin Dabilpuram (1):
>>>> devtools: fix symbol map change check
>>>>
>>>> Olivier Matz (3):
>>>> test/kvargs: fix to consider empty elements as valid
>>>> test/kvargs: fix invalid cases check
>>>> kvargs: fix invalid token parsing on FreeBSD
>>>>
>>>> Pablo de Lara (3):
>>>> test/crypto: fix flag check
>>>> crypto/openssl: fix out-of-place encryption
>>>> doc: add NASM installation steps
>>>>
>>>> Pavan Nikhilesh (2):
>>>> eventdev: fix probe and remove for secondary process
>>>> app/eventdev: check Tx adapter service ID
>>>>
>>>> Phil Yang (1):
>>>> service: remove rte prefix from static functions
>>>>
>>>> Qiming Yang (3):
>>>> net/i40e: fix X722 performance
>>>> doc: fix multicast filter feature announcement
>>>> net/i40e: fix queue related exception handling
>>>>
>>>> Rasesh Mody (3):
>>>> net/qede: fix link state configuration
>>>> net/qede: fix port reconfiguration
>>>> examples/kni: fix MTU change to setup Tx queue
>>>>
>>>> Raslan Darawsheh (3):
>>>> net/mlx5: fix validation of VXLAN/VXLAN-GPE specs
>>>> app/testpmd: add parsing for QinQ VLAN headers
>>>> net/mlx5: fix matching for UDP tunnels with Verbs
>>>>
>>>> Rohit Raj (1):
>>>> net/dpaa2: fix 10G port negotiation
>>>>
>>>> Roland Qi (1):
>>>> vhost: fix peer close check
>>>>
>>>> Ruifeng Wang (1):
>>>> test: skip some subtests in no-huge mode
>>>>
>>>> Sarosh Arif (1):
>>>> doc: fix typo in contributors guide
>>>>
>>>> Somnath Kotur (1):
>>>> bus/pci: fix devargs on probing again
>>>>
>>>> Stephen Hemminger (21):
>>>> ethdev: fix spelling
>>>> net/mvneta: do not use PMD log type
>>>> net/virtio: do not use PMD log type
>>>> net/tap: do not use PMD log type
>>>> net/bnxt: do not use PMD log type
>>>> net/dpaa: use dynamic log type
>>>> net/thunderx: use dynamic log type
>>>> net/netvsc: propagate descriptor limits from VF
>>>> net/netvsc: handle Rx packets during multi-channel setup
>>>> net/netvsc: split send buffers from Tx descriptors
>>>> net/netvsc: fix memory free on device close
>>>> net/netvsc: remove process event optimization
>>>> net/netvsc: handle Tx completions based on burst size
>>>> net/netvsc: avoid possible live lock
>>>> lpm6: fix comments spelling
>>>> eal: fix comments spelling
>>>> net/netvsc: fix comment spelling
>>>> bus/vmbus: fix comment spelling
>>>> net/tap: fix crash in flow destroy
>>>> eal: fix C++17 compilation
>>>> net/vmxnet3: handle bad host framing
>>>>
>>>> Sunil Kumar Kori (1):
>>>> eal: fix log message print for regex
>>>>
>>>> Thomas Monjalon (11):
>>>> doc: fix sphinx compatibility
>>>> log: fix level picked with globbing on type register
>>>> doc: fix matrix CSS for recent sphinx
>>>> net/mlx4: fix build with -fno-common
>>>> app: fix usage help of options separated by dashes
>>>> net/mvpp2: fix build with gcc 10
>>>> examples/vm_power: drop Unix path limit redefinition
>>>> doc: fix build with doxygen 1.8.18
>>>> doc: fix API index
>>>> mlx5: fix build with -fno-common
>>>> examples/vm_power: fix build with -fno-common
>>>>
>>>> Timothy Redaelli (3):
>>>> app/pipeline: fix build with gcc 10
>>>> examples/eventdev: fix build with gcc 10
>>>> crypto/octeontx: fix build with gcc 10
>>>>
>>>> Ting Xu (1):
>>>> app/testpmd: fix DCB set
>>>>
>>>> Vijaya Mohan Guvva (1):
>>>> bus/pci: fix UIO resource access from secondary process
>>>>
>>>> Wei Hu (Xavier) (2):
>>>> vfio: fix use after free with multiprocess
>>>> app/testpmd: fix statistics after reset
>>>>
>>>> Wei Zhao (4):
>>>> net/i40e: fix flow director for ARP packets
>>>> doc: add i40e limitation for flow director
>>>> net/i40e: fix flush of flow director filter
>>>> net/i40e: fix wild pointer
>>>>
>>>> Xiaolong Ye (3):
>>>> net/virtio: fix outdated comment
>>>> vhost: remove unused variable
>>>> doc: fix log level example in Linux guide
>>>>
>>>> Xiaoyu Min (1):
>>>> net/mlx5: fix RSS enablement
>>>>
>>>> Xiaoyun Li (2):
>>>> net/ixgbe/base: update copyright
>>>> net/i40e/base: update copyright
>>>>
>>>> Xuan Ding (2):
>>>> vhost: prevent zero-copy with incompatible client mode
>>>> vhost: fix zero-copy server mode
>>>>
>>>> Yunjian Wang (14):
>>>> kvargs: fix buffer overflow when parsing list
>>>> net/tap: remove unused assert
>>>> net/tap: fix mbuf and mem leak during queue release
>>>> net/tap: fix check for mbuf number of segment
>>>> net/tap: fix file close on remove
>>>> net/tap: fix fd leak on creation failure
>>>> net/tap: fix unexpected link handler
>>>> net/tap: fix queues fd check before close
>>>> net/octeontx: fix dangling pointer on init failure
>>>> crypto/ccp: fix fd leak on probe failure
>>>> net/failsafe: fix fd leak
>>>> crypto/caam_jr: fix check of file descriptors
>>>> crypto/caam_jr: fix IRQ functions return type
>>>> net/tap: fix mbuf double free when writev fails
>>>>
>>>> Yuri Chipchev (1):
>>>> event/dsw: fix enqueue burst return value
>>>>
>>>> Zhihong Peng (1):
>>>> net/ixgbe: fix link status synchronization on BSD
>>>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-30 17:03 ` Kevin Traynor
@ 2020-07-06 15:57 ` Kevin Traynor
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Traynor @ 2020-07-06 15:57 UTC (permalink / raw)
To: Stokes, Ian, Govindharajan, Hariprasad, stable, Loftus, Ciara
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani, Walker,
Benjamin, David Christensen, Hemant Agrawal, Jerin Jacob,
Mcnamara, John, Ju-Hyoung Lee, Luca Boccassi, Pei Zhang, Yu,
PingX, Xu, Qian Q, Raslan Darawsheh, Thomas Monjalon, Peng, Yuan,
Chen, Zhaoyan
On 30/06/2020 18:03, Kevin Traynor wrote:
> On 30/06/2020 17:32, Stokes, Ian wrote:
>>
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Tuesday, June 30, 2020 5:21 PM
>>> To: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
>>> stable@dpdk.org; Stokes, Ian <ian.stokes@intel.com>; Loftus, Ciara
>>> <ciara.loftus@intel.com>
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>>> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>>> Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Luca
>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
>>> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh
>>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>> Subject: Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
>>>
>>> On 30/06/2020 16:38, Govindharajan, Hariprasad wrote:
>>>>
>>>>> -----Original Message-----
>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Traynor
>>>>> Sent: Friday, June 26, 2020 1:53 PM
>>>>> To: stable@dpdk.org
>>>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>>>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
>>>>> <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>;
>>>>> David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
>>>>> <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin
>>>>> Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
>>>>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
>>>>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>>>>> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
>>>>> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
>>>>> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
>>>>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>>>>> Subject: [dpdk-dev] 18.11.9 (LTS) patches review and test
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Here is a list of patches targeted for LTS release 18.11.9.
>>>>>
>>>>> The planned date for the final release is 3rd July.
>>>>>
>>>>> Please help with testing and validation of your use cases and report
>>>>> any issues/results with reply-all to this mail. For the final release
>>>>> the fixes and reported validations will be added to the release notes.
>>>>>
>>>>> A release candidate tarball can be found at:
>>>>>
>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>>>>>
>>>>> These patches are located at branch 18.11 of dpdk-stable repo:
>>>>> https://dpdk.org/browse/dpdk-stable/
>>>>>
>>>>> rc2:
>>>>> Creating this to include important VF fix.
>>>>> http://inbox.dpdk.org/dev/20200625035046.19820-1-
>>>>> haiyue.wang@intel.com/
>>>>>
>>>>> New patches in rc2:
>>>>> 145bb0e780 bus/pci: fix VF memory access
>>>>> 420a437247 net/tap: fix mbuf double free when writev fails
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Kevin.
>>>> [Govindharajan, Hariprasad] Hi Kevin,
>>>>
>>> Hi G Hariprasad,
>>>
>>> Thanks for testing.
>>>
>>>> The following performance and functional tests carried out with ixgbe,
>>>> i40e and vhost devices
>>>>
>>>> DPDK 18.11.9 RC2 with OvS 2.11 and OvS 2.12
>>>>
>>>> P2p throughput
>>>> P2p multi queue
>>>> PVP rss
>>>> vHost reconnect
>>>> Flow control
>>>>
>>>> Zero copy feature could not be tested.
>>>> From ovs, zero copy is used only vhost user client. So this particular patch
>>> 0309429b198800f4d17d578aad650672476ba054 is breaking the zero copy
>>> support in ovs.
>>>> so for ovs to move to support 18.11.9, it should probably remove support for
>>> zero-copy in the ovs code base?
>>> The code says that zero copy is incompatible with vhost client mode.
>>> It seems that the check for client/server was incorrect, and now it is fixed and
>>> correctly detects this incompatible combination and returns an error to OVS.
>>>
>>> I don't think we can call that breaking. It was previously incompatible also, it just
>>> didn't return an error as there was a bug.
>>>
>>> I don't see an issue with having this patch and the new behaviour.
>>>
>>> Ian/Ciara, let me know if I'm missing something.
>> I think OVS only supports zero copy for vhostuserclient devices. In this case it looks like that’s no longer supported. I guess the real question becomes should the support in OVS be removed now? It is not broken as you said, just no longer supported in the OVS use case.
>>
> ah ok, it's not the commit above then, it's this one is the issue
>
> commit 81e025d7ed6a802845909df6fb90505508dc0fbf
> Author: Xuan Ding <xuan.ding@intel.com>
> Date: Wed Apr 29 02:59:46 2020 +0000
>
> vhost: prevent zero-copy with incompatible client mode
>
> [ upstream commit 715070ea10e6da1169deef2a3ea77ae934b4c333 ]
>
> In server mode, virtio-user inits under the assumption that vhost-user
> supports a list of features. However, this could be problematic when
> in_order feature is negotiated but not supported by vhost-user when
> enables dequeue_zero_copy later.
>
> Add handling when vhost-user enables dequeue_zero_copy as client.
> --
>
> It's unfortunate that it is both fixing a bug and removing functionality
> at the same time :/
>
Just to wrap up this topic on this thread. We discussed further on
ovs-dev https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/372320.html
The patches that were removing the functionality have now (effectively)
been reverted from 18.11. For 19.11 this will happen too for the next
release.
Ian replied that OVS testing is now passing with latest 18.11 branch
https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/372535.html
>> I don’t think it needs to block the release of this, but it's a follow up for the OVS. I believe you'd see the same behavior for OVS master and 2.13.
>>
> Yes, these patches are already in 19.11.3.
>
>> BR
>> Ian
>>
>>> thanks,
>>> Kevin.
>>>
>>>> Regards
>>>> G Hariprasad
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] 18.11.9 (LTS) patches review and test
2020-06-26 12:53 Kevin Traynor
` (3 preceding siblings ...)
2020-06-30 15:38 ` Govindharajan, Hariprasad
@ 2020-07-03 17:26 ` Kevin Traynor
4 siblings, 0 replies; 16+ messages in thread
From: Kevin Traynor @ 2020-07-03 17:26 UTC (permalink / raw)
To: stable
Cc: dev, Abhishek Marathe, Akhil Goyal, Ali Alnubani,
benjamin.walker, David Christensen, Hemant Agrawal, Ian Stokes,
Jerin Jacob, John McNamara, Ju-Hyoung Lee, Luca Boccassi,
Pei Zhang, pingx.yu, qian.q.xu, Raslan Darawsheh,
Thomas Monjalon, yuan.peng, zhaoyan.chen
Hi Abhishek,
Do you have any results from Microsoft testing?
There is a few remaining items to be re-validated elsewhere, but we
should be ok for release early next week.
thanks,
Kevin.
On 26/06/2020 13:53, Kevin Traynor wrote:
> Hi all,
>
> Here is a list of patches targeted for LTS release 18.11.9.
>
> The planned date for the final release is 3rd July.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.9-rc2
>
> These patches are located at branch 18.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> rc2:
> Creating this to include important VF fix.
> http://inbox.dpdk.org/dev/20200625035046.19820-1-haiyue.wang@intel.com/
>
> New patches in rc2:
> 145bb0e780 bus/pci: fix VF memory access
> 420a437247 net/tap: fix mbuf double free when writev fails
>
> Thanks.
>
> Kevin.
^ permalink raw reply [flat|nested] 16+ messages in thread