From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E847AA0350; Mon, 22 Jun 2020 23:54:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CBF11D544; Mon, 22 Jun 2020 23:54:16 +0200 (CEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by dpdk.org (Postfix) with ESMTP id 65FAA1D53E for ; Mon, 22 Jun 2020 23:54:15 +0200 (CEST) Received: by mail-lj1-f181.google.com with SMTP id i3so21121028ljg.3 for ; Mon, 22 Jun 2020 14:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0YaSAm94ix/LoX+abXV7PLeVeA1oV7jxnLP7kb5xogY=; b=aGw4xYgVOKuXQfo4WgPangpxWbmhdt1RfyPrGUFcx2ZRz0yj33JbyOnnhTtMipb1P9 kHs7FEwMGXquflGPR03G1JNfhR3x27nf+iTUj42+tw9amQzgGJIznUkhYx0zMWlZVFen 95ND/FQLOghH8xaDdnrNP6xE3jjBSSX5+XCOs3rcVB9slngIh2RRkdan6I69E2nN44N5 RMLMfEM3X21qJk4XYq2HVGCrrtn7xrIAcnAfDul7VMnhgWaaa5pFeK2h6kG6XR0iwVwV iSDldmTqFaGq1rBwSIQvTh389a1CmMHaLry83ywi5b8nORgcsvgTDOeDqSaNzEZ5UJYN OmNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0YaSAm94ix/LoX+abXV7PLeVeA1oV7jxnLP7kb5xogY=; b=FAkONUQG7W8dAEKe8bItHWJmTTbEn4W/l04+PHkQ+eE5nOR20tFcuksT3TB+kGLgFU L50mIe3pkP7u+KrtVHK6lPtPprEl/JmZGEMdS1RYxROswYy1f6+PuGoz4L7y7aTzTj+/ ydbQWvKT1l/sTfnkCEcNszEqEPJyQZGnYVwUScUjSSBCMM+QBeFNl/5Pdlsvr6wF4tcL JbZlBY622ZvHWJF4M9OusjBwii0UefFqi9lGPgddNWEy1JFC5xnqcp/g8QiA/aWMyPmj x+zfOudZnZr9eXNyrZZ+ONxRID/XbBCyrIqZVxT+2Ip0uP/EqTt/YhTVHncK0tWU0VLO olvQ== X-Gm-Message-State: AOAM533d7laxynaKbWYRqyDx+lC4nzEJSm9Za8TXEHqlUw5zKaC/i3am Cz6fnyUDut4PjiQ9pHSOI30= X-Google-Smtp-Source: ABdhPJzgvdTtVDBOCfVo8IChfSukSu77Aw/3iLdjUEZxbZbsQrUHt2J6daNgBZgrq0K07UVSEV4fVQ== X-Received: by 2002:a2e:7804:: with SMTP id t4mr603479ljc.8.1592862854828; Mon, 22 Jun 2020 14:54:14 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id q1sm2913471lji.71.2020.06.22.14.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 14:54:13 -0700 (PDT) Date: Tue, 23 Jun 2020 00:54:12 +0300 From: Dmitry Kozlyuk To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Message-ID: <20200623005412.64e97355@sovereign> In-Reply-To: <20200622075529.24180-3-talshn@mellanox.com> References: <20200621102612.22740-2-talshn@mellanox.com> <20200622075529.24180-1-talshn@mellanox.com> <20200622075529.24180-3-talshn@mellanox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/9] pci: use OS generic memory mapping functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 22 Jun 2020 10:55:22 +0300 talshn@mellanox.com wrote: [snip] > @@ -176,10 +177,10 @@ pci_unmap_resource(void *requested_addr, size_t size) > return; > > /* Unmap the PCI memory resource of device */ > - if (munmap(requested_addr, size)) { > - RTE_LOG(ERR, EAL, "%s(): cannot munmap(%p, %#zx): %s\n", > + if (rte_mem_unmap(requested_addr, size)) { > + RTE_LOG(ERR, EAL, "%s(): cannot mem unmap(%p, %#zx): %s\n", > __func__, requested_addr, size, > - strerror(errno)); > + rte_strerror(errno)); errno -> rte_errno -- Dmitry Kozlyuk